[Bug 13087] New: Add a notice for use_zebra_facets problems in about page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13087 Bug ID: 13087 Summary: Add a notice for use_zebra_facets problems in about page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: About Assignee: nengard@gmail.com Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org 11232 introduced the use of Zebra facets. A way of telling the user that a conflicting configuration is set needs to be added to the about page. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13087 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11232 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13087 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 32603 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32603&action=edit Bug 13087: Add a notice for use_zebra_facets problems in about page This patch adds two checks to about.pl: - use_zebra_facets entry presence in koha-conf.xml - use_zebra_facets==1 and zebra_bib_index_mode==dom The idea is to alert the user if it has conflicting or wrong settings. Even if there's a fallback to a working configuration. To test: - On clean master install, go to the about page => SUCCESS: No warnings regarding use_zebra_facets - Comment out the use_zebra_facets entry, reload => SUCCESS: The about page mentions the use_zebra_facets entry is missing - Uncomment the use_zebra_facets entry, make sure it is set to 1 - Change zebra_bib_index_mode to 'grs1', reload => SUCCESS: The about page says zebra_bib_index_mode is not set to DOM even though you have use_zebra_facets set. - Sign off :-D Regards To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13087 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13087 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|nengard@gmail.com |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13087 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13087 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32603|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 32628 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32628&action=edit [SIGNED-OFF] Bug 13087: Add a notice for use_zebra_facets problems in about page This patch adds two checks to about.pl: - use_zebra_facets entry presence in koha-conf.xml - use_zebra_facets==1 and zebra_bib_index_mode==dom The idea is to alert the user if it has conflicting or wrong settings. Even if there's a fallback to a working configuration. To test: - On clean master install, go to the about page => SUCCESS: No warnings regarding use_zebra_facets - Comment out the use_zebra_facets entry, reload => SUCCESS: The about page mentions the use_zebra_facets entry is missing - Uncomment the use_zebra_facets entry, make sure it is set to 1 - Change zebra_bib_index_mode to 'grs1', reload => SUCCESS: The about page says zebra_bib_index_mode is not set to DOM even though you have use_zebra_facets set. - Sign off :-D Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Owen Leonard <oleonard@myacpl.org> Followed test plan with success -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13087 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13087 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32628|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 32652 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32652&action=edit [PASSED QA] Bug 13087: Add a notice for use_zebra_facets problems in about page This patch adds two checks to about.pl: - use_zebra_facets entry presence in koha-conf.xml - use_zebra_facets==1 and zebra_bib_index_mode==dom The idea is to alert the user if it has conflicting or wrong settings. Even if there's a fallback to a working configuration. To test: - On clean master install, go to the about page => SUCCESS: No warnings regarding use_zebra_facets - Comment out the use_zebra_facets entry, reload => SUCCESS: The about page mentions the use_zebra_facets entry is missing - Uncomment the use_zebra_facets entry, make sure it is set to 1 - Change zebra_bib_index_mode to 'grs1', reload => SUCCESS: The about page says zebra_bib_index_mode is not set to DOM even though you have use_zebra_facets set. - Sign off :-D Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Owen Leonard <oleonard@myacpl.org> Followed test plan with success Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, tested by changing the koha-conf.xml file. Note: There is no warning if use_zebra_facets is 0. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13087 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13087 Bug 13087 depends on bug 11232, which changed state. Bug 11232 Summary: Retrieve facets from Zebra http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13087 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org