http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9352 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9352 --- Comment #2 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Solution : This patch makes indexing of unimarc 7XX fields more specific. For each field, useless subfields are not indexed. 70X : Do not index $f (dates),$c (additions other than dates),$p (affiliation/address),$3,$4. Index $9 only in Koha-Auth-Number. 710-712 : Do not index $p (affiliation/address),$3,$4. Index $9 only in Koha-Auth-Number. (I kept all other subfields : even if some may be useless I am not sure of it) 716 : Do not index $f (dates),$c (additions other than dates),$3,$4. Index $9 only in Koha-Auth-Number. 72X : Do not index $f (dates),$3,$4. Index $9 only in Koha-Auth-Number. 730 : Do not index $4. Index $9 only in Koha-Auth-Number. Additionnaly, this patch indexes 205$f/$g in Author index (author of the edition of the work) Testing : a/ Create a record with 700$a Doe $b John $f1950 $cteacher $4070 716$a Trademark $f1960 $cgreat $4340 720$a Family $f1980 $4651 205$a 1st edition $fBy some guy $gAnd other guys a/ Before applying patch : Search in simple search and author search : "teacher", "great", "1950", "070", "340", "651" => you will see the record among the results Search in simple search and author search : "Doe", "John Doe", "Trademark", "Family" => you will see the record among the results Search in simple search and author search : "guy", "guys" => you will not see the record among the results b/ Before applying patch : Search in simple search and author search : "teacher", "great", "1950", "070", "340", "651" => you will not see the record among the results Search in simple search and author search : "Doe", "John Doe", "Trademark", "Family" => you will see the record among the results Search in simple search and author search : "guy", "guys" => you will see the record among the results -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9352 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9352 --- Comment #4 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Grrr, I made typos on testing plan. So it is : a/ Create a record b/ Before applying patch, try some searches c/ Apply d/ Rebuild zebra e/ Try the same searches as before M. Saby -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9352 --- Comment #6 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Testing : a/ Create a record with : 700$a Doe $b John $f1950 $cteacher $4070 710$a Corporate $b Meeting $q Address 716$a Trademark $f1960 $cgreat $4340 720$a Family $f1980 $4651 205$a 1st edition $fBy some guy $gAnd other guys b/ Before applying patch, make several searches : Search in simple search and author search : "teacher", "great", "Address", "1950", "1960", "070", "340", "651" => you will see the record among the results Search in simple search and author search : "Doe", "John Doe", "Trademark", "Family","corporate", "meeting" => you will see the record among the results Search in simple search and author search : "guy", "guys" => you will see the record among the results with simple search (because 205 is indexed in title) => you will not see the record among the results with author search c/ Apply patch d/ Rebuild Zebra with ./misc/migration_tools/rebuild_zebra.pl -b -x -v -reset e/ Try the same searches as before : Search in simple search and author search : "teacher", "great", "Address", "1950", "1960", "070", "340", "651" => you will not see the record among the results Search in simple search and author search : "Doe", "John Doe", "Trademark", "Family","corporate", "meeting" => you will see the record among the results Search in simple search and author search : "guy", "guys" => you will see the record among the results in both simple search and author search -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9352 --- Comment #8 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- OK Frederic. I am not sure the patch will have visible effects if you have authorities indexed. Maybe I should try to do the same kind of patch for authorities? Mathieu -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9352 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14439|0 |1 is obsolete| | --- Comment #10 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Created attachment 15228 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15228&action=edit [PATCH 1/2] Bug 9352 : More specific indexing of UNIMARC 7XX fields (GRS1) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9352 --- Comment #12 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- 2 patches, one for GRS1 and one for DOM indexing. Each need to be tested separately. M. Saby -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9352 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8962 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9352 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #15 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Half signed, works well with GRS1 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9352 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot@bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #17 from I'm just a bot <gitbot@bugs.koha-community.org> --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9352 --- Comment #19 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- I would like to see this patch and the other ones about unimarc pushed before making my patch for configuring facets. Otherwise there would be too many dependancies. Mathieu -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9352 --- Comment #21 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Hi Not sure what comment you refer to ;-) What is needed is applying attachment 15229 on a DOM Unimarc Koha, and testing it (copying modified configuration files into {installdir}/etc/zebra.... and rebuild_zebra.pl) As it is pure copy of the patch for GRS1, I'd say there is no need to test ALL the items of the test plan. If it was working for GRS1, it *must* work with DOM. And if there is something wrong, the QA team will tell us. Maybe just check you can still search for authors after the pach is applied, and that the search is limited to the fistname + family name of the author (not his birthdate, nor his function code in $4 subfield) You're very kind for proposing your help. Mathieu -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9352 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- When did the bot|2013-09-29 00:00:00 |2013-10-28 last check this| | --- Comment #23 from I'm just a bot <gitbot@bugs.koha-community.org> --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9352 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- When did the bot|2013-10-28 00:00:00 |2013-11-23 last check this| | --- Comment #24 from I'm just a bot <gitbot@bugs.koha-community.org> --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9352 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|9351 | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9352 --- Comment #26 from mathieu saby <mathsabypro@gmail.com> --- Hello I was about to suggest it to you ;-) I think I will have time to do that tomorrow. Mathieu -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9352 mathieu saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21788|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9352 --- Comment #29 from Nick Clemens <nick@quecheelibrary.org> --- Applied on patch 2 for testing. Test plan says to add Address to subfield $q - I can't find that field, did you mean $p? - I assumed yes Before patch all worked as expected After applying results were as below, looks like 716 is still indexed: (ss=simple search au:author search) teacher: ss-y au-n great: ss-y au-y Address: ss-y au-n 1950: ss-y au-n 1960: ss-y au-y 070: ss-y au-n 340: ss-y au-y 651: ss-y au-n Doe: ss-y au-y John Doe: ss-y au-n (though yes as:Doe, John) Trademark: ss-y au-y Family: ss-y au-y corporate: ss-y au-y meeting: ss-y au-y guy: ss-y au-y guys: ss-y au-n ti:falsetitle - 1 result -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9352 --- Comment #31 from mathieu saby <mathsabypro@gmail.com> --- I'm not sure to understand your test. You mean it is ok for 7XX in general but not for 716? M. Saby -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9352 --- Comment #33 from mathieu saby <mathsabypro@gmail.com> --- I understand: I wrote <index_data_field xmlns="http://www.koha-community.org/schemas/index-defs" tag="716" subfields="a"> this should be <index_subfields xmlns="http://www.koha-community.org/schemas/index-defs" tag="716" subfields="a"> I will fix that tomorrow M. Saby -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9352 --- Comment #35 from mathieu saby <mathsabypro@gmail.com> --- I rewrote the 2d patch for fixing the issue with 716 field. You can test again, only 716 field. M. Saby -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9352 mathieu saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31143|0 |1 is obsolete| | --- Comment #37 from mathieu saby <mathsabypro@gmail.com> --- Created attachment 31151 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31151&action=edit [PATCH 2] Bug 9352 : More specific indexing of UNIMARC 7XX fields (DOM) My fault! Try that. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9352 --- Comment #38 from mathieu saby <mathsabypro@gmail.com> --- I rewrote it quickly witout regenerating the patch, but I suppose it will work, as the count of lines will be the same. If it does not apply, I will take more time to rewrite it (not the good machine this evening) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9352 --- Comment #40 from mathieu saby <mathsabypro@gmail.com> --- (In reply to Nick Clemens from comment #39)

Patch applied cleanly,guys and 'other guys' now both indexed.

I was feeling peppy though, so I retested all searches and came across one small issue searching for 'John Doe'

Simple search works as both 'doe, john' or 'john doe'

Author search from dropdown (in advanced search or OPAC) works as both 'doe, john' or 'john doe'

CCL search DOES NOT work foir either 'au:doe, john' or 'au:john doe' or for any other records/authors

Any cause you could see for that?

Weird. And did it work for "au:john doe" before applying the patch? With the patch, does it work for "au:doe" or "au:john"? and for other indexes (ti, etc.) ? did you try with and without Queryparser activated? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9352 --- Comment #42 from Nick Clemens <nick@quecheelibrary.org> --- No, with patches applied, files copied, zebra rebuilt: "au:doe john" gives no results I switched to master, recopied files, rebuilt zebra: "au:doe john" gives 1 result "au:john doe" gives no results in either Quotes are not part of search, just to indicate exactly what I typed into the search bar. With queryparser on the order of the terms doesn't matter, 1 result is returned either way, both in master and with patch applied. Sorry, didn't mean to find a new problem, I am just in the habit of always using the CCL terms -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9352 --- Comment #44 from mathieu saby <mathsabypro@gmail.com> --- Created attachment 31314 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31314&action=edit [PATCH 3/3] Add a new XSLT template for indexing goup of subfields as a whole -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9352 mathieu saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #46 from mathieu saby <mathsabypro@gmail.com> --- The last patch is broken somewhere, please don't test -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9352 --- Comment #48 from mathieu saby <mathsabypro@gmail.com> --- NEW 3RD PATCH: This patch adds a new template in koha-indexdefs-to-zebra.xsl in order to index a specific goup of subfields as a whole. It can be used for indexing as a "phrase" a string resulting from the concatenation of some indexes (with a space between them) To use this new template, use the new "index_group_of_subfields" element in biblio-koha-indexdefs.xml, in the same way you used index_subfields Ex : to index the concatenation of "$a $b $d $g" subfields of 700 UNIMARC field in Author:p <index_group_of_subfields xmlns="http://www.koha-community.org/schemas/index-defs" tag="700" subfields="abdg"> <target_index>Author:p</target_index> </index_group_of_subfields> This patch also change the biblio-koha-indexdefs.xml and biblio-zebra-indexdefs.xsl for UNIMARC, in order to use this new template for 700-712 fields For 700 and 710, it also indexes in "Author:s" (used for sorting) the concatenation of subfields instead of only the $a subfield To test : in a DOM UNIMARC Koha, apply all the patches, copy the modified files in your Zebra configuration directory, rebuild zebra, and make some tests Everything should be the same as when only the first 2 patches were applied, EXCEPT this behavior: - create a record with 700$aDoe$bJohn (and nothing in 200$f or $g) - Go in Advanced Search, and select the "Author as phrase" index - with only the first 2 patches, you will have 0 result if you enter "Doe John" or "Doe John" - with the 3 patches, you will have 1 result if you enter "Doe John" or "Doe John" - same kind of test for 710 field - the logic is the same for 701, 702,711, 712. So, no need to test - make some searches and test the sorting of your results by author name ("Author A-Z" and "Author Z-A"). The complete name of main author (700 and 710) sould be used for sorting the results, instead of only $& Note that this it better to test it in advanced search, because the behavior of "au:" CCL index in simple search is maybe bugged (it searches the phrase index, while it should probably searches the word index) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9352 mathieu saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9352 --- Comment #50 from mathieu saby <mathsabypro@gmail.com> --- (In reply to M. de Rooy from comment #49)

Last patch has no signoff?

Nick Clemens tested patch 2. For him it was working, except the issue raised in comment 39. So he did not sign it off, and I wrote a follow-up, which is the 3rd patch. I'm not completely sure of that, but I think the ability to index a group of subfields in the same index could be usefull for other MARC fields, and not only for UNIMARC. Mathieu -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9352 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20677|0 |1 is obsolete| | --- Comment #52 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 31385 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31385&action=edit [SIGNED OFF] Bug 9352 : More specific indexing of UNIMARC 7XX fields (GRS1) 1st patch : for GRS1 indexing Problem : Zebra indexes all subfields of UNIMARC 7XX fields in author index, including $9, $3, $4 (function code), $f (dates of authors), $c (additions other than dates), $p (address). It causes Koha to give too much results. For example, if an author is born in 1984 and is a teacher, searching "1984" or "teacher" in simple search will return all work by this author if these pieces of informations are in 7XX field. This is not how most ILS work, and it should be corrected. Solution : This patch makes indexing of unimarc 7XX fields more specific. For each field, useless subfields are not indexed. 70X : Do not index $f (dates),$c (additions other than dates),$p (affiliation/address),$3,$4. Index $9 only in Koha-Auth-Number. 710-712 : Do not index $p (affiliation/address),$3,$4. Index $9 only in Koha-Auth-Number. (I kept all other subfields : even if some may be useless I am not sure of it) 716 : Do not index $f (dates),$c (additions other than dates),$3,$4. Index $9 only in Koha-Auth-Number. 72X : Do not index $f (dates),$3,$4. Index $9 only in Koha-Auth-Number. 730 : Do not index $4. Index $9 only in Koha-Auth-Number. Additionnaly, this patch indexes 205$f/$g in Author index (author of the edition of the work) Testing : a/ Create a record with : 700$a Doe $b John $f1950 $cteacher $4070 710$a Corporate $b Meeting $p Address 716$a Trademark $f1960 $cgreat $4340 720$a Family $f1980 $4651 205$a 1st edition $fBy some guy $gAnd other guys b/ Before applying patch, make several searches : Search in author index : "teacher", "great", "Address", "1950", "1960", "070", "340", "651" => you will see the record among the results Search in author index : "Doe", "John Doe", "Trademark", "Family","corporate", "meeting" => you will see the record among the results Search in author index : "guy", "guys" => you will see the record among the results with simple search (because 205 is indexed in title) => you will not see the record among the results with author search c/ Apply patch d/ Rebuild Zebra with ./misc/migration_tools/rebuild_zebra.pl -b -x -v -reset e/ Try the same searches as before : Search in author index : "teacher", "great", "Address", "1950", "1960", "070", "340", "651" => you will not see the record among the results Search in author index : "Doe", "John Doe", "Trademark", "Family","corporate", "meeting" => you will see the record among the results Search in author index : "guy", "guys" => you will see the record among the results in both simple search and author search Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described with GRS1. No koha-qa errors. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9352 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31380|0 |1 is obsolete| | --- Comment #54 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 31387 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31387&action=edit [SIGNED OFF] Bug 9352: Add a new XSLT template for indexing goup of subfields as a whole This patch adds a new template in koha-indexdefs-to-zebra.xsl in order to index a specific goup of subfields as a whole. It can be used for indexing as a "phrase" a string resulting from the concatenation of some indexes (with a space between them) To use this new template, use the new "index_group_of_subfields" element in biblio-koha-indexdefs.xml, in the same way you used index_subfields Ex : to index the concatenation of "$a $b $d $g" subfields of 700 UNIMARC field in Author:p <index_group_of_subfields xmlns="http://www.koha-community.org/schemas/index-defs" tag="700" subfields="abdg"> <target_index>Author:p</target_index> </index_group_of_subfields> This patch also change the biblio-koha-indexdefs.xml and biblio-zebra-indexdefs.xsl for UNIMARC, in order to use this new template for 700-712 fields For 700 and 710, it also indexes in "Author:s" (used for sorting) the concatenation of subfields instead of only the $a subfield To test : in a DOM UNIMARC Koha, apply all the patches, copy the modified files in your Zebra configuration directory, rebuild zebra, and make some tests Everything should be the same as when only the first 2 patches were applied, EXCEPT this behavior: - create a record with 700$aDoe$bJohn (and nothing in 200$f or $g) - Go in Advanced Search, and select the "Author as phrase" index - with only the first 2 patches, you will have 0 result if you enter "Doe John" or "Doe John" - with the 3 patches, you will have 1 result if you enter "Doe John" or "Doe John" - same kind of test for 710 field - the logic is the same for 701, 702,711, 712. So, no need to test - make some searches and test the sorting of your results by author name ("Author A-Z" and "Author Z-A"). The complete name of main author (700 and 710) sould be used for sorting the results, instead of only $& Note that this it better to test it in advanced search, because the behavior of "au:" CCL index in simple search is maybe bugged (it searches the phrase index, while it should probably searches the word index) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9352 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |m.de.rooy@rijksmuseum.nl --- Comment #56 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- I would like to QA this one soon. Put it on my list now. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9352 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31385|0 |1 is obsolete| | Attachment #31386|0 |1 is obsolete| | Attachment #31387|0 |1 is obsolete| | --- Comment #57 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 32097 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32097&action=edit Bug 9352 : More specific indexing of UNIMARC 7XX fields (GRS1) 1st patch : for GRS1 indexing Problem : Zebra indexes all subfields of UNIMARC 7XX fields in author index, including $9, $3, $4 (function code), $f (dates of authors), $c (additions other than dates), $p (address). It causes Koha to give too much results. For example, if an author is born in 1984 and is a teacher, searching "1984" or "teacher" in simple search will return all work by this author if these pieces of informations are in 7XX field. This is not how most ILS work, and it should be corrected. Solution : This patch makes indexing of unimarc 7XX fields more specific. For each field, useless subfields are not indexed. 70X : Do not index $f (dates),$c (additions other than dates),$p (affiliation/address),$3,$4. Index $9 only in Koha-Auth-Number. 710-712 : Do not index $p (affiliation/address),$3,$4. Index $9 only in Koha-Auth-Number. (I kept all other subfields : even if some may be useless I am not sure of it) 716 : Do not index $f (dates),$c (additions other than dates),$3,$4. Index $9 only in Koha-Auth-Number. 72X : Do not index $f (dates),$3,$4. Index $9 only in Koha-Auth-Number. 730 : Do not index $4. Index $9 only in Koha-Auth-Number. Additionnaly, this patch indexes 205$f/$g in Author index (author of the edition of the work) Testing : a/ Create a record with : 700$a Doe $b John $f1950 $cteacher $4070 710$a Corporate $b Meeting $p Address 716$a Trademark $f1960 $cgreat $4340 720$a Family $f1980 $4651 205$a 1st edition $fBy some guy $gAnd other guys b/ Before applying patch, make several searches : Search in author index : "teacher", "great", "Address", "1950", "1960", "070", "340", "651" => you will see the record among the results Search in author index : "Doe", "John Doe", "Trademark", "Family","corporate", "meeting" => you will see the record among the results Search in author index : "guy", "guys" => you will see the record among the results with simple search (because 205 is indexed in title) => you will not see the record among the results with author search c/ Apply patch d/ Rebuild Zebra with ./misc/migration_tools/rebuild_zebra.pl -b -x -v -reset e/ Try the same searches as before : Search in author index : "teacher", "great", "Address", "1950", "1960", "070", "340", "651" => you will not see the record among the results Search in author index : "Doe", "John Doe", "Trademark", "Family","corporate", "meeting" => you will see the record among the results Search in author index : "guy", "guys" => you will see the record among the results in both simple search and author search Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described with GRS1. No koha-qa errors. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9352 --- Comment #59 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 32099 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32099&action=edit Bug 9352: Add a new XSLT template for indexing goup of subfields as a whole This patch adds a new template in koha-indexdefs-to-zebra.xsl in order to index a specific goup of subfields as a whole. It can be used for indexing as a "phrase" a string resulting from the concatenation of some indexes (with a space between them) To use this new template, use the new "index_group_of_subfields" element in biblio-koha-indexdefs.xml, in the same way you used index_subfields Ex : to index the concatenation of "$a $b $d $g" subfields of 700 UNIMARC field in Author:p <index_group_of_subfields xmlns="http://www.koha-community.org/schemas/index-defs" tag="700" subfields="abdg"> <target_index>Author:p</target_index> </index_group_of_subfields> This patch also change the biblio-koha-indexdefs.xml and biblio-zebra-indexdefs.xsl for UNIMARC, in order to use this new template for 700-712 fields For 700 and 710, it also indexes in "Author:s" (used for sorting) the concatenation of subfields instead of only the $a subfield To test : in a DOM UNIMARC Koha, apply all the patches, copy the modified files in your Zebra configuration directory, rebuild zebra, and make some tests Everything should be the same as when only the first 2 patches were applied, EXCEPT this behavior: - create a record with 700$aDoe$bJohn (and nothing in 200$f or $g) - Go in Advanced Search, and select the "Author as phrase" index - with only the first 2 patches, you will have 0 result if you enter "Doe John" or "Doe John" - with the 3 patches, you will have 1 result if you enter "Doe John" or "Doe John" - same kind of test for 710 field - the logic is the same for 701, 702,711, 712. So, no need to test - make some searches and test the sorting of your results by author name ("Author A-Z" and "Author Z-A"). The complete name of main author (700 and 710) sould be used for sorting the results, instead of only $& Note that this it better to test it in advanced search, because the behavior of "au:" CCL index in simple search is maybe bugged (it searches the phrase index, while it should probably searches the word index) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9352 --- Comment #61 from mathieu saby <mathsabypro@gmail.com> --- (In reply to Tomás Cohen Arazi from comment #60)

I like to improve UNIMARC support, so will be available to hangout and/or comment on whatever you need. But

- GRS-1 is now deprecated (no problem with that, just obsolete that patch) - The rest of the patches don't apply - It seems you are re-implementing on koha-indexdefs-to-zebra.xsl something already existed, i might be wrong, but look at 'handle-index-subfields'

I will rebase it later. But for your 3rd point : the idea is to create a new behavior : indexing as a single phrase, in a single index, a string resulting from the concatenation of some subfieds. I don't think you can do that with 'handle-index-subfields'. Mathieu -- You are receiving this mail because: You are watching all bug changes.