[Bug 7376] New: Transfer limits should be checked at check out And when checkin should be overridable.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Bug #: 7376 Summary: Transfer limits should be checked at check out And when checkin should be overridable. Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_8 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation AssignedTo: kyle.m.hall@gmail.com ReportedBy: henridamien.laurent@biblibre.com QAContact: ian.walls@bywatersolutions.com CC: gmcharlt@gmail.com Test : When CirculationBranch is set to PatronLibrary, Patron from branch B comes to branch A to checkout a book. The librarian should be warned that the book should not be checkout. When checking in, the librarian should be warned that the book should not be checked in before the return is done. And the page should allow the librarian to override the warning. And accept the book. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 laurenthdl <henridamien.laurent@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored --- Comment #1 from laurenthdl <henridamien.laurent@biblibre.com> 2011-12-26 15:52:20 UTC --- sponsored by Lyon3 University. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high Status|NEW |ASSIGNED CC| |paul.poulain@biblibre.com Version|rel_3_8 |rel_3_6 AssignedTo|kyle.m.hall@gmail.com |paul.poulain@biblibre.com Summary|Transfer limits should be |Transfer limits should be |checked at check out And |checked at check-in |when checkin should be | |overridable. | Severity|enhancement |critical --- Comment #2 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-29 14:48:27 UTC --- Upgrading severity, it's not an ENH, it's a bug, and a major one if you've activated branchtransfer ! Test case: * UseBranchTransferLimits must be set * define your branch transfer limit. Refuse transfers from libraryA to libraryB * checkout a book owned by libraryB, from libraryB, with a librarian located at libraryB * move the librarian to libraryA ("Set Library" link top/right) * check-in the book => it's possible whatever your setup After the patch, the behaviour respect the branch transfer limit parameter: you can check-in if you accept transfers, you can't if you refuse them. (Note: IndependantBranches must be OFF, otherwise it's not possible to do the checkin whatever the branch transfer limits) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-29 14:56:56 UTC --- Created attachment 6954 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6954 Bug 7376 Transfer limits should be checked at check-in Test case: * UseBranchTransferLimits must be set * define your branch transfer limit. Refuse transfers from libraryA to libraryB * checkout a book owned by libraryB, from libraryB, with a librarian located at libraryB * move the librarian to libraryA ("Set Library" link top/right) * check-in the book => it's possible whatever your setup After the patch, the behaviour respect the branch transfer limit parameter: you can check-in if you accept transfers, you can't if you refuse them. (Note: IndependantBranches must be OFF, otherwise it's not possible to do the checkin whatever the branch transfer limits) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P1 - high |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-29 15:29:28 UTC --- (BibLibre MT8601) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P5 - low Status|Needs Signoff |Failed QA Version|rel_3_6 |master --- Comment #5 from Owen Leonard <oleonard@myacpl.org> 2012-02-07 16:52:03 UTC --- I don't think this is working, but maybe I misunderstand the conditions required for testing. I have: CircControl set to "The library the patron is from" (PatronLibrary) UseBranchTransferLimits set to "Enforce" (1) (and BranchTransferLimitsType set to "item type") In library transfer limits I have deselected ALL checkboxes under Library A and Library B. I checked out a book from Library B to a patron from Library B at Library B. Then I switched to Library A and checked the book in. I got no warning about a blocked transfer. It simply checked in the item and initiated an automatic transfer. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> 2012-02-07 16:54:54 UTC --- By the way, I tested this patch on top of the patches for Bug 6842 since otherwise I couldn't change library transfer limits. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-13 15:32:42 UTC --- I just made a test again on my testing database, and I get, as expected, the result: Cannot Check In This item must be checked in at its home library. NOT CHECKED IN Here is my setup: * IndependantBranches = OFF (I also tested with IndependantBranches=ON, same behaviour, as expected) * UseBranchTransferLimits & BranchTransferLimitsType = Enforce branch transfer limits based on Itemtype * in admin/branch_transfer_limit.pl = everything is unselected, in all branches * memcache is OFF, that's important, otherwise, when testing you can see bad results just because you get the cached version of the data, not the uptodate) * HomeOrHoldingBranchReturn On checkin route the returned item to the library the item was checked out from (should not matter, but just in case) * item-level_itypes is set to biblio record (that may be important) Could you add warn "==> branchtransferlimitvalue"; just BEFORE the line if (($hbr ne $branch && C4::Context->preference("IndependantBranches")) or (!IsBranchTransferAllowed($hbr, $branch, $branchtransferlimitvalue ))) { It will show which flag is used for checking the branchtransfer -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 delaye <stephane.delaye@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stephane.delaye@biblibre.co | |m --- Comment #8 from delaye <stephane.delaye@biblibre.com> --- After apply the patch i test the steps Test case: * UseBranchTransferLimits must be set * define your branch transfer limit. Refuse transfers from libraryA to libraryB * checkout a book owned by libraryB, from libraryB, with a librarian located at libraryB * move the librarian to libraryA ("Set Library" link top/right) * check-in the book => it's possible whatever your setup ==> ok BUt I can save a tranfert B ->A and save a use with the item B in branch A... it'sl normal.. I don't understand -- You are receiving this mail because: You are watching all bug changes.
From OPAC a borrower located A want to book a title. The title have 3 items in use with branches A, B, and D. Koha display all the branches A, B, C and D for pickup instead of proposing the branches A, B and C. So when returning an item (A, B or C) there is a risk that
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 --- Comment #9 from delaye <stephane.delaye@biblibre.com> --- Disregard my previous comment, I forgot to prohibit transfers from B to A. sorry so it's ok But... But the rules (limit) of tranfers is not interpreted with the requests for holds to the OPAC and intranet and more specialy with the system preference OPACAllowUserToChooseBranch(=ON) If OPACAllowUserToChooseBranch activated the transfers limits are not read. The system preference displays all sites (= select * from branches) instead of displaying only those sites that allow transfers. Example: A network of four sites: A, B, C and D The adherents of A, B and C can reserve copies of A, B and C. Items with branches A, B and C can transit in sub-network A, B and C. The items with branch D can not be reserved and site D does not accept the items with branches A, B and C. The holds rules are the following : Branch A -> All sites Branch B -> All sites Branch C -> All sites Branch D -> No holds Rules of transfers branch A -> A, B, C branch B -> A, B, C branch C -> A, B, C branch D -> D OPACAllowUserToChooseBranch is activated the pickuplocation will be D if the borrower have been chose D. While D don't want manage holds within the network. Paul I have an example of sandbox1 http://catalogue.test1.biblibre.com/cgi-bin/koha/opac-reserve.pl?biblionumbe... (user: password and mozart: mozart) it's important for few customers. See also ticket 7534 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |koha@univ-lyon3.fr --- Comment #10 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- I follow Test Plan : Ok for check in / Check Out. I think we should have some Transfert Limit for Holds. For example, at Lyon 3, tranferts are authorised when check-in to transfer the document to his home Library but we don't want to document to be transfered for chek-out when placed in hold. For example : 1. a borrower from libraryB place hold on a document from libraryA. 2. the document is check-in in his homelibribrary (A) 3. The document is automaticly set in transfer to library B :we don't want to transfer this document, we want that borrowers come in library A to check out the document hold. Sign OFF for transfer Limit check-in. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #11 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Some QA comments: Your call to GetBiblioFromItemNumber could have a barcode too. Just mentioning. Furthermore, it seems that you only need itemtype from biblioitems (twice used in routine). Getting a hashref for all fields from biblio, biblioitems and items is relative expensive for that purpose ;) No blocker. You are checking branch transfer limits without consulting UseBranchTransferLimits ? It could just be off? Suppose that you had some limits, but disabled the option later. In that case the check could be incorrect. Note that it is hypothetical. Also you would not need to call IsBranchTransferAllowed if $hbr eq $branch. (Although it should not hurt.) Just a note on variable name: name $branchtransferlimitvalue is somewhat confusing. No blocker. In conclusion: patch slightly fails QA now. If you still want to push it however, please send a followup for remark 2. The other points could be resolved as well, but are of minor importance. Note also the earlier comments of several testers. Parking this on Failed QA for further attention. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #12 from Nicole C. Engard <nengard@gmail.com> --- It's been a while on this, but can we get an updated patch? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti@jns.fi --- Comment #13 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Yeah, I am curious about this bug as well. Tho we would like to extend this to cover placing holds as well. Well I already wrote the code for that as a proof of concept for our librarians. I there some way I can contribute to this bug? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|paul.poulain@biblibre.com |jonathan.druart@biblibre.co | |m --- Comment #14 from Paul Poulain <paul.poulain@biblibre.com> --- Jonathan, if you can have a look to this patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6954|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 21715 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21715&action=edit Bug 7376 Transfer limits should be checked at check-in Test case: * UseBranchTransferLimits must be set * define your branch transfer limit. Refuse transfers from libraryA to libraryB * checkout a book owned by libraryB, from libraryB, with a librarian located at libraryB * move the librarian to libraryA ("Set Library" link top/right) * check-in the book => it's possible whatever your setup After the patch, the behaviour respect the branch transfer limit parameter: you can check-in if you accept transfers, you can't if you refuse them. (Note: IndependantBranches must be OFF, otherwise it's not possible to do the checkin whatever the branch transfer limits) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> --- Rebased patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|koha.sekjal@gmail.com | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot@bugs.koha-community. | |org When did the bot| |2013-10-03 last check this| | --- Comment #17 from I'm just a bot <gitbot@bugs.koha-community.org> --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 --- Comment #18 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- I think we should make a single function &CheckBranchTransferLimits($item, $biblio, $destinationBranch, $sourceBranch) # either $item or $biblio should be given, preferably both due to # C4::Context->preference("item-level_itypes") Otherwise we get crazy code duplication since the check for BranchTransferLimits is really messy in the calling method. Also this check is performed during circ/branchtransfers.pl and it definetely should be checked when placing reservations/holds as well. Also some Restful API's we have, place holds and they should be UseBranchTransferLimits-capable. Placing holds is beyond the scope of this bug, but now that a patch has been applied I'd prefer to have a central way of checking the UseBranchTransferLimit instead of replicating this code everywhere. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 --- Comment #19 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Created attachment 21805 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21805&action=edit When failing UseBranchTransferLimits-check, don't display the "Thanks for returning this book"-message. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 --- Comment #20 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Test case parameters: ----------------------------- * UseBranchTransferLimits must be set * define your branch transfer limit. IPT -> CPL -> FFL -> IPT Test case 1, transfer is not allowed: ----------------------------- * move the librarian to IPT ("Set Library" link top/right) * check-out an item, with homebranch IPT * move the librarian to CPL ("Set Library" link top/right) * FAIL check-in the item => Book check-in fails, but the template is incorrect (Attachment: When failing UseBranchTransferLimits-check, don't display the "Thanks for returning this book"-message.) OK (check-in fails): Item's checkout status still "Checked out to Olli-Antti2 Kivilahti2, Due back on 11/01/2013" Test case 2, transfer is allowed: --------------------------------- * move the librarian to IPT ("Set Library" link top/right) * check-out an item, with homebranch IPT * move the librarian to FFL ("Set Library" link top/right) * OK check-in succeeds and printing a transfer slip is proposed. Item's checkout status: undef Test conclusion: -------------------------------- Covered: Item checkout status changes (Checked out, undef) Transfer limits (Allow transfer?, true, false) Template in circ/returns.pl Test fails the template check, otherwise OK. Note: --------------------------------- Should test for SIP2 as well, but probably it works ok, since AddReturn returns false when BranchTransferLimits check fails. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 --- Comment #21 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Olli-Antti Kivilahti from comment #19)
Created attachment 21805 [details] When failing UseBranchTransferLimits-check, don't display the "Thanks for returning this book"-message.
I don't get this message. Are you sure you applied this patch on the master branch? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 --- Comment #22 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- The strange message I got was due to the checkin message attached to my itemtype. Not sure if the checkin message should be disabled if checkin fails? Propably it should. circ/returns.pl::>> # Check if we should display a checkin message, based on the the item # type of the checked in item my $itemtype = C4::ItemType->get( $biblio->{'itemtype'} ); if ( $itemtype->{'checkinmsg'} ) { ...print checking message...; } Still: The item which failed to checkin is still added to the list of checked in material at the end of the page. laurendthl has requested the ability for a librarian to override the transfer limit. This is probably pretty useful in ILL-cases. And they are the bug sponsor as well :) SYNOPSIS: -OPTIONAL: Disable checkin message -OPTIONAL: Do not add the failed checkin to the "Checked-in items"-table -Make it possible for a librarian to override the branchtransferlimit (no special permissions requested in the RFP) --Log this override event to catch misbehaving librarians. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11005 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11020 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11024 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Koha Team AMU <koha.aixmarseille@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |koha.aixmarseille@gmail.com --- Comment #23 from Koha Team AMU <koha.aixmarseille@gmail.com> --- I follow the Test Plan, it's Ok. But the librarian can't override, it should be better. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|11005, 11020, 11024 | Depends on| |11005 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart@biblibre.co |olli-antti.kivilahti@jns.fi |m | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 --- Comment #24 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Agreed to fix this bug for Joubu, in exchange for QA stuff. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 --- Comment #25 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- sponsored by Joensuu Regional Library -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11020 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 --- Comment #26 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Created attachment 22016 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22016&action=edit Bug 7376 - Transfer limits should be checked at check-in Extended UseBranchTransferLimits-check to the check-in case. Made it possible to override the check-in with circulation-permission if BranchTransfer is denied. Made unit tests for the C4/Circulation.pm and C4/SIP/t/08checkin.t *Also added override-functionality to Circulation::AddReturn() to override BranchTransferLimits. (+unit tests) *Renamed CanBookBeReturned to CanItemBeReturned since that function was referenced from AddReturn only. --This is because function name misguidingly references to a book/Biblio/Title-level, even if the functionality is strictly --Item dependent. *Removed duplicating code by making CheckBranchTransferAllowed() call IsBranchTransferAllowed(). *Made a unit test library out of CheckBranchTransferAllowed.t's environment initialization parts, so these need not be duplicated whenever UseBranchTransferLimits-related functionality is tested. *Documented SIP-testing hardships to C4/SIP/README -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21715|0 |1 is obsolete| | Attachment #21805|0 |1 is obsolete| | --- Comment #27 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Created attachment 22017 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22017&action=edit Manual test cases -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 --- Comment #28 from Paul Poulain <paul.poulain@biblibre.com> --- mmm... this patch has been set to "failed QA" by Aix-Marseille university, and a new patch has been attached. Shouldn't the status be reset to "need signoff" ? Otherwise, explanation welcomed ! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22016|0 |1 is obsolete| | --- Comment #29 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Created attachment 22323 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22323&action=edit Bug 7376 - Transfer limits should be checked at check-in Extended UseBranchTransferLimits-check to the check-in case. Made it possible to override the check-in with circulation-permission if BranchTransfer is denied. Made unit tests for the C4/Circulation.pm and C4/SIP/t/08checkin.t *Also added override-functionality to Circulation::AddReturn() to override BranchTransferLimits. (+unit tests) *Renamed CanBookBeReturned to CanItemBeReturned since that function was referenced from AddReturn only. --This is because function name misguidingly references to a book/Biblio/Title-level, even if the functionality is strictly --Item dependent. *Removed duplicating code by making CanItemBeTransferred() call IsBranchTransferAllowed(). *Made a unit test library out of CanItemBeTransferred.t's environment initialization parts, so these need not be duplicated whenever UseBranchTransferLimits-related functionality is tested. *Documented SIP-testing hardships to C4/SIP/README -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #30 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- "mmm... this patch has been set to "failed QA" by Aix-Marseille university, and a new patch has been attached. Shouldn't the status be reset to "need signoff" ? Otherwise, explanation welcomed !" -PP It should. I noticed this as well but I decided to leave it as is, since someone had already signed this bug off. I knew it wasn't exactly a nice thing and was kinda hoping to skip the sign-off part. Obviously my behaviour was not very nice. Apologies for the misconduct. Changed tabs to spaces. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22323|0 |1 is obsolete| | --- Comment #31 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Created attachment 22357 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22357&action=edit Bug 7376 - Transfer limits should be checked at check-in Extended UseBranchTransferLimits-check to the check-in case. Made it possible to override the check-in with circulation-permission if BranchTransfer is denied. Made unit tests for the C4/Circulation.pm and C4/SIP/t/08checkin.t *Also added override-functionality to Circulation::AddReturn() to override BranchTransferLimits. (+unit tests) *Renamed CanBookBeReturned to CanItemBeReturned since that function was referenced from AddReturn only. --This is because function name misguidingly references to a book/Biblio/Title-level, even if the functionality is strictly --Item dependent. *Removed duplicating code by making CanItemBeTransferred() call IsBranchTransferAllowed(). *Made a unit test library out of CanItemBeTransferred.t's environment initialization parts, so these need not be duplicated whenever UseBranchTransferLimits-related functionality is tested. *Documented SIP-testing hardships to C4/SIP/README -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 --- Comment #32 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to Olli-Antti Kivilahti from comment #30)
"mmm... this patch has been set to "failed QA" by Aix-Marseille university, and a new patch has been attached. Shouldn't the status be reset to "need signoff" ? Otherwise, explanation welcomed !" -PP
It should. I noticed this as well but I decided to leave it as is, since someone had already signed this bug off. I knew it wasn't exactly a nice thing and was kinda hoping to skip the sign-off part. Obviously my behaviour was not very nice. Apologies for the misconduct. I didn't spot any misconduct, but as long as a patch is "failed QA" no one takes care of it, except the patch author. So if you submit a new patch, then you need to change the status.
When a failed QA is caused by a small/minor QA problem, like an indent one, then, it's OK to switch back to "signed off" if the patch has already been signed off. Otherwise, back to "need signoff". But not let "failed QA" status as it is. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|11005 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|11020 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11024 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22357|0 |1 is obsolete| | --- Comment #33 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Created attachment 22696 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22696&action=edit Bug 7376 - Transfer limits should be checked at check-in Extended UseBranchTransferLimits-check to the check-in case. Made it possible to override the check-in with circulation-permission if BranchTransfer is denied. Made unit tests for the C4/Circulation.pm and C4/SIP/t/08checkin.t *Also added override-functionality to Circulation::AddReturn() to override BranchTransferLimits. (+unit tests) *Renamed CanBookBeReturned to CanItemBeReturned since that function was referenced from AddReturn only. --This is because function name misguidingly references to a book/Biblio/Title-level, even if the functionality is strictly --Item dependent. *Removed duplicating code by making CanItemBeTransferred() call IsBranchTransferAllowed(). *Made a unit test library out of CanItemBeTransferred.t's environment initialization parts, so these need not be duplicated whenever UseBranchTransferLimits-related functionality is tested. *Documented SIP-testing hardships to C4/SIP/README -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22696|0 |1 is obsolete| | --- Comment #34 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Created attachment 23168 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23168&action=edit Bug 7376 - Transfer limits should be checked at check-in Extended UseBranchTransferLimits-check to the check-in case. Made it possible to override the check-in with circulation-permission if BranchTransfer is denied. Made unit tests for the C4/Circulation.pm and C4/SIP/t/08checkin.t *Also added override-functionality to Circulation::AddReturn() to override BranchTransferLimits. (+unit tests) *Renamed CanBookBeReturned to CanItemBeReturned since that function was referenced from AddReturn only. --This is because function name misguidingly references to a book/Biblio/Title-level, even if the functionality is strictly --Item dependent. *Removed duplicating code by making CanItemBeTransferred() call IsBranchTransferAllowed(). *Made a unit test library out of CanItemBeTransferred.t's environment initialization parts, so these need not be duplicated whenever UseBranchTransferLimits-related functionality is tested. *Documented SIP-testing hardships to C4/SIP/README -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |cbrannon@cdalibrary.org --- Comment #35 from Christopher Brannon <cbrannon@cdalibrary.org> --- I cannot sign off on this patch. The following error comes up when I try to apply it to a sandbox: The sandbox you've requested is not ready. Some problems occurred applying patches from bug 7376: <h1>Something went wrong !</h1>Applying: Bug 7376 - Transfer limits should be checked at check-in fatal: sha1 information is lacking or useless (C4/Circulation.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 7376 - Transfer limits should be checked at check-in When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 7376 - Transfer limits should be checked at check-in 23168 - Bug 7376 - Transfer limits should be checked at check-in Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/Bug-7376---Transfer-limits-should-be-checked-at-ch-u0UdEh.patch . Christopher -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl@biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9809 CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #36 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Be care, AddReserve prototype changed by bug 9809 (contrainst param removed). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #37 from Marc Véron <veron@veron.ch> --- Still a critical bug? - It was reported 2011-12-22. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 --- Comment #38 from Marc Véron <veron@veron.ch> --- Does not apply. Is this bug still valid? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|cbrannon@cdalibrary.org | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org