[Bug 38055] New: Space between label and value for MARC field 530
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38055 Bug ID: 38055 Summary: Space between label and value for MARC field 530 Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: ephetteplace@cca.edu QA Contact: testopia@bugs.koha-community.org Created attachment 172290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172290&action=edit screenshot of bug The MARC21 XSLT templates typically have a space between their label and the MARC field's value but today I noticed that the label for 530 "Available additional physical forms" does not have a trailing space (see screenshot). To test: - Find a record with a 530 field or add a 530 to an existing record - View record in OPAC — note no space between label and value - Apply patch - View record in OPAC — space is present -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38055 --- Comment #1 from Eric Phetteplace <ephetteplace@cca.edu> --- Created attachment 172291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172291&action=edit Bug 38055: Space between label and value for MARC field 530 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38055 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38055 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38055 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |ephetteplace@cca.edu CC| |phil@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38055 Esther Melander <esther.melander@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |esther.melander@bywatersolu | |tions.com --- Comment #2 from Esther Melander <esther.melander@bywatersolutions.com> --- Created attachment 172701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172701&action=edit No space after the label. I tested this and there does not appear to be a space after the label. Result image attached. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38055 --- Comment #3 from Eric Phetteplace <ephetteplace@cca.edu> --- (In reply to Esther Melander from comment #2)
Created attachment 172701 [details] No space after the label.
I tested this and there does not appear to be a space after the label. Result image attached.
Esther—did you restart Plack in between applying the patch and testing? That's `koha-plack --restart` (at least it is in a ktd shell). Sorry, that is my mistake, I should have it in the testing plan. If you did restart Plack, then I'll have to revisit this, since when I test locally I see the space. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38055 --- Comment #4 from Esther Melander <esther.melander@bywatersolutions.com> --- Yes, I tested in a sandbox and restarted services, which restarted Plack. There is no space between the label and the text in the OPAC. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38055 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38055 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172291|0 |1 is obsolete| | --- Comment #5 from Eric Phetteplace <ephetteplace@cca.edu> --- Created attachment 172995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172995&action=edit Bug 38055: Space between label and value for MARC field 530 To test: - Find a record with a 530 field or add a 530 to an existing record - View record in OPAC — note no space between label and value - Apply patch - Restart Plack - View record in OPAC — space is present -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38055 --- Comment #6 from Eric Phetteplace <ephetteplace@cca.edu> --- (In reply to Esther Melander from comment #4)
Yes, I tested in a sandbox and restarted services, which restarted Plack. There is no space between the label and the text in the OPAC.
Hi Esther, could you try again? I think perhaps my patch wasn't formatted correctly. I remade the patch with `git bz` and now when I test using the ByWater sandboxes I see a space after the colon. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38055 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38055 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172995|0 |1 is obsolete| | --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 172996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172996&action=edit Bug 38055: Space between label and value for MARC field 530 To test: - Find a record with a 530 field or add a 530 to an existing record - View record in OPAC — note no space between label and value - Apply patch - Restart Plack - View record in OPAC — space is present Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38055 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38055 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172996|0 |1 is obsolete| | --- Comment #8 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 173390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173390&action=edit Bug 38055: Space between label and value for MARC field 530 To test: - Find a record with a 530 field or add a 530 to an existing record - View record in OPAC — note no space between label and value - Apply patch - Restart Plack - View record in OPAC — space is present Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38055 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38055 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38055 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38055 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38055 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38055 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org