[Bug 32530] New: When duplicating child card, guarantor is not saved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32530 Bug ID: 32530 Summary: When duplicating child card, guarantor is not saved Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: bdaeuber@cityoffargo.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When duplicating a child card with a guarantor, the guarantor information appears during the card creation process, but disappears as soon as saving the card. To recreate: 1. Find a card with a guarantor, either patron or non-patron guarantor. 2. Duplicate the card. Note that it appears to be working on the card creation screen. 3. Save the patron after completing the form. The guarantor is now gone. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32530 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Still valid in master (22.12.00.048) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32530 Michael Spagnuolo <mspagnuolo@nrhtx.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspagnuolo@nrhtx.com --- Comment #2 from Michael Spagnuolo <mspagnuolo@nrhtx.com> --- Our library staff have noticed this bug, and it is causing extra steps during family card creation. We would like to see it fixed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32530 Cheryl <clackman@fargolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clackman@fargolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32530 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emmi.takkinen@koha-suomi.fi --- Comment #3 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- *** Bug 34763 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32530 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32530 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #4 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Hi, I do not reproduce on main (v24.05.01), is it still valid ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32530 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |baptiste.wojtkowski@biblibr |ity.org |e.com Status|NEW |ASSIGNED --- Comment #5 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- I finally reproduce on main, looking forward to fix it -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32530 --- Comment #6 from Benjamin Daeuber <bdaeuber@cityoffargo.com> --- It is still occurring on main (23.06). It does appear to work until you save the duplicated card, at which point the guarantor is not attached. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32530 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32530 --- Comment #7 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 168833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168833&action=edit Bug 32530: When duplicating child card, guarantor is not saved When duplicating a child card with a guarantor, the guarantor information appears during the card creation process, but disappears as soon as saving the card. To recreate: 1. Find a card with a guarantor, either patron or non-patron guarantor. 2. Duplicate the card. Note that it appears to be working on the card creation screen. 3. Save the patron after completing the form. The guarantor is now gone. New test plan: 1. Find a card with a guarantor, either patron or non-patron guarantor. 2. Duplicate the card. Note that it appears to be working on the card creation screen. 3. Save the patron after completing the form. The guarantor is now gone. Apply patch and repeat, the guarantor should stay after 3. Note, I may not have understood the code but it looks like nothing is searching for the content of the displayed information. Therefore I add hidden fields that are copies of those provided in guarantor_template class -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32530 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168833|0 |1 is obsolete| | --- Comment #8 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 168834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168834&action=edit Bug 32530: When duplicating child card, guarantor is not saved When duplicating a child card with a guarantor, the guarantor information appears during the card creation process, but disappears as soon as saving the card. To recreate: 1. Find a card with a guarantor, either patron or non-patron guarantor. 2. Duplicate the card. Note that it appears to be working on the card creation screen. 3. Save the patron after completing the form. The guarantor is now gone. New test plan: 1. Find a card with a guarantor, either patron or non-patron guarantor. 2. Duplicate the card. Note that it appears to be working on the card creation screen. 3. Save the patron after completing the form. The guarantor is now gone. Apply patch and repeat, the guarantor should stay after 3. Note, I may not have understood the code but it looks like nothing is searching for the content of the displayed information. Therefore I add hidden fields that are copies of those provided in guarantor_template class -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32530 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168834|0 |1 is obsolete| | --- Comment #9 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 168873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168873&action=edit Bug 32530: When duplicating child card, guarantor is not saved When duplicating a child card with a guarantor, the guarantor information appears during the card creation process, but disappears as soon as saving the card. To recreate: 1. Find a card with a guarantor, either patron or non-patron guarantor. 2. Duplicate the card. Note that it appears to be working on the card creation screen. 3. Save the patron after completing the form. The guarantor is now gone. New test plan: 1. Find a card with a guarantor, either patron or non-patron guarantor. 2. Duplicate the card. Note that it appears to be working on the card creation screen. 3. Save the patron after completing the form. The guarantor is now gone. Apply patch and repeat, the guarantor should stay after 3. Note, I may not have understood the code but it looks like nothing is searching for the content of the displayed information. Therefore I add hidden fields that are copies of those provided in guarantor_template class Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32530 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32530 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32530 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168873|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 169101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169101&action=edit Bug 32530: When duplicating child card, guarantor is not saved When duplicating a child card with a guarantor, the guarantor information appears during the card creation process, but disappears as soon as saving the card. To recreate: 1. Find a card with a guarantor, either patron or non-patron guarantor. 2. Duplicate the card. Note that it appears to be working on the card creation screen. 3. Save the patron after completing the form. The guarantor is now gone. New test plan: 1. Find a card with a guarantor, either patron or non-patron guarantor. 2. Duplicate the card. Note that it appears to be working on the card creation screen. 3. Save the patron after completing the form. The guarantor is now gone. Apply patch and repeat, the guarantor should stay after 3. Note, I may not have understood the code but it looks like nothing is searching for the content of the displayed information. Therefore I add hidden fields that are copies of those provided in guarantor_template class Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32530 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|21.11 |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32530 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for the fix guys, Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32530 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32530 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32530 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32530 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_05_candidate CC| |lisette@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32530 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37881 CC| |jonathan.druart@gmail.com --- Comment #13 from Jonathan Druart <jonathan.druart@gmail.com> --- This introduced a critical issue when editing patron, see bug 37881. Please fix ASAP. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37881 [Bug 37881] Guarantor code broken -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32530 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Keywords|rel_24_05_candidate | CC| |lucas@bywatersolutions.com Version(s)|24.11.00 |24.11.00,24.05.05 released in| | --- Comment #14 from Lucas Gass <lucas@bywatersolutions.com> --- BAckported to 24.05.x for upcoming 24.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32530 --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Jonathan Druart from comment #13)
This introduced a critical issue when editing patron, see bug 37881. Please fix ASAP.
Bug 37881 currently only in main so I do not backport this one. @Lucas revert this one or backport also Bug 37881 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32530 --- Comment #16 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Fridolin Somers from comment #15)
(In reply to Jonathan Druart from comment #13)
This introduced a critical issue when editing patron, see bug 37881. Please fix ASAP.
Bug 37881 currently only in main so I do not backport this one.
@Lucas revert this one or backport also Bug 37881
I am reverting this one prior to the release of 24.05.05. I will happily reconsider for 24.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00,24.05.05 |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org