[Bug 9819] New: stopwords related code should be removed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9819 Bug ID: 9819 Summary: stopwords related code should be removed Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching Assignee: gmcharlt@gmail.com Reporter: tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9819 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7440 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9819 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9819 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- When stopwords related code is removed this should include the database table stopwords. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9819 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|gmcharlt@gmail.com |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9819 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 17341 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17341&action=edit Bug 9819 - 'stopwords'-related code removed This patch removes code related to stopwords usage. The following methods are removed: C4::Search->remove_stopwords C4::Context->stopwords C4::Context->_new_stopwords And the buildQuery API was changed (removed the \@removed_stopwords return value). A follow-up is provided for database changes, to make rebasing easier. To test: - Apply this patch - Do some searches in both intranet and opac interfaces - Nothing should break Sponsored-by: Universidad Nacional de Córdoba -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9819 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 17342 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17342&action=edit Bug 9819 - Remove 'stopwords' table from kohastructure.sql Just that. To test: - Apply the patch - Do a fresh install - The database structure should be created flawlessly - There should not be a 'stopwords' table created Sponsored-by: Universidad Nacional de Córdoba -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9819 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 17343 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17343&action=edit Bug 9819 - Make updatedatabase.pl remove the 'stopwords' table To test: - Apply the patch - Will be prompted to run the updater - The 'stopwords' database should be removed ( test on a mysql prompt with > SHOW TABLES LIKE 'stopwords'; and should get no results) Sponsored-by: Universidad Nacional de Córdoba -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9819 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9819 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #5 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Hi Tomas, Could you also explain on this bug report why the stopwords should be removed? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9819 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The use of stopwords was limited to NoZebra - so this bug is a consequence of removing all NoZebra related code. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9819 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9819 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17341|0 |1 is obsolete| | Attachment #17342|0 |1 is obsolete| | Attachment #17343|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 17558 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17558&action=edit Bug 9819 - 'stopwords'-related code removed This patch removes code related to stopwords usage. The following methods are removed: C4::Search->remove_stopwords C4::Context->stopwords C4::Context->_new_stopwords And the buildQuery API was changed (removed the \@removed_stopwords return value). A follow-up is provided for database changes, to make rebasing easier. To test: - Apply this patch - Do some searches in both intranet and opac interfaces - Nothing should break Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9819 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 17559 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17559&action=edit Bug 9819 - Remove 'stopwords' table from kohastructure.sql Just that. To test: - Apply the patch - Do a fresh install - The database structure should be created flawlessly - There should not be a 'stopwords' table created Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9819 --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 17560 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17560&action=edit Bug 9819 - Make updatedatabase.pl remove the 'stopwords' table To test: - Apply the patch - Will be prompted to run the updater - The 'stopwords' database should be removed ( test on a mysql prompt with > SHOW TABLES LIKE 'stopwords'; and should get no results) Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9819 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@biblibre.co | |m Patch complexity|Small patch |Medium patch QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: Great job Tomás. All looks good. But there are 2 smalls things 1/ the structure file for PostgreSQL contains the "create table" statement for the stopwords table. I know this file is not updated, but while you're at it you could delete it. 2/ The stopwords sql file for spanish has been introduced into master before you provided your first patch. It should be deleted. Marked as Failed QA for 2. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9819 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 17587 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17587&action=edit Bug 9819 - QA Followup: Stopwords vestiges in Pg and es-ES removed Gotcha. To+ -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9819 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9819 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- Tomás, thank you for your followup! I found another issue: some unit tests in t/db_dependent/Search.t fail: # Failed test 'getRecords on _ALLRECORDS PQF returned all records' # at t/db_dependent/Search.t line 387. # got: undef # expected: '178' # Failed test 'getRecords PQF author search for Lessig returned proper number of matches' # at t/db_dependent/Search.t line 393. # got: undef # expected: '4' # Failed test 'getRecords CCL author search for Lessig returned proper number of matches' # at t/db_dependent/Search.t line 399. # got: undef # expected: '4' # Failed test 'getRecords CQL author search for Lessig returned proper number of matches' # at t/db_dependent/Search.t line 405. # got: undef # expected: '4' # Looks like you failed 4 tests of 75. They passed with success before yours patches. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9819 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to comment #12)
They passed with success before yours patches.
What data set can I use to test it in my box? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9819 --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #13)
(In reply to comment #12)
They passed with success before yours patches.
What data set can I use to test it in my box?
No idea! On master, the prove t/db_dependent/Search.t command does not return 0? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9819 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It looks like we got stuck on this... but would be a nice clean-up? :) Some of the code seems to have been removed since - patches don't apply. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9819 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro@gmail.com --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 11110 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9819 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #17 from Nicole C. Engard <nengard@gmail.com> --- I'd also like to see this make it's way in to Koha -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9819 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9819 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17558|0 |1 is obsolete| | Attachment #17559|0 |1 is obsolete| | Attachment #17560|0 |1 is obsolete| | Attachment #17587|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 45685 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45685&action=edit Bug 9819 - 'stopwords'-related code removed This patch removes code related to stopwords usage. The following methods are removed: C4::Search->remove_stopwords C4::Context->stopwords C4::Context->_new_stopwords And the buildQuery API was changed (removed the \@removed_stopwords return value). A follow-up is provided for database changes, to make rebasing easier. To test: - Apply this patch - Do some searches in both intranet and opac interfaces - Nothing should break Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9819 --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 45686 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45686&action=edit Bug 9819 - Remove 'stopwords' table from kohastructure.sql Just that. To test: - Apply the patch - Do a fresh install - The database structure should be created flawlessly - There should not be a 'stopwords' table created Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9819 --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 45687 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45687&action=edit Bug 9819 - Make updatedatabase.pl remove the 'stopwords' table To test: - Apply the patch - Will be prompted to run the updater - The 'stopwords' database should be removed ( test on a mysql prompt with > SHOW TABLES LIKE 'stopwords'; and should get no results) Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9819 --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 45688 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45688&action=edit Bug 9819 - QA Followup: Stopwords vestiges in es-ES removed Gotcha. To+ -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9819 --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 45689 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45689&action=edit Bug 9819: Make the tests pass -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9819 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|jonathan.druart@bugs.koha-c | |ommunity.org | --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Patches rebased against master, please test. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9819 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9819 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45685|0 |1 is obsolete| | --- Comment #24 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 45791 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45791&action=edit Bug 9819 - 'stopwords'-related code removed This patch removes code related to stopwords usage. The following methods are removed: C4::Search->remove_stopwords C4::Context->stopwords C4::Context->_new_stopwords And the buildQuery API was changed (removed the \@removed_stopwords return value). A follow-up is provided for database changes, to make rebasing easier. To test: - Apply this patch - Do some searches in both intranet and opac interfaces - Nothing should break Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9819 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45686|0 |1 is obsolete| | --- Comment #25 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 45792 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45792&action=edit Bug 9819 - Remove 'stopwords' table from kohastructure.sql Just that. To test: - Apply the patch - Do a fresh install - The database structure should be created flawlessly - There should not be a 'stopwords' table created Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9819 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45687|0 |1 is obsolete| | --- Comment #26 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 45793 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45793&action=edit Bug 9819 - Make updatedatabase.pl remove the 'stopwords' table To test: - Apply the patch - Will be prompted to run the updater - The 'stopwords' database should be removed ( test on a mysql prompt with > SHOW TABLES LIKE 'stopwords'; and should get no results) Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9819 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45688|0 |1 is obsolete| | --- Comment #27 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 45794 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45794&action=edit Bug 9819 - QA Followup: Stopwords vestiges in es-ES removed Gotcha. To+ Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9819 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45689|0 |1 is obsolete| | --- Comment #28 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 45795 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45795&action=edit Bug 9819: Make the tests pass Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9819 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9819 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45791|0 |1 is obsolete| | Attachment #45793|0 |1 is obsolete| | Attachment #45794|0 |1 is obsolete| | Attachment #45795|0 |1 is obsolete| | --- Comment #29 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45854 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45854&action=edit Bug 9819 - 'stopwords'-related code removed This patch removes code related to stopwords usage. The following methods are removed: C4::Search->remove_stopwords C4::Context->stopwords C4::Context->_new_stopwords And the buildQuery API was changed (removed the \@removed_stopwords return value). A follow-up is provided for database changes, to make rebasing easier. To test: - Apply this patch - Do some searches in both intranet and opac interfaces - Nothing should break Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9819 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45792|0 |1 is obsolete| | --- Comment #30 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45855 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45855&action=edit Bug 9819 - Remove 'stopwords' table from kohastructure.sql Just that. To test: - Apply the patch - Do a fresh install - The database structure should be created flawlessly - There should not be a 'stopwords' table created Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9819 --- Comment #31 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45856 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45856&action=edit Bug 9819 - Make updatedatabase.pl remove the 'stopwords' table To test: - Apply the patch - Will be prompted to run the updater - The 'stopwords' database should be removed ( test on a mysql prompt with > SHOW TABLES LIKE 'stopwords'; and should get no results) Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9819 --- Comment #32 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45857 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45857&action=edit Bug 9819 - QA Followup: Stopwords vestiges in es-ES removed Gotcha. To+ Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9819 --- Comment #33 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45858 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45858&action=edit Bug 9819: Make the tests pass Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9819 --- Comment #34 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 46092 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46092&action=edit Bug 9819 [QA Followup] - Removed missed stopwords refs, remove Schema file -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9819 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #35 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master, thanks Tomas and Jonathan! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org