http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15232 --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 45094 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45094&action=edit Bug 15232: Advanced Cataloging Editor: Fix translation issues This patch makes koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc to comply with Coding guidlines to avoid translation issues: "JS3: Avoid strings which mix text and markup Text mustn't contain HTML tags." To test: - Apply patch - Verify that code changes are correct (html markup moved out of function _(...) ) - Bonus test: Enable syspref 'EnableAdvancedCatalogingEditor' and verify that it works as before -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15232 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14459 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15232 --- Comment #4 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 45110 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45110&action=edit Bug 15232: (follow-up) Advanced Cataloging Editor: Fix translation issues Change JS 'h3' for <h3> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15232 --- Comment #5 from Marc Véron <veron@veron.ch> --- Thanks Héctor for fixiing my error, I commited a little bit to fast... :-) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15232 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45094|0 |1 is obsolete| | Attachment #45110|0 |1 is obsolete| | --- Comment #6 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 45129 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45129&action=edit Bug 15232: Advanced Cataloging Editor: Fix translation issues This patch makes koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc to comply with Coding guidlines to avoid translation issues: "JS3: Avoid strings which mix text and markup Text mustn't contain HTML tags." To test: - Apply patch - Verify that code changes are correct (html markup moved out of function _(...) ) - Bonus test: Enable syspref 'EnableAdvancedCatalogingEditor' and verify that it works as before With type fix from: Hector Castro <hector.hecaxmmx@gmail.com> Signed-off-by: Frédéric Demians <f.demians@tamil.fr> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15232 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45129|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 45143 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45143&action=edit Bug 15232: Advanced Cataloging Editor: Fix translation issues This patch makes koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc to comply with Coding guidlines to avoid translation issues: "JS3: Avoid strings which mix text and markup Text mustn't contain HTML tags." To test: - Apply patch - Verify that code changes are correct (html markup moved out of function _(...) ) - Bonus test: Enable syspref 'EnableAdvancedCatalogingEditor' and verify that it works as before With type fix from: Hector Castro <hector.hecaxmmx@gmail.com> Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15232 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45143|0 |1 is obsolete| | --- Comment #8 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 46040 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46040&action=edit Bug 15232: Advanced Cataloging Editor: Fix translation issues This patch makes koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc to comply with Coding guidlines to avoid translation issues: "JS3: Avoid strings which mix text and markup Text mustn't contain HTML tags." To test: - Apply patch - Verify that code changes are correct (html markup moved out of function _(...) ) - Bonus test: Enable syspref 'EnableAdvancedCatalogingEditor' and verify that it works as before With type fix from: Hector Castro <hector.hecaxmmx@gmail.com> Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15232 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice@biblibre.com --- Comment #10 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed in 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes.