[Bug 25154] New: Accessibility: The 'Search results' page does not use heading markup where content is introduced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25154 Bug ID: 25154 Summary: Accessibility: The 'Search results' page does not use heading markup where content is introduced Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: oleonard@myacpl.org, testopia@bugs.koha-community.org Depends on: 25153 Blocks: 23003 Library Catalogue - OPAC 1/ Perform a search 2/ The resultant page does not use heading mark-up where content is being introduced. As there are many links present on the page within the filer and search section, a heading is required to enable screen reader users to determine where the search results begin. Headings also allow screen reader users to skip to different sections of content quickly. Current code: <p id="numresults"> <strong>Your search returned 4013 results.</strong> Solution: Ensure that a heading is used to introduce the search results, for example: <h2>Your search returned 4013 results</h2> Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003 [Bug 23003] Accessibility improvements https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25153 [Bug 25153] Accessibility: 1.3.1 Info and Relationships -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25154 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|23003 |25153 Depends on|25153 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003 [Bug 23003] Accessibility improvements https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25153 [Bug 25153] Accessibility: 1.3.1 Info and Relationships -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25154 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25240 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25240 [Bug 25240] Accessibility: The 'Basket' page contains an inaccessible table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25154 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|25240 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25240 [Bug 25240] Accessibility: The 'Basket' page contains an inaccessible table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25154 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25241 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25241 [Bug 25241] Accessibility: 1.4.4 Resize text -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25154 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|25241 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25241 [Bug 25241] Accessibility: 1.4.4 Resize text -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25154 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 105743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105743&action=edit Bug 25254: Add heading where content is introduced in opac-results.tt Prior to this patch, the search results page did not contain a semantically accurate heading to introduce he main content of the page. Test plan 1/ Perform a search in the OPAC that yields results 2/ Inspect the page and note that the 'title' stating how many results are found is not semantically marked up as a heading to introduce the content. 3/ Apply the patch 4/ Reload the page 5/ Inspect the page and note that the 'title' stating how many results are found is now properly marked up as a second level heading and appropriately designated as the start of the 'maincontent' block with an associated '.maincontent' class. 6/ Perform a search which yields zero results 7/ Note that the 'No results found' title is properly marked up as a second level heading. 8/ Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25154 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard@myacpl.org |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25154 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bolshawh@parliament.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25154 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- I don't think we want to add the "maincontent" class to the <h2>. I think we should try to keep that class for container <div>s. Anyway, it's already added to the <div> right above the "[% IF ( searchdesc ) %]" block -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25154 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 105768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105768&action=edit Bug 25154: Add heading where content is introduced in opac-results.tt Prior to this patch, the search results page did not contain a semantically accurate heading to introduce he main content of the page. Test plan 1/ Perform a search in the OPAC that yields results 2/ Inspect the page and note that the 'title' stating how many results are found is not semantically marked up as a heading to introduce the content. 3/ Apply the patch 4/ Reload the page 5/ Inspect the page and note that the 'title' stating how many results are found is now properly marked up as a second level heading and appropriately designated as the start of the 'maincontent' block with an associated '.maincontent' class. 6/ Perform a search which yields zero results 7/ Note that the 'No results found' title is properly marked up as a second level heading. 8/ Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25154 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105743|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25154 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Good catch.. new patch uploaded. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25154 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25154 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105768|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 105770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105770&action=edit Bug 25154: Add heading where content is introduced in opac-results.tt Prior to this patch, the search results page did not contain a semantically accurate heading to introduce he main content of the page. Test plan 1/ Perform a search in the OPAC that yields results 2/ Inspect the page and note that the 'title' stating how many results are found is not semantically marked up as a heading to introduce the content. 3/ Apply the patch 4/ Reload the page 5/ Inspect the page and note that the 'title' stating how many results are found is now properly marked up as a second level heading and appropriately designated as the start of the 'maincontent' block with an associated '.maincontent' class. 6/ Perform a search which yields zero results 7/ Note that the 'No results found' title is properly marked up as a second level heading. 8/ Signoff Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25154 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25154 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105770|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 106122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106122&action=edit Bug 25154: Add heading where content is introduced in opac-results.tt Prior to this patch, the search results page did not contain a semantically accurate heading to introduce he main content of the page. Test plan 1/ Perform a search in the OPAC that yields results 2/ Inspect the page and note that the 'title' stating how many results are found is not semantically marked up as a heading to introduce the content. 3/ Apply the patch 4/ Reload the page 5/ Inspect the page and note that the 'title' stating how many results are found is now properly marked up as a second level heading and appropriately designated as the start of the 'maincontent' block with an associated '.maincontent' class. 6/ Perform a search which yields zero results 7/ Note that the 'No results found' title is properly marked up as a second level heading. 8/ Signoff Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25154 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25154 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25154 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- This patch fails the QA script for me: FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt FAIL forbidden patterns forbidden pattern: Font Awesome icons need the aria-hidden attribute for accessibility purpose (see bug 25166) (line 105) Which I do not understand because that line does include the aria-hidden attribute. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25154 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00 |20.11.00, 20.05.02 released in| | Status|Pushed to master |Pushed to stable --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- I don't see how the QA script failure could be a problem, I am backporting this anyway since it improves accessibility. backported to 20.05.x for 20.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25154 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|20.11.00, 20.05.02 |20.11.00, 20.05.02, released in| |19.11.08 CC| |aleisha@catalyst.net.nz --- Comment #10 from Aleisha Amohia <aleisha@catalyst.net.nz> --- backported to 19.11.x for 19.11.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25154 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00, 20.05.02, |20.11.00, 20.05.02, released in|19.11.08 |19.11.08, 19.05.14 Status|Pushed to oldstable |Pushed to oldoldstable CC| |victor@tuxayo.net --- Comment #11 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported to 19.05.x branch for 19.05.14 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org