[Bug 20505] New: Selenium tests fail if server not running
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20505 Bug ID: 20505 Summary: Selenium tests fail if server not running Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: mtompset@hotmail.com QA Contact: testopia@bugs.koha-community.org If the dependencies for the Selenium tests are installed, but the steps recommended on https://wiki.koha-community.org/wiki/Using_Selenium_with_Koha are not taken before running the selenium tests, they die non-gracefully. Patch them to skip informatively. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20505 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20505 --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 73517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73517&action=edit Bug 20505: Patch selenium tests to skip gracefully TEST PLAN --------- 1) In a koha shell on kohadevbox, run prove -v t/db_dependent/selenium until it doesn't skip because of missing dependencies, but rather because of not running a selenium server. 2) apply this patch and restart_all 3) rerun the tests -- they will skip gracefully and informatively. 4) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20505 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |mtompset@hotmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20505 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20505 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20505 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73517|0 |1 is obsolete| | --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 74364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74364&action=edit Bug 20505: Patch selenium tests to skip gracefully TEST PLAN --------- 1) In a koha shell on kohadevbox, run prove -v t/db_dependent/selenium until it doesn't skip because of missing dependencies, but rather because of not running a selenium server. 2) apply this patch and restart_all 3) rerun the tests -- they will skip gracefully and informatively. 4) run koha qa test tools Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20505 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- To trigger the test plan I installed the dependencies but did not setup the server -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20505 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20505 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74364|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 75054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75054&action=edit Bug 20505: Patch selenium tests to skip gracefully TEST PLAN --------- 1) In a koha shell on kohadevbox, run prove -v t/db_dependent/selenium until it doesn't skip because of missing dependencies, but rather because of not running a selenium server. 2) apply this patch and restart_all 3) rerun the tests -- they will skip gracefully and informatively. 4) run koha qa test tools Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20505 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20505 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |tomascohen@gmail.com Status|Passed QA |In Discussion --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I do not know if this is valid, I would prefer to explode if the server is not running and to know there is something wrong in the setup. The error is explicit: "Selenium server did not return proper status" This change could hide problems in jenkins configuration. Tomas, opinion? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20505 --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 75136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75136&action=edit Bug 20505: Friendlier death message Actually telling the user where to look to solve the problem is more helpful than just expecting them to know why the selenium driver didn't load. Failures should be in the test file, not nested deep in subcalls. prove t/db_dependent/selenium/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20505 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |WONTFIX CC| |dcook@prosentient.com.au --- Comment #7 from David Cook <dcook@prosentient.com.au> --- Closing this due to age and since koha-testing-docker makes this much easier these days -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org