https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20197 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20197 Dilan Johnpullé <dilan@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71617|0 |1 is obsolete| | --- Comment #2 from Dilan Johnpullé <dilan@calyx.net.au> --- Created attachment 75577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75577&action=edit Bug 20197: RFC3339 missing from options The output_pref in Koha::DateUtils has rfc3339 logic, but there is no way to set the system preference to rfc3339. This adds that option. TEST PLAN ---------- 0) back up your DB if you wish. 1) apply this patch. 2) Run the following commands: $ mysql -u koha_kohadev -p > use koha_kohadev; > SELECT options FROM systempreferences WHERE variable='dateformat'; -- no rfc3339 listed. 3) Run the following commands: > quit $ updatedatabase $ mysql -u koha_kohadev -p > use koha_kohadev; > SELECT options FROM systempreferences WHERE variable='dateformat'; -- rfc3339 now listed. 4) Run the following commands: > quit $ reset_all $ mysql -u koha_kohadev -p > use koha_kohadev; > SELECT options FROM systempreferences WHERE variable='dateformat'; -- rfc3339 still listed. 5) Log into the staff client 6) Home -> Administration -> Global System Preferences -> i18n/l10n -- rfc3339 should be listed in the dateformat syspref drop-down. 7) run koha qa test tools 8) restore DB if needed Followed test plan and everything checks out. Syspref appears as another yyy-mm-dd entry though. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20197 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |In Discussion --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I still do not see the point of adding it. http://irc.koha-community.org/koha/2018-02-14#i_2011298 17:30 mtompset BTW, easy sign off: bug 20197 17:30 huginn` Bug http://bugs.koha-community.org[…]_bug.cgi?id=20197 trivial, P5 - low, ---, mtompset, Needs Signoff , Missing rfc3339 in systempreference choices for dateformat 17:31 Joubu It's not missing 17:32 we do not want it 17:32 do you want it? 17:34 mtompset Why don't we want? 17:35 DonnaB joined #koha 17:35 mtompset No, I don't believe I would use it, but if the API uses it, why not let the user set things to see what the API sees? 17:37 andrewfh joined #koha 17:38 Joubu because it's only used by the api to format date for JSON 17:39 tcohen mtompset: if you are curious about it, better look at the RFC :-P 17:40 Joubu mtompset: you should also keep in mind that we do not want to add stuffs that nobody asked for :) 17:41 it will adds code to maintain for nothing 17:42 paxed mtompset: also see date-format.inc 17:43 although it doesn't explicitly need change, ... -- You are receiving this mail because: You are watching all bug changes.