[Bug 6576] New: changing framework while cataloging looses data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6576 Bug #: 6576 Summary: changing framework while cataloging looses data Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: critical Priority: P5 Component: Cataloging AssignedTo: gmcharlt@gmail.com ReportedBy: nengard@gmail.com QAContact: koha-bugs@lists.koha-community.org CC: ian.walls@bywatersolutions.com I did a few tests of this and every time a different amount of data was lost, but data was lost every time. If you're cataloging a new record in the default framework and then after entering data change the framework to another framework it loses data that was in fields that appear in both frameworks. This could cause someone to lose a lot of work. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6576 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|gmcharlt@gmail.com |srdjan@catalyst.net.nz --- Comment #1 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-09-12 09:16:32 UTC --- Created attachment 5403 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5403 patch This will only apply for new records, will not apply for modifying existing ones. Please check if there are no fields that are retaining values that are not applicable for the new (changed) framework -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6576 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff Change sponsored?|--- |Sponsored -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6576 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com Patch Status|Needs Signoff |Failed QA --- Comment #2 from Liz Rea <wizzyrea@gmail.com> 2011-09-20 21:28:08 UTC --- I'm not able to apply this patch: Applying: bug_6576: Submit when changing framework rather then reloading error: patch failed: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt:776 error: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt: patch does not apply Patch failed at 0001 bug_6576: Submit when changing framework rather then reloading -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6576 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff --- Comment #3 from Liz Rea <wizzyrea@gmail.com> 2011-09-20 21:50:17 UTC --- That's my bad I left off the -3 and git bz wouldn't apply it. git am -3 applied it just fine. Apologies, Srdjan. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6576 --- Comment #4 from Liz Rea <wizzyrea@gmail.com> 2011-09-20 21:59:07 UTC --- Created attachment 5484 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5484 [Signed Off] bug_6576: Submit when changing framework rather then reloading TransformHtmlToMarc(): changed interface - no point passing params when they can be accessed from $cgi Signed-off-by: Liz Rea <lrea@nekls.org> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6576 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6576 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Passed QA --- Comment #5 from Ian Walls <ian.walls@bywatersolutions.com> 2011-09-21 15:38:00 UTC --- Catches all usage of TransformHtmlToMarc and updates correctly. Usage within the subroutine has been updated to reflect the new data type. Some change to spacing, and a change to some of the JS on the addbiblio template. All in all, looks good, marking as Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6576 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Passed QA |Patch Pushed --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> 2011-09-21 21:28:32 UTC --- Pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6576 --- Comment #7 from Ian Walls <ian.walls@bywatersolutions.com> 2011-10-05 15:16:23 UTC --- Srdjan, The addition of this logic to addbiblio.pl is causing bug 6974: + if ( $record eq -1 ) { + $record = TransformHtmlToMarc( $input ); + } + else { #FIXME: it's kind of silly to go from MARC::Record to MARC::File::XML and then back again just to fix the encoding - eval { - my $uxml = $record->as_xml; - MARC::Record::default_record_format("UNIMARC") - if ( C4::Context->preference("marcflavour") eq "UNIMARC" ); - my $urecord = MARC::Record::new_from_xml( $uxml, 'UTF-8' ); - $record = $urecord; - }; + eval { + my $uxml = $record->as_xml; + MARC::Record::default_record_format("UNIMARC") + if ( C4::Context->preference("marcflavour") eq "UNIMARC" ); + my $urecord = MARC::Record::new_from_xml( $uxml, 'UTF-8' ); + $record = $urecord; + }; + } Can you help me understand the reasoning behind adding the conditional check for $record eq -1? What does that fix? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6576 --- Comment #8 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-10-05 23:56:13 UTC --- That fixes generating a trapped exception error when attempting to correct encoding on a non-existing record when op is not 'addbiblio'. I see that I probably did too much and will correct that. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6576 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Patch Pushed |--- --- Comment #9 from Nicole C. Engard <nengard@gmail.com> 2011-10-07 12:22:38 UTC --- This bug is back after a fetch this morning. Something applied last night reverted this functionality. I can't change the framework when cataloging or all the fields get emptied. Nicole -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6576 --- Comment #10 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-10-10 04:07:40 UTC --- I have no idea. I can only say that patch has been applied to master, and seems to be working there -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6576 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> 2011-10-10 12:43:01 UTC --- (In reply to comment #10)
I have no idea. I can only say that patch has been applied to master, and seems to be working there
Except for Bug 6959 and Bug 6974. Since the patch for this bug seems to have caused those, I'm guessing the patches for those has caused this to resurface? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6576 --- Comment #12 from Nicole C. Engard <nengard@gmail.com> 2011-10-10 15:45:01 UTC --- What is the process when that happens? Do those patches have to be fixed or does this one need a new patch? Chris or Ian can tell us. Nicole -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6576 --- Comment #13 from Chris Cormack <chris@bigballofwax.co.nz> 2011-10-10 19:34:48 UTC --- I think fixing one of the other ones, that undid this fix is probably what needs to happen You should be able to test which one caused it, by reverting them, one at a time -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6576 --- Comment #14 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-10-11 01:43:29 UTC --- Again, I am a bit confused here. I have a kc/master checkout. * all 6576, 6959 and 6974 are applied * I tried going from Default to Book framework and back again: - page was submitted every time (as expected) - on the first page ( 0 ) 0 LEADER, 8 GENERAL INFO, 20 ISBN and 24 OTHER STANDARD IDENTIFIER were preserved, as well as 942 "Source of classification" and "item type" Can you please describe what was expected, and what happened. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6576 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Patch Status|--- |Patch Pushed Resolution| |FIXED --- Comment #15 from Nicole C. Engard <nengard@gmail.com> 2011-10-11 12:43:38 UTC --- Srdjan is right, it's working. Nicole -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6576 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10448 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org