[Bug 10250] New: typo in help/reports/guided_reports.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10250 Bug ID: 10250 Summary: typo in help/reports/guided_reports.tt Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: mathieu.saby@univ-rennes2.fr typo in help/reports/guided_reports.tt : CreditXXX should be credit</li> M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10250 --- Comment #1 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- also : missing space after "=" in this line <li>W =Waiting: the reserve is linked to an item, is at the pickup branch, and is waiting on the hold shelf</li> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10250 --- Comment #2 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- in the same file, probably an other typo, but I am not sure : 6 = Delete should be 6 = Deleted -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10250 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|typo in |typos in |help/reports/guided_reports |help/reports/guided_reports |.tt |.tt -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10250 --- Comment #3 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Another typo: "What are the possible codes for the area field in the reports_dictionary table?" should be "What are the possible codes for the report_area field in the reports_dictionary table?" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10250 --- Comment #4 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- 1 other typos : What are the possible codes for the status field in the serial table"? should be What are the possible codes for the status field in the serial table? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10250 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com Component|Templates |Documentation Assignee|oleonard@myacpl.org |nengard@gmail.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10250 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.12 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10250 --- Comment #5 from Nicole C. Engard <nengard@gmail.com> --- (In reply to comment #0)
typo in help/reports/guided_reports.tt :
CreditXXX should be credit</li>
M. Saby
Actually it's right - it's going to say Credit and then the XX is the value after it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10250 --- Comment #6 from Nicole C. Engard <nengard@gmail.com> --- (In reply to comment #2)
in the same file, probably an other typo, but I am not sure :
6 = Delete
should be
6 = Deleted
Nope, that's the value that's stored in the DB. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10250 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10250 --- Comment #7 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 18254 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18254&action=edit Bug 10250: Fix typos in guided reports help file This is a string patch that fixes typos in the guided reports help file. To test: * Go to the guided reports page * Click help * Confirm text is right -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10250 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10250 --- Comment #8 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Not sure CreditXXX is right : - HTML closing Tag </li> missing - I don't know how to translate CreditXXX in french Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10250 --- Comment #9 from Nicole C. Engard <nengard@gmail.com> --- The closing <li> is after the </ul> as it should be. And the way the data is stored is Credit and then a code - all one word with no spaces. How would be a better way to denote this? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10250 --- Comment #10 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Oh, I looked to quickly. I did not understand the structure of the code. Of course you are right! We'll find a way to translate CreditXXX (I translated in french as "Credit </li>" - SHAME ON ME!) Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10250 --- Comment #11 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- By the way, CreditXXX is the only value begining with an Uppercase in the list. It is not a typo ? http://manual.koha-community.org/3.10/en/reportsfaq.html#statscodefaq Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10250 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Mathieu, are you sure those should be translated? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10250 --- Comment #13 from Nicole C. Engard <nengard@gmail.com> --- (In reply to comment #12)
Mathieu, are you sure those should be translated?
I was just coming here to say that. I didn't think about it yesterday, but these are database values, they won't be different if you're using a different language pack - they should not be translated I would think. Nicole -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10250 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10250 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18254|0 |1 is obsolete| | --- Comment #14 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 18766 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18766&action=edit Bug 10250: Fix typos in guided reports help file This is a string patch that fixes typos in the guided reports help file. To test: * Go to the guided reports page * Click help * Confirm text is right Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10250 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10250 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18766|0 |1 is obsolete| | --- Comment #15 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 18783 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18783&action=edit Bug 10250: Fix typos in guided reports help file This is a string patch that fixes typos in the guided reports help file. To test: * Go to the guided reports page * Click help * Confirm text is right Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10250 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #16 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Nicole! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10250 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.1. Thanks Nicole! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org