[Bug 23273] New: Downloading from overdues.pl doesn't use set filters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273 Bug ID: 23273 Summary: Downloading from overdues.pl doesn't use set filters Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To Test: - go to overdues.pl - construct a search limiting by date due and library - note number of overdues in results - click "Download file of displayed overdues" - note that downloaded file contains all overdues, not just those in your search -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273 Ray Delahunty <r.delahunty@arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty@arts.ac.uk --- Comment #1 from Ray Delahunty <r.delahunty@arts.ac.uk> --- The URLs of the download link are quite different (browser used was Microsoft Edge, but the filtering loss was observed with other browsers). The URL in 18.11.04 (our version now): https://ual-staff.koha-ptfs.co.uk/cgi-bin/koha/circ/overdue.pl?op=csv&dateduefrom%3D%26datedueto%3D%26borname%3D%26borcat%3D%26borflag%3D%26patron_attr_filter_COURSE%3D%26patron_attr_filter_COURSEDES%3D%26patron_attr_filter_LIBNO%3D%26patron_attr_filter_STUDENTID%3D%26itemtype%3D%26homebranch%3D%26holdingbranch%3D%26branch%3DLCF The URL in 17.04 (our previous version, with the branch filter set to London College of Fashion (LCF): https://ualtest-staff.koha-ptfs.co.uk/cgi-bin/koha/circ/overdue.pl?op=csv&dateduefrom=;datedueto=;borname=;borcat=;borflag=;patron_attr_filter_COURSE=;patron_attr_filter_COURSEDES=;patron_attr_filter_LIBNO=;patron_attr_filter_STUDENTID=;itemtype=;homebranch=;holdingbranch=;branch=LCF -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.11 |master CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Confirmed on master. This looks like it could be a problem with the construction of the URL/use of filters. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 92365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92365&action=edit Bug 23273: Fix CSV export for overdues We should construct the URI parameters string manually to avoid filtering problems. We cannot send the full query_string to the template and expect that the string will be escaped correctly. Test plan: - go to overdues.pl - construct a search limiting by date due and library - note number of overdues in results - click "Download file of displayed overdues" => note that downloaded file contains just those in your search -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 92367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92367&action=edit Bug 23281: Cleanup Koha::Patron::Attribute::Types->search Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92367|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Owen Leonard from comment #4)
Bug 23281: Cleanup Koha::Patron::Attribute::Types->search
I blame git-bz! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92365|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 92368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92368&action=edit Bug 23273: Fix CSV export for overdues We should construct the URI parameters string manually to avoid filtering problems. We cannot send the full query_string to the template and expect that the string will be escaped correctly. Test plan: - go to overdues.pl - construct a search limiting by date due and library - note number of overdues in results - click "Download file of displayed overdues" => note that downloaded file contains just those in your search Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21852 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 [Bug 21852] Add more columns and column configuration to overdues report -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92368|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 92372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92372&action=edit Bug 23273: Fix CSV export for overdues We should construct the URI parameters string manually to avoid filtering problems. We cannot send the full query_string to the template and expect that the string will be escaped correctly. Test plan: - go to overdues.pl - construct a search limiting by date due and library - note number of overdues in results - click "Download file of displayed overdues" => note that downloaded file contains just those in your search Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We are missing a filter here, should be an easy fix, but was not sure which one to use here: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt FAIL filters missing_filter at line 39 ( [% url_params = BLOCK %][% url_params %]&[% var | uri %]=[% filters.$var | uri %][% END %]) Leaving PQA for now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #8)
We are missing a filter here, should be an easy fix, but was not sure which one to use here:
FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt FAIL filters missing_filter at line 39 ( [% url_params = BLOCK %][% url_params %]&[% var | uri %]=[% filters.$var | uri %][% END %])
Leaving PQA for now.
Martin, you added: - [% url_params = BLOCK %][% url_params %]&[% var | uri %]=[% filters.$var | uri %][% END %] + [% url_params = BLOCK %][% url_params | uri %]&[% var | uri %]=[% filters.$var | uri %][% END %] It feel wrong, it should be $raw, otherwise it will be double encoded. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Also, there was a debug statement: +use Data::Printer colored => 1; warn p $filters; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 92517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92517&action=edit Bug 23273: Remove debug statement -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92517|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 92527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92527&action=edit Bug 23273: Remove debug statement Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Moving into PQA queue for better visibility. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|19.11.00 |19.11.00,19.05.04 released in| | --- Comment #15 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 19.05.x for 19.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |ASSIGNED Version(s)|19.11.00,19.05.04 |19.11.00 released in| | --- Comment #16 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Sorry I went to fast on backporting this. A patch is missing in master and i found an issue. I revert for now from 19.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273 --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Followup pushed and filters corrected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00,19.05.04 released in| | Status|Pushed to master |Pushed to stable --- Comment #19 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 19.05.x for 19.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273 Axelle Aix-Marseille Université <axelle.clarisse@univ-amu.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |axelle.clarisse@univ-amu.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas@bywatersolutions.com --- Comment #20 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.11.x for 18.11.10 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org