[Bug 23502] New: Staff client "revert status" buttons should not depend on SuspendHoldsIntranet preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23502 Bug ID: 23502 Summary: Staff client "revert status" buttons should not depend on SuspendHoldsIntranet preference Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 21608 Bug 21608 added buttons to revert the in transit or waiting statuses of holds in the staff client. However, the markup for the button is inside a check for the SuspendHoldsIntranet preference: [% IF SuspendHoldsIntranet %] I think this is unintentional. The buttons should be available even if a library has SuspendHoldsIntranet disabled. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23502 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23502 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23502 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 92458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92458&action=edit Bug 23502: Staff client "revert status" buttons should not depend on SuspendHoldsIntranet preference This bug corrects the template logic controlling the display of the "Revert waiting status" and "Revert transit status" buttons on the staff client holds page so that it doesn't depend on having SuspendHoldsIntranet enabled. To test, apply the patch and locate a title which has multiple holds, including: - One waiting hold - One in-transit hold - At least one pending hold View the page with the SuspendHoldsIntranet preference both on and off. The "Revert transit status" and "Revert waiting status" buttons should be displayed either way. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23502 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92458|0 |1 is obsolete| | --- Comment #2 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 92466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92466&action=edit Bug 23502: Staff client "revert status" buttons should not depend on SuspendHoldsIntranet preference This bug corrects the template logic controlling the display of the "Revert waiting status" and "Revert transit status" buttons on the staff client holds page so that it doesn't depend on having SuspendHoldsIntranet enabled. To test, apply the patch and locate a title which has multiple holds, including: - One waiting hold - One in-transit hold - At least one pending hold View the page with the SuspendHoldsIntranet preference both on and off. The "Revert transit status" and "Revert waiting status" buttons should be displayed either way. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23502 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maryse.simard@inlibro.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23502 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23502 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92466|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 92508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92508&action=edit Bug 23502: Staff client "revert status" buttons should not depend on SuspendHoldsIntranet preference This bug corrects the template logic controlling the display of the "Revert waiting status" and "Revert transit status" buttons on the staff client holds page so that it doesn't depend on having SuspendHoldsIntranet enabled. To test, apply the patch and locate a title which has multiple holds, including: - One waiting hold - One in-transit hold - At least one pending hold View the page with the SuspendHoldsIntranet preference both on and off. The "Revert transit status" and "Revert waiting status" buttons should be displayed either way. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23502 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23502 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23502 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m Version(s)|19.11.00 |19.11.00,19.05.04 released in| | --- Comment #5 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 19.05.x for 19.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23502 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas@bywatersolutions.com --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.11.x for 18.11.10 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org