[Bug 37596] New: Pending on-site checkouts terminology change needed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37596 Bug ID: 37596 Summary: Pending on-site checkouts terminology change needed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: esther.melander@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To replicate: 1. Enable OnSitecheckouts 2. Find some items and check them out by checking the box for On-Site. 3. Go to circulation and select the button for Pending On-site Checkouts 4. See a table of checked-out items The table found in Pending On-site Checkouts is not populated until items are actually checked out. The term Pending is confusing because the items are not in a waiting status. Pending should be changed to Current or Outstanding. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37596 --- Comment #1 from Esther Melander <esther.melander@bywatersolutions.com> --- Or maybe remove the word Pending and just have it be On-Site Checkouts. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37596 Nicolas Hunstein <nicolas.hunstein@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37596 --- Comment #2 from Nicolas Hunstein <nicolas.hunstein@bsz-bw.de> --- Created attachment 176518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176518&action=edit Bug 37596: update the string "Pending On-Site Checkouts" changes string "Pending On-Site Checkouts" to "On-site checkouts" to test: - enable OnSiteCheckouts - find some items and check them out by checking the box for On-Site - go to circulation an select the button for Pending on-site checkouts - see a table of checked-out items - apply patch - verify string has changed to On-site checkouts -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37596 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Status|Needs Signoff |Patch doesn't apply --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I get a merge error when trying to apply the patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37596 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nicolas.hunstein@bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37596 Nicolas Hunstein <nicolas.hunstein@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176518|0 |1 is obsolete| | --- Comment #4 from Nicolas Hunstein <nicolas.hunstein@bsz-bw.de> --- Created attachment 180476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180476&action=edit Bug 37596: update the string "Pending On-Site Checkouts" changes string "Pending On-Site Checkouts" to "On-site checkouts" to test: - enable OnSiteCheckouts - find some items and check them out by checking the box for On-Site - go to circulation an select the button for Pending on-site checkouts - see a table of checked-out items - apply patch - verify string has changed to On-site checkouts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37596 Nicolas Hunstein <nicolas.hunstein@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180476|0 |1 is obsolete| | --- Comment #5 from Nicolas Hunstein <nicolas.hunstein@bsz-bw.de> --- Created attachment 180612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180612&action=edit Bug 37596: update the string "Pending On-Site Checkouts" changes string "Pending On-Site Checkouts" to "On-site checkouts" to test: - enable OnSiteCheckouts - find some items and check them out by checking the box for On-Site - go to circulation an select the button for Pending on-site checkouts - see a table of checked-out items - apply patch - verify string has changed to On-site checkouts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37596 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37596 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37596 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180612|0 |1 is obsolete| | --- Comment #6 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 180712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180712&action=edit Bug 37596: update the string "Pending On-Site Checkouts" changes string "Pending On-Site Checkouts" to "On-site checkouts" to test: - enable OnSiteCheckouts - find some items and check them out by checking the box for On-Site - go to circulation an select the button for Pending on-site checkouts - see a table of checked-out items - apply patch - verify string has changed to On-site checkouts Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37596 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37596 --- Comment #7 from Esther Melander <esther.melander@bywatersolutions.com> --- This was marked as patch doesn't apply. Could we get more information about what needs to be corrected so this can go through? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37596 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Esther Melander from comment #7)
This was marked as patch doesn't apply. Could we get more information about what needs to be corrected so this can go through?
Hi Esther, patch doesn't apply means that the developer or someone else with a dev environment needs to make some changes to resolve a conflict. If a patch was written and then the file it touches changes before the patch is applied, conflicts can arise - git doesn't know how to fit the code of the patch into the changed file. Hope that makes sense. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org