https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Bug ID: 23258 Summary: Batch holding Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: matthias.meusburger@biblibre.com QA Contact: testopia@bugs.koha-community.org Add a "batch holding" tool (just like batch item modification, batch patron deletion...) This tool would allow to place or cancel holds in batch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 --- Comment #1 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 91230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91230&action=edit Bug 23258: Batch holding This patch allows to batch place or cancel holds. Test plan: 1) Apply the patch 2) Go to Tools -> Batch holding 3) Check that you can either upload a barcode file or use the textarea 4) Check that you can place holds on items 5) Check that you can cancel holds on items -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- I can't seem to get this to work... Every time I submit a set of barcodes it tells me none of them can be placed on hold. I can place an item-level hold for the same patron using the regular method, so I assume it's not a problem with my circulation rules. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- This needs some follow-up work to fix QA tool warnings too. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Jessie Zairo <jzairo@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo@bywatersolutions.com | |, | |kelly@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91230|0 |1 is obsolete| | --- Comment #4 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 106055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106055&action=edit Bug 23258: Batch holding This patch allows to batch place or cancel holds. Test plan: 1) Apply the patch 2) Go to Tools -> Batch holding 3) Check that you can either upload a barcode file or use the textarea 4) Check that you can place holds on items 5) Check that you can cancel holds on items -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106055|0 |1 is obsolete| | --- Comment #5 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 106077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106077&action=edit Bug 23258: Batch holding This patch allows to batch place or cancel holds. Test plan: 1) Apply the patch 2) Go to Tools -> Batch holding 3) Check that you can either upload a barcode file or use the textarea 4) Check that you can place holds on items 5) Check that you can cancel holds on items -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106077|0 |1 is obsolete| | --- Comment #6 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 106091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106091&action=edit Bug 23258: Batch holding This patch allows to batch place or cancel holds. Test plan: 1) Apply the patch 2) Go to Circulation -> Batch holding 3) Check that you can either upload a barcode file or use the textarea 4) Check that you can place holds on items 5) Check that you can cancel holds on items -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Thanks for the feedback Owen. The patch has been rebased and fixed to work again on master. All QA fails have been corrected, except for this one: forbidden pattern: Script permissions is authnotrequired => 0, it could be correct for an OPAC script if it is was you really want error (bug 24663) ...which cannot be fixed until Bug 24663 is pushed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 didier <didier.gautheron@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |didier.gautheron@biblibre.c | |om --- Comment #8 from didier <didier.gautheron@biblibre.com> --- Hi should be my $op = $input->param('op') // ''; remove an 'op is undefined' warning in plack. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 106598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106598&action=edit Bug 23258: (follow-up) Batch holds template followup This patch revises the batch holds template to bring it up to date with current guidelines including corrected indentation, Bootstrap grid, terminology fixes ("hold" instead of "reserve") and JavaScript in the footer. Also changed: - Add specificity to page title and breadcrumbs - Add "Select all" and "Clear all" links to confirmation page - Add jQuery validation of the form, enforcing barcode and patron entry - Swith from "Batch holding" to "Batch place and cancel holds." - Made suggested change to avoid errors in the log: my $op = $input->param('op') // ''; - Fixed some other QA tool errors To test, apply the patch and test the process of placing and cancelling holds in batches: - By uploading a file of barcodes - By submitting barcodes in the textarea - Confirm that holds are placed and cancelled At each step of the process confirm that everything looks good and works properly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- This looks like it's working pretty well but I'd like to see a couple of improvements to the information provided to the user during the process. Can we add title information to the lists of submitted barcodes? Both on the screen with the checkboxes and on the confirmation page after submission. I think it would also be good to show the patron and pickup branch information on these screens. The final result screen should provide links to both the bibliographic record detail page and the holds page for that title. At the very least the result screen needs to have more useful information. Right now it has something like: The following items have been placed on hold: itemnumber 816, reserve_id 168 The itemnumber and reserve_id numbers are not useful to the librarian. Not a QA problem but a suggestion: How hard would it be to offer the option of placing or cancelling title-level holds instead of item-level holds? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |matthias.meusburger@biblibr |ity.org |e.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 --- Comment #11 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Thank you for the feedback and improvements, Owen. You're absolutely right, the result screen lacks relevant information. I will provide a follow-up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 --- Comment #12 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 107408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107408&action=edit Bug 23258: (follow-up) QA fixes This patch adds relevant informations to the confirmation and results pages: - Patron name (with link) - Pickup location - Biblio title and item barcode (with link) - Link to the holds for the title on the result screen -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Salut Matts, please perltidy the script :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 --- Comment #14 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 108498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108498&action=edit Bug 23258: (follow-up) QA fixes: perltidy the script -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 --- Comment #15 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Salut Joubu, it's done :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Nothing is signed off already, I'd suggest to squash everything :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106091|0 |1 is obsolete| | Attachment #106598|0 |1 is obsolete| | Attachment #107408|0 |1 is obsolete| | Attachment #108498|0 |1 is obsolete| | --- Comment #17 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 108504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108504&action=edit Bug 23258: Batch holding This patch allows to batch place or cancel holds. Test plan: 1) Apply the patch 2) Go to Circulation -> Batch holding 3) Check that you can either upload a barcode file or use the textarea 4) Check that you can place holds on items 5) Check that you can cancel holds on items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 --- Comment #18 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Also done! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 --- Comment #19 from Kelly McElligott <kelly@bywatersolutions.com> --- I was successful in adding a barcode file and entering barcodes in to the text box to add holds to a patron's account. When I attempted to cancel the holds, the holds did cancel, however after confirming the cancel, the screen that showed the Cancelled holds. In this matrix, the title and Item was blank, the holds column had clickable links that said "show holds". These links brought up a hold screen for a title called "No Title). The bib didn't exist. See screenshots: http://staff-holds.sb1.sandboxes.bywatersolutions.com/cgi-bin/koha/circ/batc... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 --- Comment #20 from Kelly McElligott <kelly@bywatersolutions.com> --- Created attachment 108628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108628&action=edit cancelling -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 --- Comment #21 from Kelly McElligott <kelly@bywatersolutions.com> --- Created attachment 108630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108630&action=edit link to a blank record -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr Status|Needs Signoff |Failed QA --- Comment #22 from Séverine Queune <severine.queune@bulac.fr> --- Sorry Matthias, I fail this patch for it doesn't respect the availability of the item (tested with notforloan !=0, itype without holds allowed). I also agree with Kelly about the table displayed after the cancellation : biblio datas are missing, it could be useful to display them so it becomes possible to place an individual hold after cancelling (patrons can sometimes be hesitant...). Presence of the link "Show holds" makes me think it was the original purpose of this table, am I right ? Some things I wonder about : - when cancelling holds, don't know if a warning for an item with no hold for this patron could be useful or not - when cancelling the action on 'Confirm selection' page, maybe we could return to 'Batch holding' page instead of 'Circulation home' Several good points though ! : - warning on unknown barcode - warning when patron already has a hold on the item- good recalculation of priority if cancelled hold was not the last one - respect of the hold limitation set in circulation rules (tested total, daily and per record) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 --- Comment #23 from Jessie Zairo <jzairo@bywatersolutions.com> --- Batch modifying the pickup location would be another good option to include in this tool. Often a patron will call and ask that all 10 holds be send to another location. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Batch holding |Tool for batch processing | |holds - placing, | |cancelling, updating -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Tool for batch processing |Batch tool for placing and |holds - placing, |cancelling holds |cancelling, updating | --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- As holding can have a different meaning (stuff the library owns, items) I have updated the bug description a little bit. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Suzanne <smhodson123extra@yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |smhodson123extra@yahoo.com --- Comment #25 from Suzanne <smhodson123extra@yahoo.com> --- We would also like to have this available for batch changing a hold expiration date. Is there a way we could get a check box (and maybe a select all option--with the ability to unclick as necessary) to be able to elect multiple holds and batch change the expiration date all at once? When a patron has a lot of holds and needs more time to pick them up, it is a bit cumbersome to have to do it individually. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #26 from Fridolin Somers <fridolin.somers@biblibre.com> --- Arf, uses circ/ysearch.pl that has been removed by Bug 30578 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 --- Comment #27 from Fridolin Somers <fridolin.somers@biblibre.com> --- This needs a big rewrite. Template is missing html filters and uses YUI classes. Also perl file is missing permission reserveforothers. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Lisette Scheer <lisette.scheer@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35748 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108504|0 |1 is obsolete| | --- Comment #28 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 180199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180199&action=edit Bug 23258: Batch place or cancel holds Test plan: 1) Apply the patch 2) Go to Tools -> Patrons and circulation -> Batch place or cancel holds (/cgi-bin/koha/tools/modholds.pl) 3) Check that you can either upload a barcode file or use the textarea 4) Check that you can place holds on items 5) Check that you can cancel holds on items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108628|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108630|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #29 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Hi, this feature has been rewritten. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180199|0 |1 is obsolete| | --- Comment #30 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 180231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180231&action=edit Bug 23258: Batch place or cancel holds Test plan: 1) Apply the patch 2) Go to Tools -> Patrons and circulation -> Batch place or cancel holds (/cgi-bin/koha/tools/modholds.pl) 3) Check that you can either upload a barcode file or use the textarea 4) Check that you can place holds on items 5) Check that you can cancel holds on items Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 SamSowanick <sam.sowanick@corvallisoregon.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sam.sowanick@corvallisorego | |n.gov --- Comment #31 from SamSowanick <sam.sowanick@corvallisoregon.gov> --- Testing this, everything works as advertised in Matthias's Test Plan. I wonder what benefit this tool could offer if it had the option to place bib level holds, as currently it only uses barcode. Seconding Jessie for the ability to transfer holds from one branch to another. Currently, as far as I can tell, this can be used to cancel, then re-place the holds at the new branches. Though, I don't expect this method would keep hold place (setting the patron to last in line) and is quite cumbersome. Additionally, I wonder if this could be used to cancel ALL holds from a list of items, not just for one patron. In the past we have been trying to delete items via batch and been thwarted by a long list of holds on the items. I am signing off on this, as the tool works as advertised. Can we branch this bug for the requested enhancements above / mentioned by others herein? If this is not how things are done, please feel free to set things back to the right order. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36135 CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 --- Comment #32 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- I wonder if this bug and Bug 36135 should maybe be wrapped into the same tool? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #33 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- -If I try and place a batch hold and enter in a erroneous patron like ‘adsdasdasd’ and press continue I get a 500 error. Maybe we could prevent that 500 error page from displaying? Maybe some JS to prevent form submission? -The #find_patron has a required class, so the text is red. Shouldn’t need a class there, just the `required="required`. There should have the ‘<span class="required">Required</span>‘ so staff know it is required. As should the label. -For placing holds, I made a barcode file with 200 valid barcodes in it. In k-t-d this led to a timeout for me. I then tried with 50 barcodes, it does work about takes about 25-30 seconds. I’m not sure what is a reasonable number of holds to make at a time is but 200 seems low? Maybe we at least need a warning/hint about how many is too many? -Should the results be paginated? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 --- Comment #34 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 184148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184148&action=edit Bug 23258: fix CSRF issues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Michelle Spinney <mspinney@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184148|0 |1 is obsolete| | --- Comment #35 from Fridolin Somers <fridolin.somers@biblibre.com> --- Comment on attachment 184148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184148 Bug 23258: fix CSRF issues Bug 23258: fix CSRF issues is for old version of this with circ/batch_holding.pl CSRF and opac=cud are managed in current patch with tools/modholds.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Janne Seppänen <janne.seppanen@lahti.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janne.seppanen@lahti.fi --- Comment #36 from Janne Seppänen <janne.seppanen@lahti.fi> --- Our staff has been asking for a feature like this to be included in Koha. I had a brief test run with the patch, and it seems to be working as intended. However, a few improvements could make it even more useful: - An option to create title-level holds based on biblionumber would be great (or an option to create title-level holds on the titles of the given barcodes) - Hold expiry, notes and especially the option to create a non priority hold would be really useful -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #37 from Fridolin Somers <fridolin.somers@biblibre.com> --- Duplicate of Bug 36135 (in Koha since 25.11) ? -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org