[Bug 32022] New: Style tweaks to fieldsets and page-section
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32022 Bug ID: 32022 Summary: Style tweaks to fieldsets and page-section Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 30952 I'd like to move padding and margin-bottom into the @card mixin so that similar elements (fieldsets, page-sections) have consistent padding. I would also like to tweak the style of fieldset.action so that it works well visually in cases where it is outside the corresponding fieldset.rows. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32022 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32022 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 142731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142731&action=edit Bug 32022: Style tweaks to fieldsets and page-section This patch makes CSS changes to try to bring some consistency to various elements which are similar in the general sense of "white box." Fieldsets, page-section, etc. To test apply the patch and rebuild the staff interface CSS. Test various pages with page-section, fieldsets, etc.: - Patron details - Patron edit - Patron accounting - Check Tools -> Patron lists -> New to confirm that there is not a gap between the submit button's container and the rest of the form. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32022 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 31904 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32022 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Generally I like the consistency here.. one minor thing I wonder a bit about.. by making the 'action' fieldset also have a white background it makes it appear like the buttons are now part of that fieldset.. I think I like the spacing but would prefer the background remain the grey so the buttons appear to be distinct but related as they did before the whole refresh? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32022 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142731|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142750&action=edit Bug 32022: Style tweaks to fieldsets and page-section This patch makes CSS changes to try to bring some consistency to various elements which are similar in the general sense of "white box." Fieldsets, page-section, etc. To test apply the patch and rebuild the staff interface CSS. Test various pages with page-section, fieldsets, etc.: - Patron details - Patron edit - Patron accounting - Check Tools -> Patron lists -> New to confirm that there is not a gap between the submit button's container and the rest of the form. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32022 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142751&action=edit Bug 32022: (follow-up) Ensure action background takes presidence The action class sets the background to transparent, but because it's often used in conjunction with the fieldset which includes the card mixin the background rule was getting overridden to white. Test plan 1. Consider the same cases as the original patch 2. Confirm that the last test now shows the buttons outside of the card but nicely spaced to clearly belong to it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32022 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32022 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com, | |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32022 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32022 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142750|0 |1 is obsolete| | Attachment #142751|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 142753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142753&action=edit Bug 32022: Style tweaks to fieldsets and page-section This patch makes CSS changes to try to bring some consistency to various elements which are similar in the general sense of "white box." Fieldsets, page-section, etc. To test apply the patch and rebuild the staff interface CSS. Test various pages with page-section, fieldsets, etc.: - Patron details - Patron edit - Patron accounting - Check Tools -> Patron lists -> New to confirm that there is not a gap between the submit button's container and the rest of the form. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32022 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 142754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142754&action=edit Bug 32022: (follow-up) Ensure action background takes presidence The action class sets the background to transparent, but because it's often used in conjunction with the fieldset which includes the card mixin the background rule was getting overridden to white. Test plan 1. Consider the same cases as the original patch 2. Confirm that the last test now shows the buttons outside of the card but nicely spaced to clearly belong to it. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32022 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32022 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32022 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32022 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m --- Comment #9 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 153615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153615&action=edit picture of form in 22.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32022 --- Comment #10 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 153616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153616&action=edit picture of form in master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32022 --- Comment #11 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- This made the "Submit" button very close the form, is this intentional? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32022 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop@ptfs-europe | |.com --- Comment #12 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Possible conflict with 32605? One adds a margin to .rows and the other adds it to the .action fieldset -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32022 --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Pedro Amorim from comment #11)
This made the "Submit" button very close the form, is this intentional?
It's the patch for Bug 34072 that caused this. I'm trying to figure out what the original problem looked like so I can try to address the side-effect. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32022 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32605 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32022 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Owen Leonard from comment #13)
(In reply to Pedro Amorim from comment #11)
This made the "Submit" button very close the form, is this intentional?
It's the patch for Bug 34072 that caused this. I'm trying to figure out what the original problem looked like so I can try to address the side-effect.
Sorry for that one :( I could see the issue in testing, I didn't spot side effects but I should have looked harder. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32022 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34654 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32022 Bug 32022 depends on bug 30952, which changed state. Bug 30952 Summary: New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org