[Bug 11978] New: OverDrive API now prepends http:// to URLs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11978 Bug ID: 11978 Summary: OverDrive API now prepends http:// to URLs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: jweaver@bywatersolutions.com Reporter: jweaver@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org The OverDrive API has changed the way URLs for detail pages and other information is returned; Koha currently prepends http:// to the URLs it receives, but now OverDrive does that themselves, breaking the links. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11978 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11978 --- Comment #1 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 26497 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26497&action=edit Bug 11978 - Fix URLs displayed in OverDrive search OverDrive has recently changed its APIs to include "http://" in the URLs it returns. This patch removes the "http://" on the Koha end so they aren't doubled. Test plan: 1. Run an OverDrive search on the OPAC. 2. Check the links, they should start with "http://http://" 3. Apply this patch. 4. Rerun the search, the links should now be correct. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11978 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high Patch complexity|Trivial patch |--- Severity|enhancement |major --- Comment #2 from Jesse Weaver <jweaver@bywatersolutions.com> --- Raising importance, as this blocks clicking of links in any OPAC using OverDrive. Good candidate for a maintenance patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11978 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11978 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26497|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 26856 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26856&action=edit [SIGNED-OFF] Bug 11978 - Fix URLs displayed in OverDrive search OverDrive has recently changed its APIs to include "http://" in the URLs it returns. This patch removes the "http://" on the Koha end so they aren't doubled. Test plan: 1. Run an OverDrive search on the OPAC. 2. Check the links, they should start with "http://http://" 3. Apply this patch. 4. Rerun the search, the links should now be correct. Signed-off-by: Owen Leonard <oleonard@myacpl.org> I can reproduce the problem and confirm that this patch fixes it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11978 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11978 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26856|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 26885 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26885&action=edit [PASSED QA] Bug 11978 - Fix URLs displayed in OverDrive search OverDrive has recently changed its APIs to include "http://" in the URLs it returns. This patch removes the "http://" on the Koha end so they aren't doubled. Test plan: 1. Run an OverDrive search on the OPAC. 2. Check the links, they should start with "http://http://" 3. Apply this patch. 4. Rerun the search, the links should now be correct. Signed-off-by: Owen Leonard <oleonard@myacpl.org> I can reproduce the problem and confirm that this patch fixes it. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Patch removes hardcoded http:// from URLs in the Overdrive code. Trusting Jesse and Owen to have tested this with Overdrive, code review reveals no additional changes or possible problems. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11978 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Jesse! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11978 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #6 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.09 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11978 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11978 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org