[Bug 12642] New: SMS.t requires a database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12642 Bug ID: 12642 Summary: SMS.t requires a database Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: robin@catalyst.net.nz QA Contact: gmcharlt@gmail.com Needs to be moved to db_dependant or builds will be broken. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12642 --- Comment #1 from Robin Sheat <robin@catalyst.net.nz> --- Created attachment 30010 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30010&action=edit Bug 12642 - move SMS.t to the db_dependant directory -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12642 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12642 --- Comment #2 from Robin Sheat <robin@catalyst.net.nz> --- This needs to happen for both master and 3.16. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12642 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12657 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12642 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30010|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 30076 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30076&action=edit Bug 12642: t/SMS.t should not be db dependent SMS.t should not dependent on the DB. Test plan: verify that prove t/SMS.t returns green even if the DB is not there. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12642 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Hi Robin, I proposed a counter patch, could you please have a look? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12642 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30076|0 |1 is obsolete| | --- Comment #5 from Robin Sheat <robin@catalyst.net.nz> --- Created attachment 30177 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30177&action=edit Bug 12642: t/SMS.t should not be db dependent SMS.t should not dependent on the DB. Test plan: verify that prove t/SMS.t returns green even if the DB is not there. Signed-off-by: Robin Sheat <robin@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12642 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #6 from Robin Sheat <robin@catalyst.net.nz> --- Looks good to me, and a better solution than mine. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12642 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Assignee|chris@bigballofwax.co.nz |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12642 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12642 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30177|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 30179 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30179&action=edit [PASSED QA] Bug 12642: t/SMS.t should not be db dependent SMS.t should not dependent on the DB. Test plan: verify that prove t/SMS.t returns green even if the DB is not there. Signed-off-by: Robin Sheat <robin@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Turned off MySQL, tests still pass. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12642 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12642 --- Comment #9 from Robin Sheat <robin@catalyst.net.nz> --- Created attachment 33969 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33969&action=edit Bug 12642 - combined changelog updates for 3.16 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12642 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33969|0 |1 is obsolete| | --- Comment #10 from Robin Sheat <robin@catalyst.net.nz> --- Comment on attachment 33969 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33969 Bug 12642 - combined changelog updates for 3.16 That was not the right bug number. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12642 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate CC| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12642 --- Comment #11 from Mason James <mtj@kohaaloha.com> --- Pushed to 3.16.x, patch will be in 3.16.8 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12642 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org