[Bug 42154] New: Bug 38714 hid the "New match check" link in record matching rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42154 Bug ID: 42154 Summary: Bug 38714 hid the "New match check" link in record matching rules Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 38714 In a follow-up on Bug 38714 I made an incorrect change to the logic for displaying the "New match check" link. It should check for matchchecks, not matchpoints. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38714 [Bug 38714] Adjust templates for prettier -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42154 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42154 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Sponsorship status|--- |Sponsored Status|ASSIGNED |Needs Signoff Comma delimited| |Athens County Public list of Sponsors| |Libraries Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42154 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 195854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195854&action=edit Bug 42154: Bug 38714 hid the "New match check" link in record matching rules This patch corrects the logic used to determine whether to show the "New match check" link. I mistakenly changed it to check for the matchpoints variable instead of the matchchecks variable. To test, apply the patch and go to Administration -> Record matching rules. - Click "New record matching rule" in the toolbar. - Scroll down to the "Required match checks" section. - You should see a "New match check" link alongside a "Remove this match check" link. - Go back to the record matching rules main page. - If necessary, create a rule which doesn't have any match checks. - In the "Required match checks" section of the edit form you should see a "New match check" link, previously hidden by Bug 388714. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42154 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42154 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195854|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42154 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 195867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195867&action=edit Bug 42154: Bug 38714 hid the "New match check" link in record matching rules This patch corrects the logic used to determine whether to show the "New match check" link. I mistakenly changed it to check for the matchpoints variable instead of the matchchecks variable. To test, apply the patch and go to Administration -> Record matching rules. - Click "New record matching rule" in the toolbar. - Scroll down to the "Required match checks" section. - You should see a "New match check" link alongside a "Remove this match check" link. - Go back to the record matching rules main page. - If necessary, create a rule which doesn't have any match checks. - In the "Required match checks" section of the edit form you should see a "New match check" link, previously hidden by Bug 388714. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42154 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42154 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195867|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42154 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 199415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199415&action=edit Bug 42154: Bug 38714 hid the "New match check" link in record matching rules This patch corrects the logic used to determine whether to show the "New match check" link. I mistakenly changed it to check for the matchpoints variable instead of the matchchecks variable. To test, apply the patch and go to Administration -> Record matching rules. - Click "New record matching rule" in the toolbar. - Scroll down to the "Required match checks" section. - You should see a "New match check" link alongside a "Remove this match check" link. - Go back to the record matching rules main page. - If necessary, create a rule which doesn't have any match checks. - In the "Required match checks" section of the edit form you should see a "New match check" link, previously hidden by Bug 388714. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42154 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- git-bz asked me: Bug 42154 has sponsors not in commit trailers: • Athens County Public Libraries If you want to add it, please do so. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42154 --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #4)
git-bz asked me: Bug 42154 has sponsors not in commit trailers: • Athens County Public Libraries
If you want to add it, please do so.
Yes, it is already there? git-bz is wrong. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42154 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42154 --- Comment #6 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42154 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.11.00 |26.11.00,26.05.01 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42154 --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.01 release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42154 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.11.00,26.05.01 |26.11.00,26.05.01,25.11.05 released in| | CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #8 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Pushed into 25.11.x for 25.11.05 nice work everyone -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42154 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42154 --- Comment #9 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- EDIT: pushed to 25.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42154 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.11.00,26.05.01,25.11.05 |26.11.00,26.05.01,25.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org