[Bug 15881] New: Serials new numbering pattern link should be a toolbar button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15881 Bug ID: 15881 Summary: Serials new numbering pattern link should be a toolbar button Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/serials/subscription-numberpatterns.pl OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org In Serials -> Number patterns there is a "New numbering patterns" link which should be a Bootstrap-styled toolbar button instead. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15881 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15881 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 48305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48305&action=edit Bug 15881 - Serials new numbering pattern link should be a toolbar button This patch converts the "new numbering pattern" link to a Bootstrap-styled toolbar button for consistency with other pages in Koha. This patch also includes minor markup corrections: - Standardizing on the phrase "Numbering patterns" by eliminating the occasional use of "number patterns." - Removing mistaking closing slash on <select> - Using standard "Cancel" link instead of a button. - Adding a colon and space after labels. - Fixing of "no existing patterns" message. To test, apply the patch and go to Serials -> Numbering patterns - Confirm that the "New numbering pattern" button looks correct and works correctly. - Confirm that the entry form looks correct and that the cancel link works as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15881 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48305|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 48314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48314&action=edit Bug 15881 - Serials new numbering pattern link should be a toolbar button This patch converts the "new numbering pattern" link to a Bootstrap-styled toolbar button for consistency with other pages in Koha. This patch also includes minor markup corrections: - Standardizing on the phrase "Numbering patterns" by eliminating the occasional use of "number patterns." - Removing mistaking closing slash on <select> - Using standard "Cancel" link instead of a button. - Adding a colon and space after labels. - Fixing of "no existing patterns" message. To test, apply the patch and go to Serials -> Numbering patterns - Confirm that the "New numbering pattern" button looks correct and works correctly. - Confirm that the entry form looks correct and that the cancel link works as expected. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15881 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15881 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15881 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48314|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 48462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48462&action=edit Bug 15881 - Serials new numbering pattern link should be a toolbar button This patch converts the "new numbering pattern" link to a Bootstrap-styled toolbar button for consistency with other pages in Koha. This patch also includes minor markup corrections: - Standardizing on the phrase "Numbering patterns" by eliminating the occasional use of "number patterns." - Removing mistaking closing slash on <select> - Using standard "Cancel" link instead of a button. - Adding a colon and space after labels. - Fixing of "no existing patterns" message. To test, apply the patch and go to Serials -> Numbering patterns - Confirm that the "New numbering pattern" button looks correct and works correctly. - Confirm that the entry form looks correct and that the cancel link works as expected. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15881 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #4 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15881 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.5 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15881 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #6 from Frédéric Demians <frederic@tamil.fr> --- This patch has been pushed to 3.20.x, will be in 3.20.10. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org