[Bug 15880] New: Serials new frequency link should be a toolbar button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15880 Bug ID: 15880 Summary: Serials new frequency link should be a toolbar button Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/serials/subscription-frequencies.pl OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org In Serials -> Frequencies there is a "New frequency" link which should be a Bootstrap-styled toolbar button instead. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15880 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15881 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15880 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15880 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15880 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 48304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48304&action=edit Bug 15880 - Serials new frequency link should be a toolbar button This patch converts the "new frequency" link to a Bootstrap-style toolbar button in order to maintain consistency. Also included in this patch are some other minor markup corrections: - A colon and space after labels - A 'Cancel' link instead of a button. - "Required" classes for a required field. To test, apply the patch and go to Serials -> Manage frequencies. - Test the "New frequency" button - Confirm that the changes to the entry form look correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15880 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48304|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 48315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48315&action=edit Bug 15880 - Serials new frequency link should be a toolbar button This patch converts the "new frequency" link to a Bootstrap-style toolbar button in order to maintain consistency. Also included in this patch are some other minor markup corrections: - A colon and space after labels - A 'Cancel' link instead of a button. - "Required" classes for a required field. To test, apply the patch and go to Serials -> Manage frequencies. - Test the "New frequency" button - Confirm that the changes to the entry form look correct. Followed test plan, displays as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15880 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15880 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15880 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48315|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 48463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48463&action=edit Bug 15880 - Serials new frequency link should be a toolbar button This patch converts the "new frequency" link to a Bootstrap-style toolbar button in order to maintain consistency. Also included in this patch are some other minor markup corrections: - A colon and space after labels - A 'Cancel' link instead of a button. - "Required" classes for a required field. To test, apply the patch and go to Serials -> Manage frequencies. - Test the "New frequency" button - Confirm that the changes to the entry form look correct. Followed test plan, displays as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15880 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #4 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15880 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice@biblibre.com --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.5 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15880 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #6 from Frédéric Demians <frederic@tamil.fr> --- This patch has been pushed to 3.20.x, will be in 3.20.10. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org