[Bug 18492] New: moremember.pl template param without key
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18492 Bug ID: 18492 Summary: moremember.pl template param without key Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: lari.taskula@jns.fi QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com moremember.pl has a template parameter without a key bug after Bug 5670. I noticed this when working with Relatives checkouts tab, which was oddly missing even though the guarantee had checkouts. Also I get this warning in my logs: Problem = a value of activeBorrowerRelationship has been passed to param without key at /home/koha/kohaclone/C4/Templates.pm line 137. The issue is at the end of moremember.pl, in $template->param( ... housebound_role => $patron->housebound_role, ... ); $patron->housebound_role seems to return an empty list instead of undef in scalar context. To replicate: 1. Ensure patron is not associated with a HouseboundRole 2. Go to patron's details tab 3. See your error log, it should have a warning "Problem = a value of activeBorrowerRelationship has been passed to param without key" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18492 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18492 --- Comment #1 from Lari Taskula <lari.taskula@jns.fi> --- Created attachment 62660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62660&action=edit Bug 18492: moremember.pl template param without key moremember.pl has a template parameter without a key bug after Bug 5670. I noticed this when working with Relatives checkouts tab, which was oddly missing even though the guarantee had checkouts. Also I get this warning in my logs: Problem = a value of activeBorrowerRelationship has been passed to param without key at /home/koha/kohaclone/C4/Templates.pm line 137. The issue is at the end of moremember.pl, in $template->param( ... housebound_role => $patron->housebound_role, ... ); $patron->housebound_role seems to return an empty list instead of undef in scalar context. To replicate: 1. Ensure patron is not associated with a HouseboundRole 2. Go to patron's details tab 3. See your error log, it should have a warning "Problem = a value of activeBorrowerRelationship has been passed to param without key" To test: 1. Apply patch 2. Perform the steps at "To replicate" plan 3. Observe there are no longer warnings -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18492 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lari.taskula@jns.fi |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18492 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major --- Comment #2 from Lari Taskula <lari.taskula@jns.fi> --- Increasing importance of Bug as I cannot see relatives' checkouts tab without this patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18492 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18492 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62660|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 62665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62665&action=edit [SIGNED-OFF] Bug 18492: moremember.pl template param without key moremember.pl has a template parameter without a key bug after Bug 5670. I noticed this when working with Relatives checkouts tab, which was oddly missing even though the guarantee had checkouts. Also I get this warning in my logs: Problem = a value of activeBorrowerRelationship has been passed to param without key at /home/koha/kohaclone/C4/Templates.pm line 137. The issue is at the end of moremember.pl, in $template->param( ... housebound_role => $patron->housebound_role, ... ); $patron->housebound_role seems to return an empty list instead of undef in scalar context. To replicate: 1. Ensure patron is not associated with a HouseboundRole 2. Go to patron's details tab 3. See your error log, it should have a warning "Problem = a value of activeBorrowerRelationship has been passed to param without key" To test: 1. Apply patch 2. Perform the steps at "To replicate" plan 3. Observe there are no longer warnings Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18492 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |RESOLVED --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *** This bug has been marked as a duplicate of bug 18179 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org