[Bug 16148] New: Revised layout and behavior of marc modification template management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16148 Bug ID: 16148 Summary: Revised layout and behavior of marc modification template management Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/tools/marc_modification_templates.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org The marc modification template management page is a sort of all-in-one interface with lots of different kinds of actions appearing at the same time. The screen is more complicated and (in my opinion) harder to approach initially than other pages which are divided into the same categories of interactions (list, add, edit). I propose a revision which shows and hides sections of the page so that each task can be given better focus. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16148 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16148 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 49591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49591&action=edit Bug 16148 - Revised layout and behavior of marc modification template management This patch makes changes to the layout and behavior of the marc modification template management page to make it adhere better to common interaction patterns in Koha. - The initial view shows a list of templates rather than pre-selecting the first available template for editing. - A toolbar has been added with a "New template" button. - The initial view of existing templates has an actions menu containing menu items for 'Edit actions,' 'Duplicate,' and 'Delete.' It doesn't appear to be possible to edit an existing template's name. - The "Create template" form is no longer shown all the time. - Clicking the "New template" toolbar button triggers a modal with the form for creating a template. An existing template can be chosen to duplicate. - Choosing "Duplicate" from one of the template menus triggers the "New template" modal and preselects the corresponding template in the "duplicate" <select>. - When editing actions for a template: - The breadcrumbs menu now reflects that a template is being modified. - The template name has been added as a heading. - A "New action" button appears in the toolbar - The "Edit" and "Delete" links now have a Bootstrap button style. - The add/edit form is now hidden by default. - Clicking "New action" or "edit" shows the add or edit form. - Clicking "Cancel" in the add/edit form hides the form. To test, apply the patch and clear your cache if necessary. - Got to Tools -> MARC modification templates - Test the "New template" button. - Confirm that new template creation works. - Confirm that duplicating a template works. - Test the menu items in the "Actions" menu: - "Duplicate" should trigger the new template modal and preselect the template you chose to duplicate. Confirm that the template is successfully duplicated. - "Delete" should prompt you to confirm the deletion. Test both cancelling and confirming this operation. - "Edit actions" should load the page for adding or editing actions to a template. Test the operations on this page: New action, edit, delete, changing action order. Note that this patch does not fix Bug 15814, so action descriptions must still not contain single quotes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16148 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49591|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 49603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49603&action=edit Bug 16148 - Revised layout and behavior of marc modification template management This patch makes changes to the layout and behavior of the marc modification template management page to make it adhere better to common interaction patterns in Koha. - The initial view shows a list of templates rather than pre-selecting the first available template for editing. - A toolbar has been added with a "New template" button. - The initial view of existing templates has an actions menu containing menu items for 'Edit actions,' 'Duplicate,' and 'Delete.' It doesn't appear to be possible to edit an existing template's name. - The "Create template" form is no longer shown all the time. - Clicking the "New template" toolbar button triggers a modal with the form for creating a template. An existing template can be chosen to duplicate. - Choosing "Duplicate" from one of the template menus triggers the "New template" modal and preselects the corresponding template in the "duplicate" <select>. - When editing actions for a template: - The breadcrumbs menu now reflects that a template is being modified. - The template name has been added as a heading. - A "New action" button appears in the toolbar - The "Edit" and "Delete" links now have a Bootstrap button style. - The add/edit form is now hidden by default. - Clicking "New action" or "edit" shows the add or edit form. - Clicking "Cancel" in the add/edit form hides the form. To test, apply the patch and clear your cache if necessary. - Got to Tools -> MARC modification templates - Test the "New template" button. - Confirm that new template creation works. - Confirm that duplicating a template works. - Test the menu items in the "Actions" menu: - "Duplicate" should trigger the new template modal and preselect the template you chose to duplicate. Confirm that the template is successfully duplicated. - "Delete" should prompt you to confirm the deletion. Test both cancelling and confirming this operation. - "Edit actions" should load the page for adding or editing actions to a template. Test the operations on this page: New action, edit, delete, changing action order. Note that this patch does not fix Bug 15814, so action descriptions must still not contain single quotes. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16148 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16148 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- There is a bug when you click on "edit an action" and then on "new action". I am wondering if we should not display all the actions when there are only 3 buttons and there is not a lot of columns (2 here), to avoid 1 click. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16148 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16148 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16148 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49603|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 51575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51575&action=edit Bug 16148 - Revised layout and behavior of marc modification template management This patch makes changes to the layout and behavior of the marc modification template management page to make it adhere better to common interaction patterns in Koha. - The initial view shows a list of templates rather than pre-selecting the first available template for editing. - A toolbar has been added with a "New template" button. - The initial view of existing templates has an actions menu containing menu items for 'Edit actions,' 'Duplicate,' and 'Delete.' It doesn't appear to be possible to edit an existing template's name. - The "Create template" form is no longer shown all the time. - Clicking the "New template" toolbar button triggers a modal with the form for creating a template. An existing template can be chosen to duplicate. - Choosing "Duplicate" from one of the template menus triggers the "New template" modal and preselects the corresponding template in the "duplicate" <select>. - When editing actions for a template: - The breadcrumbs menu now reflects that a template is being modified. - The template name has been added as a heading. - A "New action" button appears in the toolbar - The "Edit" and "Delete" links now have a Bootstrap button style. - The add/edit form is now hidden by default. - Clicking "New action" or "edit" shows the add or edit form. - Clicking "Cancel" in the add/edit form hides the form. To test, apply the patch and clear your cache if necessary. - Got to Tools -> MARC modification templates - Test the "New template" button. - Confirm that new template creation works. - Confirm that duplicating a template works. - Test the menu items in the "Actions" menu: - "Duplicate" should trigger the new template modal and preselect the template you chose to duplicate. Confirm that the template is successfully duplicated. - "Delete" should prompt you to confirm the deletion. Test both cancelling and confirming this operation. - "Edit actions" should load the page for adding or editing actions to a template. Test the operations on this page: New action, edit, delete, changing action order. Note that this patch does not fix Bug 15814, so action descriptions must still not contain single quotes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16148 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@ptfs-europe.com --- Comment #5 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Patch tested with a sandbox, by Filippos Kolovos <f.kolovos@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16148 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51575|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16148 --- Comment #6 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 51977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51977&action=edit Bug 16148 - Revised layout and behavior of marc modification template management This patch makes changes to the layout and behavior of the marc modification template management page to make it adhere better to common interaction patterns in Koha. - The initial view shows a list of templates rather than pre-selecting the first available template for editing. - A toolbar has been added with a "New template" button. - The initial view of existing templates has an actions menu containing menu items for 'Edit actions,' 'Duplicate,' and 'Delete.' It doesn't appear to be possible to edit an existing template's name. - The "Create template" form is no longer shown all the time. - Clicking the "New template" toolbar button triggers a modal with the form for creating a template. An existing template can be chosen to duplicate. - Choosing "Duplicate" from one of the template menus triggers the "New template" modal and preselects the corresponding template in the "duplicate" <select>. - When editing actions for a template: - The breadcrumbs menu now reflects that a template is being modified. - The template name has been added as a heading. - A "New action" button appears in the toolbar - The "Edit" and "Delete" links now have a Bootstrap button style. - The add/edit form is now hidden by default. - Clicking "New action" or "edit" shows the add or edit form. - Clicking "Cancel" in the add/edit form hides the form. To test, apply the patch and clear your cache if necessary. - Got to Tools -> MARC modification templates - Test the "New template" button. - Confirm that new template creation works. - Confirm that duplicating a template works. - Test the menu items in the "Actions" menu: - "Duplicate" should trigger the new template modal and preselect the template you chose to duplicate. Confirm that the template is successfully duplicated. - "Delete" should prompt you to confirm the deletion. Test both cancelling and confirming this operation. - "Edit actions" should load the page for adding or editing actions to a template. Test the operations on this page: New action, edit, delete, changing action order. Note that this patch does not fix Bug 15814, so action descriptions must still not contain single quotes. Signed-off-by: Filippos Kolovos <f.kolovos@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16148 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Owen, The dropdown list does not select the template when I want to duplicate an existing template. It comes from a JS error (TypeError: document.getElementById(...) is null) raised by marc_modification_templates.js line 2 window.modaction_legend_innerhtml = document.getElementById('modaction_legend').innerHTML; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16148 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 52080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52080&action=edit Bug 16148: Add preventDefault to avoid the scrollbar to move to the top .. when click on buttons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16148 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16148 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 52373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52373&action=edit Bug 16148 [Follow-up] Revised layout and behavior of marc modification template management This follow-up corrects a JavaScript error by using jQuery, which is is more forgiving when selecting elements which may not exist on the page. Also changed: Corrected a duplicate class attribute and fixed a jshint error. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16148 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16148 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51977|0 |1 is obsolete| | Attachment #52080|0 |1 is obsolete| | Attachment #52373|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 52382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52382&action=edit Bug 16148 - Revised layout and behavior of marc modification template management This patch makes changes to the layout and behavior of the marc modification template management page to make it adhere better to common interaction patterns in Koha. - The initial view shows a list of templates rather than pre-selecting the first available template for editing. - A toolbar has been added with a "New template" button. - The initial view of existing templates has an actions menu containing menu items for 'Edit actions,' 'Duplicate,' and 'Delete.' It doesn't appear to be possible to edit an existing template's name. - The "Create template" form is no longer shown all the time. - Clicking the "New template" toolbar button triggers a modal with the form for creating a template. An existing template can be chosen to duplicate. - Choosing "Duplicate" from one of the template menus triggers the "New template" modal and preselects the corresponding template in the "duplicate" <select>. - When editing actions for a template: - The breadcrumbs menu now reflects that a template is being modified. - The template name has been added as a heading. - A "New action" button appears in the toolbar - The "Edit" and "Delete" links now have a Bootstrap button style. - The add/edit form is now hidden by default. - Clicking "New action" or "edit" shows the add or edit form. - Clicking "Cancel" in the add/edit form hides the form. To test, apply the patch and clear your cache if necessary. - Got to Tools -> MARC modification templates - Test the "New template" button. - Confirm that new template creation works. - Confirm that duplicating a template works. - Test the menu items in the "Actions" menu: - "Duplicate" should trigger the new template modal and preselect the template you chose to duplicate. Confirm that the template is successfully duplicated. - "Delete" should prompt you to confirm the deletion. Test both cancelling and confirming this operation. - "Edit actions" should load the page for adding or editing actions to a template. Test the operations on this page: New action, edit, delete, changing action order. Note that this patch does not fix Bug 15814, so action descriptions must still not contain single quotes. Signed-off-by: Filippos Kolovos <f.kolovos@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16148 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 52383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52383&action=edit Bug 16148: Add preventDefault to avoid the scrollbar to move to the top .. when click on buttons Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16148 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 52384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52384&action=edit Bug 16148 [Follow-up] Revised layout and behavior of marc modification template management This follow-up corrects a JavaScript error by using jQuery, which is is more forgiving when selecting elements which may not exist on the page. Also changed: Corrected a duplicate class attribute and fixed a jshint error. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16148 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 52385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52385&action=edit Bug 16148: Fix submit button text The text of the submit button should be init getting the val(), and not the text(). Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16148 --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 52484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52484&action=edit Bug 16148 [Follow-up] - Use Font Awesome for arrows instead of images -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16148 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52484|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 52485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52485&action=edit Bug 16148 [Follow-up] - Use Font Awesome for arrows instead of images -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16148 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52485|0 |1 is obsolete| | --- Comment #16 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 52486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52486&action=edit [SIGNED-OFF] Bug 16148 [Follow-up] - Use Font Awesome for arrows instead of images Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16148 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Owen, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16148 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16793 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16793 [Bug 16793] Use Font Awesome for arrows instead of images in audio_alerts.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16148 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17916 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17916 [Bug 17916] "Delete MARC modification template" fails to actually delete it -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org