[Bug 14829] New: Wrong shortcuts in module "cataloging"
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14829 Bug ID: 14829 Summary: Wrong shortcuts in module "cataloging" Change sponsored?: --- Product: Koha Version: 3.20 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt@gmail.com Reporter: mik@adminkuhn.ch QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl There are three shortcuts or hotkeys in the Koha staff client: * Alt + U = Check out * Alt + R = Check in * Alt + Q = Search the catalog As I understand these shortcuts should work all over the staff client, and mostly they do. In Koha 3.20 though when going to Koha menu "Cataloging" they don't work as expected. Instead here the mapping is: * Alt + U = Search the catalog * Alt + R = Cataloging search * Alt + Q = Check out -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14829 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14829 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 42570 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42570&action=edit Bug 14829: Fix shortcuts in the cataloging and patron modules In these 2 modules, the shortcuts alt+q, alt+r and alt+u don't work as in other modules. The tab are not "built" in the correct order and the id returned to select the correct tab is wrong. Test plan: Go on the circ home page (circ/circulation-home.pl), the patron home page (members/members-home.pl) and the cataloging home page (cataloguing/addbooks.pl). On these 3 pages, without this patch, the shortcuts select different tabs. With this patch, the issue is fixed for all of them. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14829 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |jonathan.druart@bugs.koha-c | |ommunity.org Patch complexity|--- |Trivial patch CC| |jonathan.druart@bugs.koha-c | |ommunity.org Version|3.20 |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14829 Michael Kuhn <mik@adminkuhn.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #2 from Michael Kuhn <mik@adminkuhn.ch> --- I applied the patch manually in the files "cataloging-search.inc" and "patron-search.inc" of directory "/usr/share/koha/intranet/htdocs/intranet-tmpl/prog/de-DE/includes" and the patch works as expected. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14829 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42570|0 |1 is obsolete| | --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 42585 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42585&action=edit Bug 14829: Fix shortcuts in the cataloging and patron modules In these 2 modules, the shortcuts alt+q, alt+r and alt+u don't work as in other modules. The tab are not "built" in the correct order and the id returned to select the correct tab is wrong. Test plan: Go on the circ home page (circ/circulation-home.pl), the patron home page (members/members-home.pl) and the cataloging home page (cataloguing/addbooks.pl). On these 3 pages, without this patch, the shortcuts select different tabs. With this patch, the issue is fixed for all of them. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14829 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz --- Comment #4 from Liz Rea <liz@catalyst.net.nz> --- You might check the serials module tabs as well. :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14829 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Liz Rea from comment #4)
You might check the serials module tabs as well. :)
Yes, it looks good. But, even without this patch :) Why did you say that? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14829 --- Comment #6 from Liz Rea <liz@catalyst.net.nz> --- Because when I was looking at it the other day, it seemed like it was acting weirdly, but I take your word for it that it's ok. :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14829 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14829 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14880 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14829 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14829 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42585|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 42981 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42981&action=edit [PASSED QA] Bug 14829: Fix shortcuts in the cataloging and patron modules In these 2 modules, the shortcuts alt+q, alt+r and alt+u don't work as in other modules. The tab are not "built" in the correct order and the id returned to select the correct tab is wrong. Test plan: Go on the circ home page (circ/circulation-home.pl), the patron home page (members/members-home.pl) and the cataloging home page (cataloguing/addbooks.pl). On these 3 pages, without this patch, the shortcuts select different tabs. With this patch, the issue is fixed for all of them. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14829 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org