http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Test plan: 1) Apply patch 2) Run updatedatabase.pl 3) Enable StoreLastBorrower 4) Issue an item to a patron and return said item 5) Issue the same item to a second patron, do not return it. 6) View moredetail.pl for the given bib, find the given item. There should be a new field in the history list 'Last returned by' with a link to the given borrowernumber. Optionally, you can also verify this works even if patron issuing history has been set to anonymize issues upon return. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13258|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15117 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15117&action=edit Bug 9011 - Add the ability to store the last patron to return an item -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com QA Contact| |paul.poulain@biblibre.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15200|0 |1 is obsolete| | --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 16666 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16666&action=edit Bug 9011 - Add the ability to store the last patron to return an item Currently if the AnonymousPatron system preference is in use, all patron data is anonymized. Some libraries would like to be able to see the last patron who returned out an item ( in case of damage ) but still keep all other patrons anonymized. * Add the field items.last_borrower, foreign key to borrowers.borrowernumber * Add new system preference StoreLastBorrower * If StoreLastBorrower is enabled, upon checkin have Koha set this new field to the patron who last returned this item. * If this new field has a value, link to the patron from the item details page. Test plan: 1) Apply patch 2) Run updatedatabase.pl 3) Enable StoreLastBorrower 4) Issue an item to a patron and return said item 5) Issue the same item to a second patron, do not return it. 6) View moredetail.pl for the given bib, find the given item. There should be a new field in the history list 'Last returned by' with a link to the given borrowernumber. Optionally, you can also verify this works even if patron issuing history has been set to anonymize issues upon return. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16666|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 16763 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16763&action=edit Bug 9011 - Add the ability to store the last patron to return an item Currently if the AnonymousPatron system preference is in use, all patron data is anonymized. Some libraries would like to be able to see the last patron who returned out an item ( in case of damage ) but still keep all other patrons anonymized. * Add the field items.last_borrower, foreign key to borrowers.borrowernumber * Add new system preference StoreLastBorrower * If StoreLastBorrower is enabled, upon checkin have Koha set this new field to the patron who last returned this item. * If this new field has a value, link to the patron from the item details page. Test plan: 1) Apply patch 2) Run updatedatabase.pl 3) Enable StoreLastBorrower 4) Issue an item to a patron and return said item 5) Issue the same item to a second patron, do not return it. 6) View moredetail.pl for the given bib, find the given item. There should be a new field in the history list 'Last returned by' with a link to the given borrowernumber. Optionally, you can also verify this works even if patron issuing history has been set to anonymize issues upon return. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16763|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

You should add a "on delete cascade" option (set null ?) or remove this constraint. It is a dilemma: in one case we loose the information, in other one we loose the constraint :-/ Not cascade, but set null, I don't see the dilemna: with cascade, you delete

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #12 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #11) the item if the borrower is deleted. This is bad :\ -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |srdjan@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #17 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: 1/ The screen is not obvious: Last borrowed:14/08/2013 Last returned by: 23529001223640 Last borrower: 23529001223640 Previous borrower: 23529001223641 The "last returned by" and the "last borrower" is the same value when AnonymousPatron is not in use. 2/ Could you use the template plugin to get the syspref value (rather than to pass it from the pl script). Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 20329 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20329&action=edit Bug 9011 - QA Followup * Use template plugin to get syspref values * Hide "last returned by" if AnonymousPatron is not set -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|paul.poulain@biblibre.com |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20329|0 |1 is obsolete| | --- Comment #21 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 20343 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20343&action=edit Bug 9011 - QA Followup * Use template plugin to get syspref values * Hide "last returned by" if AnonymousPatron is not set Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #23 from Galen Charlton <gmcharlt@gmail.com> --- (In reply to Kyle M Hall from comment #8)

...

3 should we keep the information limitless ? In France, I think it would be illegal, as all libraries must use tools/cleanborrowers.pl. Shouldn't we add an option in this script to remove information after a specific period, even if the patron is still the last borrower ?

This I don't think will work, as the data never expiring what this is all about! This feature is not enabled by default so I don't think that should be a problem, right?

There's a difference between keeping a link to the last borrower for a longer period of time and keeping it forever. Consequently, I agree with Paul's suggestion that cleanborrowers.pl should have an option to clear issues.last_returned_by after a specified amount of time. However, since the new feature is not on by default, I do not consider this a blocker for pushing the patch. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #25 from Galen Charlton <gmcharlt@gmail.com> --- Setting to In Discussion and requesting a response from Jonathan to the question I asked in my previous comment. Broader question: do we really need another field in the items table? Why not just tweak AnonymiseIssueHistory() so that if StoreLastBorrower is set, old_issue rows that are the most recent return for their items are not anonymized? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #27 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Galen Charlton from comment #25)

Setting to In Discussion and requesting a response from Jonathan to the question I asked in my previous comment.

Broader question: do we really need another field in the items table? Why not just tweak AnonymiseIssueHistory() so that if StoreLastBorrower is set, old_issue rows that are the most recent return for their items are not anonymized?

If anonymouspatron is enabled, C4::Circ::MarkIssueReturn can change the borrowernumber with the anonymouspatron value. So the information does not exist in the old_issues table. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20343|0 |1 is obsolete| | --- Comment #29 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 22578 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22578&action=edit Bug 9011 - QA Followup * Use template plugin to get syspref values * Hide "last returned by" if AnonymousPatron is not set Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20344|0 |1 is obsolete| | --- Comment #30 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 22579 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22579&action=edit Bug 9011: Update GPL license Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 jdemuth@roseville.ca.us <jdemuth@roseville.ca.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth@roseville.ca.us -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #32 from Galen Charlton <gmcharlt@gmail.com> --- (In reply to Paul Poulain from comment #31)

I agree that the old_issues information can be removed by anonymisation. But a better option, imho, would be to improve anonymization, to have something like: * anonymize * anonymize except the last patron * don't anonymize

I prefer this approach as well, though I think I've heard of cases where some libraries might want the second option to be "anonymize all except the last N patrons", where N is set by the library. Kyle, Paul, Jonathan: do any of you have the wherewithal to run with that idea for 3.16? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22577|0 |1 is obsolete| | Attachment #22578|0 |1 is obsolete| | Attachment #22579|0 |1 is obsolete| | --- Comment #35 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25866 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25866&action=edit Bug 9011 - Re-engineer circ anonymization, move to subroutine in C4::Circulation -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9303, 11891 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25866|0 |1 is obsolete| | --- Comment #37 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25868 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25868&action=edit Bug 9011 - Re-engineer circ anonymization, move to subroutine in C4::Circulation -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25868|0 |1 is obsolete| | --- Comment #39 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25870 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25870&action=edit Bug 9011 - Re-engineer circ anonymization, move to subroutine in C4::Circulation -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #42 from Kyle M Hall <kyle@bywatersolutions.com> --- This new patch set re-engineers the entire feature. It ditches the new fields and instead simply retains the borrowernumber for the last old_issue for each patron, even if the would have been anonymized. Upon the next return of the item, that patron is then anonymized if the patron's privacy is set to 2. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Brooksml <jerry@brookslibraryvt.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jerry@brookslibraryvt.org -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #45 from Christopher Brannon <cbrannon@cdalibrary.org> --- Kyle, Ran into problems applying this patch to sandbox: The sandbox you've requested is not ready. Some problems occurred applying patches from bug 9011: <h1>Something went wrong !</h1>Applying: Bug 9011 - Re-engineer circ anonymization, move to subroutine in C4::Circulation fatal: sha1 information is lacking or useless (Koha/Schema/Result/OldIssue.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 9011 - Re-engineer circ anonymization, move to subroutine in C4::Circulation When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 9011 - Add the ability to store the last patron to return an item 25870 - Bug 9011 - Re-engineer circ anonymization, move to subroutine in C4::Circulation 25871 - Bug 9011 - Add the ability to store the last patron to return an item 25873 - Bug 9011 - Add support for StoreLastBorrower to AnonymiseIssueHistory Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/Bug-9011---Re-engineer-circ-anonymization-move-to--EetlgO.patch . Christopher -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25871|0 |1 is obsolete| | --- Comment #47 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28924 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28924&action=edit Bug 9011 - Add the ability to store the last patron to return an item -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25873|0 |1 is obsolete| | --- Comment #48 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28925 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28925&action=edit Bug 9011 - Add support for StoreLastBorrower to AnonymiseIssueHistory -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #51 from Nick Clemens <nick@quecheelibrary.org> --- After applying both patches and updating the database the feature seems to work as expected, however, when I log in to any patron account on the opac and click the 'immediate deletion' button under 'your privacy' I get the error: "The deletion of your reading history failed, because there is a problem with the configuration of this feature. Please help to fix the system by informing your library of this error." I double checked my system settings without the patches and immediate deletion works. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #53 from Nick Clemens <nick@quecheelibrary.org> --- I tested again, feature works, immediate deletion works as I think it should with this feature (i.e. Any items where last patron is being kept are not removed from history) but it does seem like when this preference is active there should be an explanation on the general privacy page and in the success message from immediate deletion to explain to the patron why everything may not be cleared even if they have privacy set to 'never' and hit immediate deletion. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|9303 | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29749|0 |1 is obsolete| | --- Comment #56 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29750 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29750&action=edit Bug 9011 [QA Followup 2] - Add message to OPAC * Adds warning to OPAC if StoreLastBorrower is enabled * Updates db revision * Fixes POD error -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29750|0 |1 is obsolete| | --- Comment #58 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29930 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29930&action=edit Bug 9011 [QA Followup 2] - Add message to OPAC * Adds warning to OPAC if StoreLastBorrower is enabled * Updates db revision * Fixes POD error -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #59 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29931 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29931&action=edit Bug 9011 [QA Followup 3] - Update database schema files -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #61 from Nick Clemens <nick@quecheelibrary.org> --- Hi Kyle, I tried to test on a sandbox (3.17.00.009) and am getting Error 500 for any checkins I was going to test on my VM (3.17.00.010) but patch needs rebased for current master -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #62 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Nick Clemens from comment #61)

Hi Kyle,

I tried to test on a sandbox (3.17.00.009) and am getting Error 500 for any checkins

I was going to test on my VM (3.17.00.010) but patch needs rebased for current master

Not sure what's going on, the patches apply to master just fine for me (3.17.00.014). -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #64 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30979 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30979&action=edit Bug 9011 [QA Followup 4] - Add issue_id to issues tables -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28924|0 |1 is obsolete| | --- Comment #67 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 30994 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30994&action=edit [SIGNED OFF] Bug 9011 - Add the ability to store the last patron to return an item Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29301|0 |1 is obsolete| | --- Comment #69 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 30996 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30996&action=edit [SIGNED OFF] Bug 9011 [QA Followup] Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29931|0 |1 is obsolete| | --- Comment #71 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 30998 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30998&action=edit [SIGNED OFF] Bug 9011 [QA Followup 3] - Update database schema files Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #73 from Nick Clemens <nick@quecheelibrary.org> --- I tested with patrons using privacy settings of Forever, Never and Default. In all cases history was stored as expected before enabling StoreLastBorrower and Immediate deletion button worked with no warnings After enabling StoreLastBorrower 'immediate deletion' button offered warning that last returned items would not be deleted. For patrons with privacy set to 'Never', items were anonymised as soon as returned by the next patron. For others, items history was stored until patron clicked 'immediate deletion' The 'Last borrower' link appeared in the items histories and was only anonymised upon return by next patron (for those with privacy 'Never') or upon forced deletion by patrons with other settings. I did have one or two instances of an item getting stuck in history as I changed many settings, but could not recreate the issue purposefully. In all cases either saving patron history again or checking the item out and back in cleared the issue. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #76 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32431 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32431&action=edit Bug 9011 - Add the ability to store the last patron to return an item Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #78 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32433 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32433&action=edit Bug 9011 [QA Followup] Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #80 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32435 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32435&action=edit Bug 9011 [QA Followup 3] - Update database schema files Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32430|0 |1 is obsolete| | Attachment #32431|0 |1 is obsolete| | Attachment #32432|0 |1 is obsolete| | Attachment #32433|0 |1 is obsolete| | Attachment #32434|0 |1 is obsolete| | Attachment #32435|0 |1 is obsolete| | Attachment #32436|0 |1 is obsolete| | --- Comment #82 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32437 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32437&action=edit Bug 9011 - Re-engineer circ anonymization, move to subroutine in C4::Circulation Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #84 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32439 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32439&action=edit Bug 9011 - Add support for StoreLastBorrower to AnonymiseIssueHistory Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #86 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32441 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32441&action=edit Bug 9011 [QA Followup 2] - Add message to OPAC * Adds warning to OPAC if StoreLastBorrower is enabled * Updates db revision * Fixes POD error Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #88 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32443 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32443&action=edit Bug 9011 [QA Followup 4] - Add issue_id to issues tables Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #90 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kyle, I will continue testing for now, but the new tests are failing for me: 1..6 ok 1 - use C4::Circulation; ok 2 - use Koha::Database; Use of uninitialized value in subroutine entry at /home/katrin/kohaclone/C4/Charset.pm line 181. DBD::mysql::st execute failed: Duplicate entry '8' for key 'PRIMARY' at /home/katrin/kohaclone/C4/Circulation.pm line 2073. DBD::mysql::st execute failed: Duplicate entry '8' for key 'PRIMARY' at /home/katrin/kohaclone/C4/Circulation.pm line 2073. # Looks like you planned 6 tests but ran 2. # Looks like your test exited with 255 just after 2. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #92 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I tried it again... restored my database pre-patch, ran the update again, new checkout = issue_id = 4 :( Should have been 27. I have a feeling of de ja vu... didn't we fight this problem on another patch? Looks like bug 9303 is also adding an issue_id. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9303 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #95 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is now blocked by 9303 database update problems. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|13790 |9303 Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32437|0 |1 is obsolete| | Attachment #32438|0 |1 is obsolete| | Attachment #32439|0 |1 is obsolete| | Attachment #32440|0 |1 is obsolete| | Attachment #32441|0 |1 is obsolete| | Attachment #32442|0 |1 is obsolete| | Attachment #32443|0 |1 is obsolete| | Attachment #32977|0 |1 is obsolete| | --- Comment #96 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37113 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37113&action=edit Bug 9011 - Re-engineer circ anonymization, move to subroutine in C4::Circulation Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #98 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37115 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37115&action=edit Bug 9011 - Add support for StoreLastBorrower to AnonymiseIssueHistory Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #100 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37117 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37117&action=edit Bug 9011 [QA Followup 2] - Add message to OPAC * Adds warning to OPAC if StoreLastBorrower is enabled * Updates db revision * Fixes POD error Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #101 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kyle, this doesn't apply on top of 13790 or master: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 9011 - Re-engineer circ anonymization, move to subroutine in C4::Circulation fatal: sha1 information is lacking or useless (Koha/Schema/Result/OldIssue.pm). -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37113|0 |1 is obsolete| | Attachment #37114|0 |1 is obsolete| | Attachment #37115|0 |1 is obsolete| | Attachment #37116|0 |1 is obsolete| | Attachment #37117|0 |1 is obsolete| | --- Comment #102 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38441 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38441&action=edit Bug 9011 - Re-engineer circ anonymization, move to subroutine in C4::Circulation Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #104 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38443 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38443&action=edit Bug 9011 - Add support for StoreLastBorrower to AnonymiseIssueHistory Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #106 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38445 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38445&action=edit Bug 9011 [QA Followup 2] - Add message to OPAC * Adds warning to OPAC if StoreLastBorrower is enabled * Updates db revision * Fixes POD error Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #108 from Jonathan Druart <jonathan.druart@biblibre.com> --- Applying: Bug 9011 - Add the ability to store the last patron to return an item fatal: sha1 information is lacking or useless (C4/Circulation.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 9011 - Add the ability to store the last patron to return an item -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #110 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 39813 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39813&action=edit Bug 9011 - Add the ability to store the last patron to return an item Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #112 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 39815 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39815&action=edit Bug 9011 [QA Followup] Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #117 from Nick Clemens <nick@quecheelibrary.org> --- I tried testing the query as a report on our test system (where old_issues has 3+ years of data for 50+ libraries) and can't get results, report times out. I think the performance concern here is great enough that it's not a feasible method. My vote would be for option B -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #119 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Kyle M Hall from comment #115)

As far as I can tell there is no way around this. I tried to use a left join but you cannot use a group by in an update statement.

Kyle, Just a quick thought: wouldn't it be possible to execute another update statement after the existing one, instead of adding complexity to it? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #122 from Kyle M Hall <kyle.m.hall@gmail.com> --- (In reply to Katrin Fischer from comment #120)

I'd really like to avoid us storing patron related information in the items table and potentially double the information to yet another place. It would be great if more people could take a look here to help figure out if there is a "fast" way of doing this with the existing data.

Katrin, can you explain the justification for not wanting option B aside from the fact that it's storing data in another place? What are your actual concerns about this practice? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #124 from Kyle M Hall <kyle.m.hall@gmail.com> --- (In reply to Katrin Fischer from comment #123)

Basically a big pile of paperwork where I have to document every table that has in any form a connection to patron data and the duplication of the information. Also the possibility that this will leak out into the OPAC with the other item data when someone maps it to a 952 field not thinking about the consequences.

Thanks! I'm not sure we've any way around that. The connection won't be made unless the feature is specifically enabled. Likewise, this data would never be revealed in the opac unless some specifically map the column to a field. To accidentally reveal the data would definitely require jumping through some hoops, but we have no way to absolutely prevent such an occurrence. On the other hand I don't feel that this should be a blocker considering we could do the exact same thing in other areas of Koha. Consider how trivial it would be to create a patrons report and then mark it public? Just because that's possible doesn't mean we stopped the public reports feature from making it into Koha. That being said, I'll defer to your judgement, but someone has to make a decision. Either we go with choice A or choice B. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Heather Braum <hbraum@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum@nekls.org --- Comment #126 from Heather Braum <hbraum@nekls.org> --- I skimmed through the conversation, made it to the bottom, and am pondering Katrin's latest comment. What ABOUT a new table to store this data? That seems to be the simplest solution. Something that is storing the fields id, borrowernumber, itemnumber, date, and "reason" or something like that, where the "reason" field or whatever it could be called is the reason for this data being stored -- "last borrower" in this case. And a field like that could open the door for this table to be used for a few other things. It could be used to store data like the statistics.type fieldd oes, that stores issue, return, renew, localuse data. Could something be written to delete this table for those countries/locations that need to anonymize all patron data, due to privacy concerns/laws; and then leave the data in this table for those libraries that need this data? And this may be way outside the scope of this conversation, but could a new table like this open the door to also be used [after future development] to store (staff) borrower data for tracking items adds/edits/deletes/branch transfers to items, using the above "reason" field? Because while this particular data is stored in the cataloging logs, my system is way too big to keep those logs turned on, and I'd love a way to be able to track that type of data. I propose this additional suggestion, so maybe this table could possibly take on additional uses, other than just the one way to balance privacy differences for those who want to keep last borrower data and anonymize the rest of the data vs those who can't keep any of these data due to local policies and laws. Will be curious to see where this conversation goes. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kim Gnerre <kgnerre@hotchkiss.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kgnerre@hotchkiss.org --- Comment #128 from Kim Gnerre <kgnerre@hotchkiss.org> --- We're just going through the migration process but we currently have that feature with Innovative's Millenium and it is helpful when something is returned damaged or something like a dvd case is returned without the dvd inside. So, speaking for my Access Services Librarian, it would be a feature that we would be interested in having with our KOHA system. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #130 from Nick Clemens <nick@quecheelibrary.org> --- My consortium sponsored this development, and it has taken some time to progress it this far forward. If MySQL performance is the only blocker right now I would really like to see a solution that addresses that and unsticks the bug rather than requiring a rewrite of the feature. I played around with the query and the below, while still containing a NOT IN, eliminates the GROUP BY and improves speed significantly: if ( C4::Context->preference('StoreLastBorrower') ) { # Do not delete the newest old_issue for any itemnumber $query .= " AND issue_id NOT IN ( SELECT issue_id FROM (Select oi.issue_id from old_issues oi LEFT OUTER JOIN old_issues oi2 ON oi.itemnumber=oi2.itemnumber AND oi2.issue_id>oi.issue_id WHERE oi.borrowernumber= ? AND oi2.borrowernumber IS NULL) AS oi ) "; push @bind_params, $borrowernumber; Another option is to just use the query labeleed as 'oi' above in a separate update. It effectively finds all the 'last returned' info for a borrower and would allow you to mark those somehow (say invert borrower number to negative of borrowernumber) then perform the regular anonymizing, and then update any rows with a negative borrowrnumber to a positive borrowernumber (or whatever marker was used) I think Chris's comment #129 has been addressed, the feature is optional (syspref) and gives a big warning to the patron when it is enabled for full transparency. And I don't think sharing your opinion is overstepping :-) If the above queries don't work, a new table could work, though I do wonder about the redundancy. I wonder if it would be possible to use the 'return' column in old_issues to mark 'lastreturned' or something similar to allow for easy SQL selection. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #132 from Chris Rohde <crohde@roseville.ca.us> --- Another point to make is that if a library is using RFID/AMH (Automated Materials Handling), the materials are checked in before anyone has a chance to catch damages. We don't charge for damages, unless an item is completely unusable. However, when items such as a storytime kit go in, it jams the sorter. In our case, we offer the anonymization option to our patrons, to honor their privacy choice. I'd be fine with using a timestamp on the lastpatron table, and a chron job which slides along datewise, deleting returns older than 'x' days. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #134 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Chris Cormack from comment #133)

(In reply to Christopher Davis from comment #129)

...

Dear Colleagues,

I am new to Bugzilla, so I hope that this comment will not overstep my bounds. In my opinion, this bug is a slippery slope on the mountain of professional ethics. I would rather error on the side of patron privacy and confidentiality than I would on the side of trying to recuperate lost or damaged items. If we say that we anonymize patron data, then we should go all the way without exception.

I agree with this, I think we should be aiming to have Koha being the most privacy respecting system that exists. And that we should treat privacy issues like we treat security ones. They are the same thing.

It should not be Koha's job to enforce privacy rules. Rules come and go, and vary from place to place. It should be a system preference, not something forced by the system. Koha needs to be able to handle multiple scenarios. Christopher -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #136 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Nick Clemens from comment #130)

My consortium sponsored this development, and it has taken some time to progress it this far forward. If MySQL performance is the only blocker right now I would really like to see a solution that addresses that and unsticks the bug rather than requiring a rewrite of the feature.

I played around with the query and the below, while still containing a NOT IN, eliminates the GROUP BY and improves speed significantly: if ( C4::Context->preference('StoreLastBorrower') ) { # Do not delete the newest old_issue for any itemnumber $query .= " AND issue_id NOT IN ( SELECT issue_id FROM (Select oi.issue_id from old_issues oi LEFT OUTER JOIN old_issues oi2 ON oi.itemnumber=oi2.itemnumber AND oi2.issue_id>oi.issue_id WHERE oi.borrowernumber= ? AND oi2.borrowernumber IS NULL) AS oi ) "; push @bind_params, $borrowernumber;

I haven't tested if this works, but I am hopeful it does and improves speed.

Another option is to just use the query labeleed as 'oi' above in a separate update. It effectively finds all the 'last returned' info for a borrower and would allow you to mark those somehow (say invert borrower number to negative of borrowernumber) then perform the regular anonymizing, and then update any rows with a negative borrowrnumber to a positive borrowernumber (or whatever marker was used)

This seems a bit hacky... but doesn't mean it couldn't work.

If the above queries don't work, a new table could work, though I do wonder about the redundancy. I wonder if it would be possible to use the 'return' column in old_issues to mark 'lastreturned' or something similar to allow for easy SQL selection.

Hm not sure how the return could be used - can you explain? Kyle, could you take a look at these options? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #137 from Kyle M Hall <kyle.m.hall@gmail.com> --- I like this idea, but I think it won't work because it requires the borrowernumber to be known. Because of that, the last item checked out will not be retained if a library were to run misc/cronjobs/batch_anonymise.pl or tools/cleanborrowers.pl (In reply to Nick Clemens from comment #130)

My consortium sponsored this development, and it has taken some time to progress it this far forward. If MySQL performance is the only blocker right now I would really like to see a solution that addresses that and unsticks the bug rather than requiring a rewrite of the feature.

I played around with the query and the below, while still containing a NOT IN, eliminates the GROUP BY and improves speed significantly: if ( C4::Context->preference('StoreLastBorrower') ) { # Do not delete the newest old_issue for any itemnumber $query .= " AND issue_id NOT IN ( SELECT issue_id FROM (Select oi.issue_id from old_issues oi LEFT OUTER JOIN old_issues oi2 ON oi.itemnumber=oi2.itemnumber AND oi2.issue_id>oi.issue_id WHERE oi.borrowernumber= ? AND oi2.borrowernumber IS NULL) AS oi ) "; push @bind_params, $borrowernumber;

Another option is to just use the query labeleed as 'oi' above in a separate update. It effectively finds all the 'last returned' info for a borrower and would allow you to mark those somehow (say invert borrower number to negative of borrowernumber) then perform the regular anonymizing, and then update any rows with a negative borrowrnumber to a positive borrowernumber (or whatever marker was used)

I think Chris's comment #129 has been addressed, the feature is optional (syspref) and gives a big warning to the patron when it is enabled for full transparency. And I don't think sharing your opinion is overstepping :-)

If the above queries don't work, a new table could work, though I do wonder about the redundancy. I wonder if it would be possible to use the 'return' column in old_issues to mark 'lastreturned' or something similar to allow for easy SQL selection.

-- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #139 from Kyle M Hall <kyle.m.hall@gmail.com> --- I've moved this to a fresh bug for the new implementation that uses a separate table to track the last patron to return an item. -- You are receiving this mail because: You are watching all bug changes.