[Bug 24340] New: We ought to be able to disable SIP using koha-sip
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340 Bug ID: 24340 Summary: We ought to be able to disable SIP using koha-sip Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: wizzyrea@gmail.com QA Contact: testopia@bugs.koha-community.org CC: robin@catalyst.net.nz We ought to be able to disable SIP with koha-sip --disable inst At minimum, disabling SIP should - Stop running SIP services for that instance - back up the latest existent SIPconfig, and remove the SIPconfig.xml from /etc/koha/sites/inst/ so that it can't start. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340 --- Comment #1 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 96797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96797&action=edit Bug 24340: allow koha-sip --disable inst To test: - Enable sip for your testing instance sudo koha-sip --enable inst - Start sip for your testing instance sudo koha-sip --start inst - Verify it is running ps ax |grep sip -> you should see processes - Disable sip for your testing intance sudo koha-sip --disable inst - Verify that the following has happened: * the SIPconfig.xml file has been moved to SIPconfig.xml.bak * SIP is no longer running for your instance - no SIP processes * SIP Cannot be started for the instance because of no config. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #2 from Liz Rea <wizzyrea@gmail.com> --- Another feature that would be neat, but that I probably won't do for this patch, is the ability to re-enable from a backed up config, if it exists. I don't know why someone would want to do that, but we're keeping a backup so why not allow it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96797|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 96813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96813&action=edit Bug 24340: allow koha-sip --disable inst To test: - Enable sip for your testing instance sudo koha-sip --enable inst - Start sip for your testing instance sudo koha-sip --start inst - Verify it is running ps ax |grep sip -> you should see processes - Disable sip for your testing intance sudo koha-sip --disable inst - Verify that the following has happened: * the SIPconfig.xml file has been moved to SIPconfig.xml.bak * SIP is no longer running for your instance - no SIP processes * SIP Cannot be started for the instance because of no config. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- Hi Liz. I've signed this off, but I think the debian/docs/koha-sip.xml file needs updating so that the option is listed in the man page for the package command. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340 --- Comment #5 from David Nind <david@davidnind.com> --- Notes for those testing using koha-testing-docker. After applying the patch the change to the script isn't recognised, and I get an error message when using the disable option: Error: invalid option switch (--disable) I had to restart the environment (CTRL-C, then kd, then ku to bring up a fresh instance) as restart_all and flush_memcached didn't seem to work to recognise the script change. koha-testing-docker has SIP enabled by default so before you test you may want to stop SIP (koha-sip --stop kohadev) and delete the /etc/koha/sites/kohadev/SIPconfig.xml file. Also, on koha-testing-docker the instance name is kohadev. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340 --- Comment #6 from Liz Rea <wizzyrea@gmail.com> --- (In reply to David Nind from comment #4)
Hi Liz. I've signed this off, but I think the debian/docs/koha-sip.xml file needs updating so that the option is listed in the man page for the package command.
good point, I'll make a patch for that. :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |liz@catalyst.net.nz |ity.org | CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- 209 echo "Warning: SIP server disabled for ${name}" Do we really want to display a warning if what has been asked has been done successfully? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340 --- Comment #8 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 97360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97360&action=edit Bug 24340 (follow-up): Warning -> Information -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340 --- Comment #9 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 97361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97361&action=edit Bug 24340 (follow-up): Add documentation to debian/docs/koha-sip.xml -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96813|0 |1 is obsolete| | --- Comment #10 from David Nind <david@davidnind.com> --- Created attachment 97379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97379&action=edit Bug 24340: allow koha-sip --disable inst To test: - Enable sip for your testing instance sudo koha-sip --enable inst - Start sip for your testing instance sudo koha-sip --start inst - Verify it is running ps ax |grep sip -> you should see processes - Disable sip for your testing intance sudo koha-sip --disable inst - Verify that the following has happened: * the SIPconfig.xml file has been moved to SIPconfig.xml.bak * SIP is no longer running for your instance - no SIP processes * SIP Cannot be started for the instance because of no config. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97360|0 |1 is obsolete| | --- Comment #11 from David Nind <david@davidnind.com> --- Created attachment 97380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97380&action=edit Bug 24340 (follow-up): Warning -> Information Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97361|0 |1 is obsolete| | --- Comment #12 from David Nind <david@davidnind.com> --- Created attachment 97381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97381&action=edit Bug 24340 (follow-up): Add documentation to debian/docs/koha-sip.xml Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- My feeling is we should go the koha-email-enable/disable way, and have a file in /var/lib/koha/<instance>/sip.enabled instead of relaying on the SIPConfig.xml file for making the decision. Touching the config file looks overkill to me. I agree it could be part of enabling, if there is no config. Probably with --force-create-config or similar. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97379|0 |1 is obsolete| | Attachment #97380|0 |1 is obsolete| | Attachment #97381|0 |1 is obsolete| | --- Comment #14 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 98257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98257&action=edit Bug 24340: allow koha-sip --disable inst To test: - Enable sip for your testing instance sudo koha-sip --enable inst - Start sip for your testing instance sudo koha-sip --start inst - Verify it is running ps ax |grep sip -> you should see processes - Disable sip for your testing intance sudo koha-sip --disable inst - Verify that the following has happened: * SIP is no longer running for your instance - no SIP processes * SIP Cannot be started for the instance because it is not enabled. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98257|0 |1 is obsolete| | --- Comment #15 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 98258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98258&action=edit Bug 24340: allow koha-sip --disable inst To test: - Enable sip for your testing instance sudo koha-sip --enable inst - Start sip for your testing instance sudo koha-sip --start inst - Verify it is running ps ax |grep sip -> you should see processes - Disable sip for your testing intance sudo koha-sip --disable inst - Verify that the following has happened: * SIP is no longer running for your instance - no SIP processes * SIP Cannot be started for the instance because it is not enabled. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98258|0 |1 is obsolete| | --- Comment #16 from David Nind <david@davidnind.com> --- Created attachment 98263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98263&action=edit Bug 24340: allow koha-sip --disable inst To test: - Enable sip for your testing instance sudo koha-sip --enable inst - Start sip for your testing instance sudo koha-sip --start inst - Verify it is running ps ax |grep sip -> you should see processes - Disable sip for your testing intance sudo koha-sip --disable inst - Verify that the following has happened: * SIP is no longer running for your instance - no SIP processes * SIP Cannot be started for the instance because it is not enabled. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Does it make sense to display the "edit ... to configure" part each time? "Enabling SIP server for kohadev - edit /etc/koha/sites/kohadev/SIPconfig.xml to configure" I think "This is the first time SIP has been enabled. Please check the configurations in /etc/koha/sites/${name}/SIPconfig.xml" is enough. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340 --- Comment #18 from Liz Rea <wizzyrea@gmail.com> --- is it harmful? Just because you know what to do, doesn't mean everyone does, and the reminder can be useful when you don't do it often. I'm not keen to remove it, but I won't block a follow up doing so. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340 --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I think it's confusing to tell "edit to configure" when it is already supposed to be configured. Letting RM to decide. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98263|0 |1 is obsolete| | --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98716&action=edit Bug 24340: allow koha-sip --disable inst To test: - Enable sip for your testing instance sudo koha-sip --enable inst - Start sip for your testing instance sudo koha-sip --start inst - Verify it is running ps ax |grep sip -> you should see processes - Disable sip for your testing intance sudo koha-sip --disable inst - Verify that the following has happened: * SIP is no longer running for your instance - no SIP processes * SIP Cannot be started for the instance because it is not enabled. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I think it's OK having the reminder of where the config file is.. we can certainly revisit it at a future date if we decide it's superflous. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340 --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds release notes| |--enable and --disable | |options to the koha-sip | |Debian package command. | | | |Usage: | |- koha-sip --enable | |instancename => Enables the | |Koha SIP server | |- koha-sip | |--disable instancename => | |Disables and stops the Koha | |SIP server -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED --- Comment #23 from Joy Nelson <joy@bywatersolutions.com> --- Enhancement not pushed to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|We ought to be able to |Add ability to disable SIP |disable SIP using koha-sip |using koha-sip -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27355 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27355 [Bug 27355] Missing sip.enabled after upgrade to 20.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org