https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40791 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30515 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 [Bug 30515] Move Overdue transports to patron messaging preferences -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40791 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 186799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186799&action=edit Bug 40791: Allow choice of which Overdue messages can be patron preferences In Bug 30515, we are discussing adding a new system preference UsePatronPreferencesForOverdueNotices to let patrons control which overdue messages are sent by mail in their messaging preferences. For many libraries it would still be necessary to set a certain overdue notice (say the third overdue notice) as "mandatory for print message". On this patch we reuse the aforementioned pref and make it multivaluated with 3 values possible: Overdue1, Overdue2 and Overdue 3. Then: - if at least one is selected then patrons can edit it/them - if none selected, we don't allow the patrons to modify any Test plan: Select 2 values of the pref and confirm that it does not appear from the messaging form (staff and opac) Run the cronjob script and confirm that the patron's preferences are taken into account for the 2 values you selected. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40791 --- Comment #2 from Philip Orr <philip.orr@lmscloud.de> --- After applying the patch, "updatedatabase" warns: Use of uninitialized value $type in string ne at /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_40791.pl line 13. Don't know if that's important. QA passes with no fails. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40791 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186799|0 |1 is obsolete| | --- Comment #3 from Philip Orr <philip.orr@lmscloud.de> --- Created attachment 187245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187245&action=edit Bug 40791: Allow choice of which Overdue messages can be patron preferences In Bug 30515, we are discussing adding a new system preference UsePatronPreferencesForOverdueNotices to let patrons control which overdue messages are sent by mail in their messaging preferences. For many libraries it would still be necessary to set a certain overdue notice (say the third overdue notice) as "mandatory for print message". On this patch we reuse the aforementioned pref and make it multivaluated with 3 values possible: Overdue1, Overdue2 and Overdue 3. Then: - if at least one is selected then patrons can edit it/them - if none selected, we don't allow the patrons to modify any Test plan: Select 2 values of the pref and confirm that it does not appear from the messaging form (staff and opac) Run the cronjob script and confirm that the patron's preferences are taken into account for the 2 values you selected. Signed-off-by: Philip Orr <philip.orr@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40791 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Philip Orr from comment #2)

After applying the patch, "updatedatabase" warns:

Use of uninitialized value $type in string ne at /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_40791.pl line 13.

Don't know if that's important. QA passes with no fails.

Hum I don't see this warning. It means that "type" for UsePatronPreferencesForOverdueNotices in not defined. It is supposed to be "YesNo". It could happen if this db rev is run before the one from 30515, but it should not happen as they are run in order. Koha/Installer.pm 75 my $update_dir = $intranetdir . '/installer/data/mysql/atomicupdate/'; 76 opendir( my $dirh, $update_dir ); 77 my @stuff = sort readdir $dirh; -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40791 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Signed Off |In Discussion --- Comment #6 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- This is in opposition to the rewrite of overdue triggers which moves toward an arbitrary number of overdue notices. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 Is there a way we could handle that and combine these two? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40791 --- Comment #9 from Philip Orr <philip.orr@lmscloud.de> --- We (meaning Chloe, Jonathan and I) discussed this bug today at KohaCon2026. As overdue triggers have been moved to the circulation rules page in 10190, I suggest adding a checkbox in the "Edit notice for trigger.." section in the new overdue triggers configuration. The checkbox should be something like "Allow patron to choose their preferred transport type" or something similar. I've added a screenshot to this patch as an example of what that would look like (checkbox_overdue_preferences.png). Then if the box is checked: - Send the overdue message with the transport type the patron has selected - In the patron extended messaging preferences section, show a new value (the name of the overdue message chosen in the trigger in the configuration) and only "Email" box. Again I've added a screenshot to show a little better what I mean. If multiple overdue notice triggers have been checked for "allow patron to choose their preferred transport type" then there should also be corresponding multiple new rows in the messaging preferences. If the patron has not checked "Email" (that is the checkbox in messaging preferences is empty) then it should be a letter version. Or maybe the transport type set up by the library in the overdue trigger configuration should be used instead as the "default value", in case the library maybe wants to send SMS or other transport types. I think this approach should also allow us to mark bug 30515 as closed, as it would no longer be needed to set that in a system preference. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40791 --- Comment #11 from Philip Orr <philip.orr@lmscloud.de> --- Created attachment 207362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207362&action=edit Screenshot to show where a new row would be added to messaging preferences -- You are receiving this mail because: You are watching all bug changes.