[Bug 30515] New: Move Overdue transports to patron messaging preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 Bug ID: 30515 Summary: Move Overdue transports to patron messaging preferences Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com The idea of this bug would be to allow patrons to choose which format they would like to receive their overdues in while maintaining at least one selection as mandatory -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au, | |jonathan.druart+koha@gmail. | |com, | |joy@bywatersolutions.com, | |julian.maurice@biblibre.com | |, katrin.fischer@bsz-bw.de, | |m.de.rooy@rijksmuseum.nl, | |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Some libraries need to send the third notice as print or even all of them. I like the idea of having at least one mandatory, so you can't opt out, but could we also have an option to not have it appear in the messaging preferences? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Do you mean an option to not have a given transport appear in preferences? Or an option to not show preferences for ODUE2, and only ODUE1? I think we envisioned a single preference for overdues - the triggers still controlling which ones we send -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I'd like an option to not have the overdue notices appear at all or only as read only. I think a single preference for all overdues notice levels would not work without regressions. At the moment you can set the transport preferences in staff individually for each notice and can even opt to have multiple transports for each (send by email AND print). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 --- Comment #4 from Joy Nelson <joy@bywatersolutions.com> --- Katrin, and all other interested parties! We have written the following brief proposal below. This proposal provides an option for libraries to allow patrons to select preferences for their overdue messages. We are looking to balance the patron's ability to set a preference with the library's ability to control messaging related to overdues. We appreciate everyone's feedback on this proposal: Add two checkboxes to each transport type in the Overdue Triggers matrix. 1. Enabled: Will the library send a notice in this transport type? 2. Mandatory: When checked, this transport is the way that this message is sent. (multiple transport types can be selected) Patron preferences will be ignored in favor of the transport the library has indicated as mandatory. Add matrix of Overdue Message Preferences in the Patron Message Preference screen. The matrix will contain the 3 Overdue messages (odue1,odue2,odue3) and patrons will be able to indicate their preferences for receiving these messages. This matrix will appear on opac and staff side depending on EnhancedMessage System Preference. Add an additional System preference to control whether patron can edit the Overdue messaging preferences. If enabled -- Show a BOLD message that they can choose their preferences but library policies may override their choice (see Mandatory above) Patrons will be forced to select at least one transport type. If disabled -- Show a read only matrix of the patron's libraries (or default) transport types that are set in Overdue triggers and a note that other library policies may override the patron's libraries settings. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh@dubcolib.org --- Comment #5 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- (In reply to Joy Nelson from comment #4)
Katrin, and all other interested parties! We have written the following brief proposal below. This proposal provides an option for libraries to allow patrons to select preferences for their overdue messages. We are looking to balance the patron's ability to set a preference with the library's ability to control messaging related to overdues.
We appreciate everyone's feedback on this proposal:
Add two checkboxes to each transport type in the Overdue Triggers matrix. 1. Enabled: Will the library send a notice in this transport type? 2. Mandatory: When checked, this transport is the way that this message is sent. (multiple transport types can be selected) Patron preferences will be ignored in favor of the transport the library has indicated as mandatory.
Add matrix of Overdue Message Preferences in the Patron Message Preference screen. The matrix will contain the 3 Overdue messages (odue1,odue2,odue3) and patrons will be able to indicate their preferences for receiving these messages. This matrix will appear on opac and staff side depending on EnhancedMessage System Preference.
Add an additional System preference to control whether patron can edit the Overdue messaging preferences. If enabled -- Show a BOLD message that they can choose their preferences but library policies may override their choice (see Mandatory above) Patrons will be forced to select at least one transport type. If disabled -- Show a read only matrix of the patron's libraries (or default) transport types that are set in Overdue triggers and a note that other library policies may override the patron's libraries settings.
This sounds like a good balance of flexibility and control! +1 and then +1 again for good measure :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I don't think we should hardcode the 3 codes. It will make harder to improve this area (like bug 12771). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12771 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think the last bit about the display in the OPAC could maybe be simplified, but I like the optional/mandatory approach. Right now the notices are hardcoded to 3 levels, we could try to make the code more flexible, but it feels like it might things more complex while there is no development on bug 12771. Maybe easier to do it once it's actually required. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33459 CC| |cbrannon@cdalibrary.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36006 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |glasklas@gmail.com --- Comment #8 from David Gustafsson <glasklas@gmail.com> --- I'm currently going through our local branches that has not yet been submitted to bugzilla, and we have an implementation for enabling per patron overdue notice messaging preference. This was added before taking part of any of the discussion here and attaching it as is. With regards to the print behavior we added a setting to select whether to always print, print if no other transport is set, or never print. A third possible option could be to fallback to the print setting for the patron category and library. I'm not to familiar with how much flexibility is needed for printing, and the third option seems a little bit overkill, but if there is a use case it could be added. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 --- Comment #9 from David Gustafsson <glasklas@gmail.com> --- Created attachment 163564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163564&action=edit Fetch patron specific message preferences for overdue messages and use them instead of patron category level preferences -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163564|0 |1 is obsolete| | --- Comment #10 from David Gustafsson <glasklas@gmail.com> --- Created attachment 163573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163573&action=edit Bug 30515: Move Overdue transports to patron messaging preferences Add syspref for using patron specific message preferences for overdue messages instead of patron category level preferences. To test: 1) Set UsePatronPreferencesForOverdueNotices "individual patron preference" 2) Enable some transport for a patron in the messaging preferences form 2) Check out an item and set a due date that will result in an overdue notice 4) Run the overdue_notices.pl script 5) Verify that messages has been sent for the selected transport(s) 6) Run gather_print_notices.pl and verify a print notice is generated 7) Set UsePatronPreferencesForOverdueNotices to "when no other transport set" 8) Run the overdue_notices.pl and gather_print_notices.pl and verify that no print notice is generated 9) Disable all transports for the patron 10) Run the overdue_notices.pl and gather_print_notices.pl and verify that print notice is generated 11) Set UsePatronPreferencesForOverdueNotices to "never" 12) Run the overdue_notices.pl and gather_print_notices.pl and verify that no print notice is generated 13) Enable some transport(s) for the patron 14) Run the overdue_notices.pl and gather_print_notices.pl and verify that no print notice is generated Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163573|0 |1 is obsolete| | --- Comment #11 from David Gustafsson <glasklas@gmail.com> --- Created attachment 163574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163574&action=edit Bug 30515: Move Overdue transports to patron messaging preferences Add syspref for using patron specific message preferences for overdue messages instead of patron category level preferences. To test: 1) Set UsePatronPreferencesForOverdueNotices to "individual patron preference" 2) Enable some transport for a patron in the messaging preferences form 2) Check out an item and set a due date that will result in an overdue notice 4) Run the overdue_notices.pl script 5) Verify that messages has been sent for the selected transport(s) 6) Run gather_print_notices.pl and verify a print notice is generated 7) Set UsePatronPreferencesForOverdueNotices to "when no other transport set" 8) Run the overdue_notices.pl and gather_print_notices.pl and verify that no print notice is generated 9) Disable all transports for the patron 10) Run the overdue_notices.pl and gather_print_notices.pl and verify that print notice is generated 11) Set UsePatronPreferencesForOverdueNotices to "never" 12) Run the overdue_notices.pl and gather_print_notices.pl and verify that no print notice is generated 13) Enable some transport(s) for the patron 14) Run the overdue_notices.pl and gather_print_notices.pl and verify that no print notice is generated 15) Set UsePatronPreferencesForOverdueNotices to "patron category" 16) Run the overdue_notices.pl and gather_print_notices.pl and verify the patron category and library setting is used Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |glasklas@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 koha-US bug tracker <bugzilla@koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla@koha-us.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- Looks promising. With this patch applied and UsePatronPreferencesForOverdueNotices set to "individual patron preference" I do not see the Overdue messaging preferences on the patron form. Maybe GetMessagingOptions (C4/Members/Messaging.pm) needs to be updated so it can retrieve Overdue1, Overdue2, and Overdue3? Thanks for working on this! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163574|0 |1 is obsolete| | --- Comment #13 from David Gustafsson <glasklas@gmail.com> --- Created attachment 178276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178276&action=edit Bug 30515: Move Overdue transports to patron messaging preferences Add syspref for using patron specific message preferences for overdue messages instead of patron category level preferences. To test: 1) Set UsePatronPreferencesForOverdueNotices to "individual patron preference" 2) Enable some transport for a patron in the messaging preferences form 2) Check out an item and set a due date that will result in an overdue notice 4) Run the overdue_notices.pl script 5) Verify that messages has been sent for the selected transport(s) 6) Run gather_print_notices.pl and verify a print notice is generated 7) Set UsePatronPreferencesForOverdueNotices to "when no other transport set" 8) Run the overdue_notices.pl and gather_print_notices.pl and verify that no print notice is generated 9) Disable all transports for the patron 10) Run the overdue_notices.pl and gather_print_notices.pl and verify that print notice is generated 11) Set UsePatronPreferencesForOverdueNotices to "never" 12) Run the overdue_notices.pl and gather_print_notices.pl and verify that no print notice is generated 13) Enable some transport(s) for the patron 14) Run the overdue_notices.pl and gather_print_notices.pl and verify that no print notice is generated 15) Set UsePatronPreferencesForOverdueNotices to "patron category" 16) Run the overdue_notices.pl and gather_print_notices.pl and verify the patron category and library setting is used Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 --- Comment #14 from David Gustafsson <glasklas@gmail.com> --- (In reply to Lucas Gass (lukeg) from comment #12)
Looks promising.
With this patch applied and UsePatronPreferencesForOverdueNotices set to "individual patron preference" I do not see the Overdue messaging preferences on the patron form.
Maybe GetMessagingOptions (C4/Members/Messaging.pm) needs to be updated so it can retrieve Overdue1, Overdue2, and Overdue3?
Thanks for working on this!
Thanks for the feedback, it was a while since I had a look at this so spontaneously don't know what the issue could be, but I will try too look into to it and have a look at your suggestion. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178276|0 |1 is obsolete| | --- Comment #15 from David Gustafsson <glasklas@gmail.com> --- Created attachment 178548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178548&action=edit Bug 30515: Move Overdue transports to patron messaging preferences Add syspref for using patron specific message preferences for overdue messages instead of patron category level preferences. To test: 1) Set UsePatronPreferencesForOverdueNotices to "individual patron preference" 2) Enable some transport for a patron in the messaging preferences form 2) Check out an item and set a due date that will result in an overdue notice 4) Run the overdue_notices.pl script 5) Verify that messages has been sent for the selected transport(s) 6) Run gather_print_notices.pl and verify a print notice is generated 7) Set UsePatronPreferencesForOverdueNotices to "when no other transport set" 8) Run the overdue_notices.pl and gather_print_notices.pl and verify that no print notice is generated 9) Disable all transports for the patron 10) Run the overdue_notices.pl and gather_print_notices.pl and verify that print notice is generated 11) Set UsePatronPreferencesForOverdueNotices to "never" 12) Run the overdue_notices.pl and gather_print_notices.pl and verify that no print notice is generated 13) Enable some transport(s) for the patron 14) Run the overdue_notices.pl and gather_print_notices.pl and verify that no print notice is generated 15) Set UsePatronPreferencesForOverdueNotices to "patron category" 16) Run the overdue_notices.pl and gather_print_notices.pl and verify the patron category and library setting is used Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 --- Comment #16 from David Gustafsson <glasklas@gmail.com> --- Created attachment 178549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178549&action=edit Bug 30515: Fix messaging options order and add database changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #17 from David Gustafsson <glasklas@gmail.com> --- The issue was there was some entries in message_transports and message_attributes missing that I guess for hour installation we have added manually without including in the patch, now added to atomic update. Database entries also needed to be added to sample_notices_message_attributes.sql and sample_notices_message_transports.sql. The patch assumes there exists ODUE2 and ODUE3, so added default samples in sample_notices.yml. The content is equivalent to ODUE, except I added "This is the second reminder", and "This is the third reminder" suggestions are welcome if it should differ in some other way. Order for Overdue1, Overdue2, and Overdue3 is now also set in GetMessagingOptions, so the preferences are listed in the correct order. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178549|0 |1 is obsolete| | --- Comment #18 from David Gustafsson <glasklas@gmail.com> --- Created attachment 178550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178550&action=edit Bug 30515: Fix messaging options order and add database changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 --- Comment #19 from David Gustafsson <glasklas@gmail.com> --- (In reply to David Gustafsson from comment #17)
The issue was there was some entries in message_transports and message_attributes missing that I guess for hour installation we have added manually without including in the patch, now added to atomic update. Database entries also needed to be added to sample_notices_message_attributes.sql and sample_notices_message_transports.sql.
The patch assumes there exists ODUE2 and ODUE3, so added default samples in sample_notices.yml. The content is equivalent to ODUE, except I added "This is the second reminder", and "This is the third reminder" suggestions are welcome if it should differ in some other way.
Order for Overdue1, Overdue2, and Overdue3 is now also set in GetMessagingOptions, so the preferences are listed in the correct order.
Mistyped, should be "This is the final reminder". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philip.orr@lmscloud.de Status|Needs Signoff |Patch doesn't apply --- Comment #20 from Philip Orr <philip.orr@lmscloud.de> --- Seems it doesn't apply: Using index info to reconstruct a base tree... M C4/Members/Messaging.pm M installer/data/mysql/en/mandatory/sample_notices.yml Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/en/mandatory/sample_notices.yml CONFLICT (content): Merge conflict in installer/data/mysql/en/mandatory/sample_notices.yml Removing installer/data/mysql/atomicupdate/bug_30515-add_system_preferences.pl Auto-merging C4/Members/Messaging.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 30515: Fix messaging options order and add database changes Happy to sign off if you rebase :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178548|0 |1 is obsolete| | --- Comment #21 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 186143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186143&action=edit Bug 30515: Move Overdue transports to patron messaging preferences Add syspref for using patron specific message preferences for overdue messages instead of patron category level preferences. To test: 1) Set UsePatronPreferencesForOverdueNotices to "individual patron preference" 2) Enable some transport for a patron in the messaging preferences form 2) Check out an item and set a due date that will result in an overdue notice 4) Run the overdue_notices.pl script 5) Verify that messages has been sent for the selected transport(s) 6) Run gather_print_notices.pl and verify a print notice is generated 7) Set UsePatronPreferencesForOverdueNotices to "when no other transport set" 8) Run the overdue_notices.pl and gather_print_notices.pl and verify that no print notice is generated 9) Disable all transports for the patron 10) Run the overdue_notices.pl and gather_print_notices.pl and verify that print notice is generated 11) Set UsePatronPreferencesForOverdueNotices to "never" 12) Run the overdue_notices.pl and gather_print_notices.pl and verify that no print notice is generated 13) Enable some transport(s) for the patron 14) Run the overdue_notices.pl and gather_print_notices.pl and verify that no print notice is generated 15) Set UsePatronPreferencesForOverdueNotices to "patron category" 16) Run the overdue_notices.pl and gather_print_notices.pl and verify the patron category and library setting is used Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178550|0 |1 is obsolete| | --- Comment #22 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 186144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186144&action=edit Bug 30515: Fix messaging options order and add database changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186144|0 |1 is obsolete| | --- Comment #23 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 186145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186145&action=edit Bug 30515: Fix messaging options order and add database changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 --- Comment #24 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 186146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186146&action=edit Bug 30515: (follow-up) Fix messaging options order and add database changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 --- Comment #25 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 186147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186147&action=edit Bug 30515: Fix OPAC form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 --- Comment #26 from Jonathan Druart <jonathan.druart@gmail.com> --- Patches rebased and added a couple of bug fixes, so Philip can test :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 --- Comment #27 from Philip Orr <philip.orr@lmscloud.de> --- Thanks joubu! Running "qa" gives the following result: Result: [PASS] C4/Members/Messaging.pm [FAIL] installer/data/mysql/atomicupdate/bug_30515-add_system_preferences.pl FAIL git_manipulation The file has been added and deleted or renamed in the same patchset [FAIL] installer/data/mysql/atomicupdate/bug_30515-move_overdue_transports_to_patron_messaging_preferences.pl FAIL file_permissions File must have the exec flag FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl installer/data/mysql/atomicupdate/bug_30515-move_overdue_transports_to_patron_messaging_preferences.pl` [PASS] installer/data/mysql/en/mandatory/sample_notices.yml [PASS] installer/data/mysql/mandatory/sample_notices_message_attributes.sql [PASS] installer/data/mysql/mandatory/sample_notices_message_transports.sql [PASS] installer/data/mysql/mandatory/sysprefs.sql [PASS] koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc [PASS] koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt [PASS] koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref [PASS] koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt [FAIL] misc/cronjobs/overdue_notices.pl FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl misc/cronjobs/overdue_notices.pl` Processing additional checks PASS! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 --- Comment #28 from Philip Orr <philip.orr@lmscloud.de> --- After applying the patch and setting the new syspref UsePatronPreferencesForOverdueNotices to "individual patron preference", I'm not seeing any new choices in my test patron's messaging preferences.. am I doing something wrong? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 --- Comment #29 from Philip Orr <philip.orr@lmscloud.de> --- Oops, never mind: I simply forgot to updatedatabase and restart_all. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 --- Comment #30 from Philip Orr <philip.orr@lmscloud.de> --- At step 4), when running overdue_notices.pl, I get the following error: Undefined subroutine &main::GetMessagingPreferences called at overdue_notices.pl line 753. I was testing to see what happens when a patron sets the preferences to "Email" but forgets to actually provide their email address (that is, leaves all their email fields empty). But I get the error no matter if there is an address defined or not, so I don't think it's related to that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 --- Comment #31 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 186258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186258&action=edit Bug 30515: fix GetMessagingPreferences call It's not exported -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 --- Comment #32 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Philip Orr from comment #27)
Thanks joubu! Running "qa" gives the following result:
Let's ignore for now, it's just cosmetics. (In reply to Philip Orr from comment #30)
At step 4), when running overdue_notices.pl, I get the following error:
Undefined subroutine &main::GetMessagingPreferences called at overdue_notices.pl line 753.
Last patch *should* fix that error. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 --- Comment #33 from Philip Orr <philip.orr@lmscloud.de> --- Yes, that fixed it! On to the next error: at step 4) Running overdue_notices.pl now gives the following error: No circulation ODUE letter transported by shift at /kohadevbox/koha/C4/Letters.pm line 601. I tested with a patron who had set her messaging preference for "Overdue 1" to "Mail". However the e-mail version of the ODUE letter was indeed created, so it worked as intended aside from the error. Maybe the error is more related to the print version of the letter not being created, because I tested it with another patron, this time no check mark set for "Overdue 1" and with the overdue notice/status trigger for overdue 1 set to "print only"; and got the same error. So step 6) is currently failing for me, as (of course after running gather_print_notices.pl) there was still no print notice for this patron. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|glasklas@gmail.com |jonathan.druart@gmail.com --- Comment #34 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Philip Orr from comment #33)
Yes, that fixed it! On to the next error: at step 4) Running overdue_notices.pl now gives the following error:
No circulation ODUE letter transported by shift at /kohadevbox/koha/C4/Letters.pm line 601.
For the record, this error is fixed with the following change: diff --git a/misc/cronjobs/overdue_notices.pl b/misc/cronjobs/overdue_notices.pl index e7977108116..f090631cc3c 100755 --- a/misc/cronjobs/overdue_notices.pl +++ b/misc/cronjobs/overdue_notices.pl @@ -759,7 +759,7 @@ END_SQL if ( $print_behavior eq 'always' || $print_behavior eq 'fallback' && !@message_transport_types ) { - unshift( @message_transport_types, 'shift' ); + unshift( @message_transport_types, 'print' ); } } else { my @message_transport_types = -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #35 from Jonathan Druart <jonathan.druart@gmail.com> --- However I don't understand the point of this syspref (UsePatronPreferencesForOverdueNoticesPrint), or at least it's not correctly handled in the different places (like why do you let patrons chose "email" if "print" will be forced anyway?). I think it would be better to restart here with only UsePatronPreferencesForOverdueNotices, then iterate on a separate bug if we want the "force print" behaviour. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 --- Comment #36 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #35)
However I don't understand the point of this syspref (UsePatronPreferencesForOverdueNoticesPrint), or at least it's not correctly handled in the different places (like why do you let patrons chose "email" if "print" will be forced anyway?).
Actually one "email" and one "print" notices are sent to the patron if UsePatronPreferencesForOverdueNoticesPrint = always. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 --- Comment #37 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 186272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186272&action=edit Bug 30515: Remove UsePatronPreferencesForOverdueNoticesPrint -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 --- Comment #38 from Philip Orr <philip.orr@lmscloud.de> --- Step 7 is no longer needed as the syspref doesn't have this option anymore: 7) Set UsePatronPreferencesForOverdueNotices to "when no other transport set" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 --- Comment #39 from Philip Orr <philip.orr@lmscloud.de> --- Tests were successful now after the changes, no more errors. That said: I think I now know why UsePatronPreferencesForOverdueNoticesPrint was added. If you have "UsePatronPreferencesForOverdueNotices" set to "Patron preference", but the patron has not checked any of the boxes for the Overdue notices in their preferences, then simply no overdue notice will be generated for them at all. Neither mail nor print. I would expect not checking the box to be equivalent to saying "I want the print notice". That is: if box is checked - mail if box is not checked - print (if box is checked but patron doesn't even have a mail address - also print) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 --- Comment #40 from Philip Orr <philip.orr@lmscloud.de> --- (and for the record, I don't think UsePatronPreferencesForOverdueNoticesPrint would be the right way to do that, because it was always creating a print version no matter what the patron had set in their preferences!) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 --- Comment #41 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 186278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186278&action=edit Bug 30515: Use print if the patron's preference is empty If the patron has not selected a transport type we still want to print. ie. the patrons cannot totally opt out. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 --- Comment #42 from Philip Orr <philip.orr@lmscloud.de> --- Running overdue_notices.pl now gives the following error: [] Warning: something's wrong at overdue_notices.pl line 761. [] Warning: something's wrong at overdue_notices.pl line 767. [ [0] "print" ] print at overdue_notices.pl line 773. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186278|0 |1 is obsolete| | --- Comment #43 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 186280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186280&action=edit Bug 30515: Use print if the patron's preference is empty If the patron has not selected a transport type we still want to print. ie. the patrons cannot totally opt out. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 --- Comment #44 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Philip Orr from comment #42)
Running overdue_notices.pl now gives the following error:
Oops, not errors but debugging statements. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 --- Comment #45 from Philip Orr <philip.orr@lmscloud.de> --- Great, the print notice if unchecked works now! Now for the next error. I ran overdue_notices.pl twice: - once with one overdue item, no checked boxes: print notice generated, great - afterwards ran it again with a different overdue item, same patron, this time checked all the overdue boxes: got an error ERROR PROCESSING TEMPLATE: undef error - : filter not found at /kohadevbox/koha/C4/Overdues.pm line 893 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 --- Comment #46 from Philip Orr <philip.orr@lmscloud.de> --- that last error is my fault, my notices had bad modified content that caused the error - ignore it -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 --- Comment #47 from Philip Orr <philip.orr@lmscloud.de> --- OK, so after further testing I ran into another error. If the testing patron has only one overdue item checked out, it now works as expected. However if the patron has multiple overdue items and the due dates of those items are "staggered" so that - for instance - one of the items would trigger ODUE1 and the other item would trigger ODUE2: you get the following error: ERROR PROCESSING TEMPLATE: undef error - : filter not found at /kohadevbox/koha/C4/Overdues.pm line 893.
From practical experience I can say that this situation unfortunately can happen IRL. But I'm not entirely sure if it's in the scope of this bug (or maybe there's already a different bug for it..)
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 --- Comment #48 from Philip Orr <philip.orr@lmscloud.de> --- Oops, nevermind that comment either. ODUE2 and ODUE3 were just missing the [%- USE Price -%] at the top of the content. After fixing that it now works. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 --- Comment #49 from Philip Orr <philip.orr@lmscloud.de> --- OK, I went through the test plan and it now all works as expected. Happy to sign off on it after the QA polishing / fixes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 --- Comment #50 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 186287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186287&action=edit Bug 30515: QA fixes [FAIL] installer/data/mysql/atomicupdate/bug_30515-add_system_preferences.pl FAIL git_manipulation The file has been added and deleted or renamed in the same patchset => Keeping for ownership [FAIL] installer/data/mysql/atomicupdate/bug_30515-move_overdue_transports_to_patron_messaging_preferences.pl FAIL file_permissions File must have the exec flag => Fixed FAIL forbidden_patterns forbidden pattern: Have you considered sharing the new syspref to HEA? (see bug 23849 and C4/UsageStats.pm) (line 39) => We ignore this for now [FAIL] installer/data/mysql/mandatory/sysprefs.sql FAIL semicolon semicolon found instead of comma at line 896 => Invalid (because of "no new line") -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186143|0 |1 is obsolete| | --- Comment #51 from Philip Orr <philip.orr@lmscloud.de> --- Created attachment 186288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186288&action=edit Bug 30515: Move Overdue transports to patron messaging preferences Add syspref for using patron specific message preferences for overdue messages instead of patron category level preferences. To test: 1) Set UsePatronPreferencesForOverdueNotices to "individual patron preference" 2) Enable some transport for a patron in the messaging preferences form 2) Check out an item and set a due date that will result in an overdue notice 4) Run the overdue_notices.pl script 5) Verify that messages has been sent for the selected transport(s) 6) Run gather_print_notices.pl and verify a print notice is generated 7) Set UsePatronPreferencesForOverdueNotices to "when no other transport set" 8) Run the overdue_notices.pl and gather_print_notices.pl and verify that no print notice is generated 9) Disable all transports for the patron 10) Run the overdue_notices.pl and gather_print_notices.pl and verify that print notice is generated 11) Set UsePatronPreferencesForOverdueNotices to "never" 12) Run the overdue_notices.pl and gather_print_notices.pl and verify that no print notice is generated 13) Enable some transport(s) for the patron 14) Run the overdue_notices.pl and gather_print_notices.pl and verify that no print notice is generated 15) Set UsePatronPreferencesForOverdueNotices to "patron category" 16) Run the overdue_notices.pl and gather_print_notices.pl and verify the patron category and library setting is used Sponsored-by: Gothenburg University Library Signed-off-by: krimsonkharne <philip.orr@posteo.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186145|0 |1 is obsolete| | --- Comment #52 from Philip Orr <philip.orr@lmscloud.de> --- Created attachment 186289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186289&action=edit Bug 30515: Fix messaging options order and add database changes Signed-off-by: krimsonkharne <philip.orr@posteo.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186146|0 |1 is obsolete| | --- Comment #53 from Philip Orr <philip.orr@lmscloud.de> --- Created attachment 186290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186290&action=edit Bug 30515: (follow-up) Fix messaging options order and add database changes Signed-off-by: krimsonkharne <philip.orr@posteo.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186147|0 |1 is obsolete| | --- Comment #54 from Philip Orr <philip.orr@lmscloud.de> --- Created attachment 186291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186291&action=edit Bug 30515: Fix OPAC form Signed-off-by: krimsonkharne <philip.orr@posteo.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186258|0 |1 is obsolete| | --- Comment #55 from Philip Orr <philip.orr@lmscloud.de> --- Created attachment 186292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186292&action=edit Bug 30515: fix GetMessagingPreferences call It's not exported Signed-off-by: krimsonkharne <philip.orr@posteo.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186272|0 |1 is obsolete| | --- Comment #56 from Philip Orr <philip.orr@lmscloud.de> --- Created attachment 186293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186293&action=edit Bug 30515: Remove UsePatronPreferencesForOverdueNoticesPrint Signed-off-by: krimsonkharne <philip.orr@posteo.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186280|0 |1 is obsolete| | --- Comment #57 from Philip Orr <philip.orr@lmscloud.de> --- Created attachment 186294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186294&action=edit Bug 30515: Use print if the patron's preference is empty If the patron has not selected a transport type we still want to print. ie. the patrons cannot totally opt out. Signed-off-by: krimsonkharne <philip.orr@posteo.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186287|0 |1 is obsolete| | --- Comment #58 from Philip Orr <philip.orr@lmscloud.de> --- Created attachment 186295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186295&action=edit Bug 30515: QA fixes [FAIL] installer/data/mysql/atomicupdate/bug_30515-add_system_preferences.pl FAIL git_manipulation The file has been added and deleted or renamed in the same patchset => Keeping for ownership [FAIL] installer/data/mysql/atomicupdate/bug_30515-move_overdue_transports_to_patron_messaging_preferences.pl FAIL file_permissions File must have the exec flag => Fixed FAIL forbidden_patterns forbidden pattern: Have you considered sharing the new syspref to HEA? (see bug 23849 and C4/UsageStats.pm) (line 39) => We ignore this for now [FAIL] installer/data/mysql/mandatory/sysprefs.sql FAIL semicolon semicolon found instead of comma at line 896 => Invalid (because of "no new line") Signed-off-by: krimsonkharne <philip.orr@posteo.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|julian.maurice@biblibre.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40791 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40791 [Bug 40791] Allow choice of which Overdue messages can be patron preferences -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 --- Comment #59 from Philip Orr <philip.orr@lmscloud.de> --- For the "set a certain notice as mandatory" part: I made a new bug for that, Bug 40791. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40791 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186288|0 |1 is obsolete| | Attachment #186289|0 |1 is obsolete| | Attachment #186290|0 |1 is obsolete| | Attachment #186291|0 |1 is obsolete| | Attachment #186292|0 |1 is obsolete| | Attachment #186293|0 |1 is obsolete| | Attachment #186294|0 |1 is obsolete| | Attachment #186295|0 |1 is obsolete| | --- Comment #60 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 187229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187229&action=edit Bug 30515: Move Overdue transports to patron messaging preferences Add syspref for using patron specific message preferences for overdue messages instead of patron category level preferences. To test: 1) Set UsePatronPreferencesForOverdueNotices to "individual patron preference" 2) Enable some transport for a patron in the messaging preferences form 2) Check out an item and set a due date that will result in an overdue notice 4) Run the overdue_notices.pl script 5) Verify that messages has been sent for the selected transport(s) 6) Run gather_print_notices.pl and verify a print notice is generated 7) Set UsePatronPreferencesForOverdueNotices to "when no other transport set" 8) Run the overdue_notices.pl and gather_print_notices.pl and verify that no print notice is generated 9) Disable all transports for the patron 10) Run the overdue_notices.pl and gather_print_notices.pl and verify that print notice is generated 11) Set UsePatronPreferencesForOverdueNotices to "never" 12) Run the overdue_notices.pl and gather_print_notices.pl and verify that no print notice is generated 13) Enable some transport(s) for the patron 14) Run the overdue_notices.pl and gather_print_notices.pl and verify that no print notice is generated 15) Set UsePatronPreferencesForOverdueNotices to "patron category" 16) Run the overdue_notices.pl and gather_print_notices.pl and verify the patron category and library setting is used Sponsored-by: Gothenburg University Library Signed-off-by: krimsonkharne <philip.orr@posteo.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 --- Comment #61 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 187230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187230&action=edit Bug 30515: Fix messaging options order and add database changes Signed-off-by: krimsonkharne <philip.orr@posteo.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 --- Comment #62 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 187231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187231&action=edit Bug 30515: (follow-up) Fix messaging options order and add database changes Signed-off-by: krimsonkharne <philip.orr@posteo.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 --- Comment #63 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 187232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187232&action=edit Bug 30515: Fix OPAC form Signed-off-by: krimsonkharne <philip.orr@posteo.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 --- Comment #64 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 187233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187233&action=edit Bug 30515: fix GetMessagingPreferences call It's not exported Signed-off-by: krimsonkharne <philip.orr@posteo.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 --- Comment #65 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 187234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187234&action=edit Bug 30515: Remove UsePatronPreferencesForOverdueNoticesPrint Signed-off-by: krimsonkharne <philip.orr@posteo.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 --- Comment #66 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 187235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187235&action=edit Bug 30515: Use print if the patron's preference is empty If the patron has not selected a transport type we still want to print. ie. the patrons cannot totally opt out. Signed-off-by: krimsonkharne <philip.orr@posteo.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 --- Comment #67 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 187236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187236&action=edit Bug 30515: QA fixes [FAIL] installer/data/mysql/atomicupdate/bug_30515-add_system_preferences.pl FAIL git_manipulation The file has been added and deleted or renamed in the same patchset => Keeping for ownership [FAIL] installer/data/mysql/atomicupdate/bug_30515-move_overdue_transports_to_patron_messaging_preferences.pl FAIL file_permissions File must have the exec flag => Fixed FAIL forbidden_patterns forbidden pattern: Have you considered sharing the new syspref to HEA? (see bug 23849 and C4/UsageStats.pm) (line 39) => We ignore this for now [FAIL] installer/data/mysql/mandatory/sysprefs.sql FAIL semicolon semicolon found instead of comma at line 896 => Invalid (because of "no new line") Signed-off-by: krimsonkharne <philip.orr@posteo.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187229|0 |1 is obsolete| | --- Comment #68 from Philip Orr <philip.orr@lmscloud.de> --- Created attachment 187237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187237&action=edit Bug 30515: Move Overdue transports to patron messaging preferences Add syspref for using patron specific message preferences for overdue messages instead of patron category level preferences. To test: 1) Set UsePatronPreferencesForOverdueNotices to "individual patron preference" 2) Enable some transport for a patron in the messaging preferences form 2) Check out an item and set a due date that will result in an overdue notice 4) Run the overdue_notices.pl script 5) Verify that messages has been sent for the selected transport(s) 6) Run gather_print_notices.pl and verify a print notice is generated 7) Set UsePatronPreferencesForOverdueNotices to "when no other transport set" 8) Run the overdue_notices.pl and gather_print_notices.pl and verify that no print notice is generated 9) Disable all transports for the patron 10) Run the overdue_notices.pl and gather_print_notices.pl and verify that print notice is generated 11) Set UsePatronPreferencesForOverdueNotices to "never" 12) Run the overdue_notices.pl and gather_print_notices.pl and verify that no print notice is generated 13) Enable some transport(s) for the patron 14) Run the overdue_notices.pl and gather_print_notices.pl and verify that no print notice is generated 15) Set UsePatronPreferencesForOverdueNotices to "patron category" 16) Run the overdue_notices.pl and gather_print_notices.pl and verify the patron category and library setting is used Sponsored-by: Gothenburg University Library Signed-off-by: krimsonkharne <philip.orr@posteo.de> Signed-off-by: Philip Orr <philip.orr@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187230|0 |1 is obsolete| | --- Comment #69 from Philip Orr <philip.orr@lmscloud.de> --- Created attachment 187238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187238&action=edit Bug 30515: Fix messaging options order and add database changes Signed-off-by: krimsonkharne <philip.orr@posteo.de> Signed-off-by: Philip Orr <philip.orr@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187231|0 |1 is obsolete| | --- Comment #70 from Philip Orr <philip.orr@lmscloud.de> --- Created attachment 187239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187239&action=edit Bug 30515: (follow-up) Fix messaging options order and add database changes Signed-off-by: krimsonkharne <philip.orr@posteo.de> Signed-off-by: Philip Orr <philip.orr@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187232|0 |1 is obsolete| | --- Comment #71 from Philip Orr <philip.orr@lmscloud.de> --- Created attachment 187240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187240&action=edit Bug 30515: Fix OPAC form Signed-off-by: krimsonkharne <philip.orr@posteo.de> Signed-off-by: Philip Orr <philip.orr@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187233|0 |1 is obsolete| | --- Comment #72 from Philip Orr <philip.orr@lmscloud.de> --- Created attachment 187241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187241&action=edit Bug 30515: fix GetMessagingPreferences call It's not exported Signed-off-by: krimsonkharne <philip.orr@posteo.de> Signed-off-by: Philip Orr <philip.orr@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187234|0 |1 is obsolete| | --- Comment #73 from Philip Orr <philip.orr@lmscloud.de> --- Created attachment 187242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187242&action=edit Bug 30515: Remove UsePatronPreferencesForOverdueNoticesPrint Signed-off-by: krimsonkharne <philip.orr@posteo.de> Signed-off-by: Philip Orr <philip.orr@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187235|0 |1 is obsolete| | --- Comment #74 from Philip Orr <philip.orr@lmscloud.de> --- Created attachment 187243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187243&action=edit Bug 30515: Use print if the patron's preference is empty If the patron has not selected a transport type we still want to print. ie. the patrons cannot totally opt out. Signed-off-by: krimsonkharne <philip.orr@posteo.de> Signed-off-by: Philip Orr <philip.orr@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187236|0 |1 is obsolete| | --- Comment #75 from Philip Orr <philip.orr@lmscloud.de> --- Created attachment 187244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187244&action=edit Bug 30515: QA fixes [FAIL] installer/data/mysql/atomicupdate/bug_30515-add_system_preferences.pl FAIL git_manipulation The file has been added and deleted or renamed in the same patchset => Keeping for ownership [FAIL] installer/data/mysql/atomicupdate/bug_30515-move_overdue_transports_to_patron_messaging_preferences.pl FAIL file_permissions File must have the exec flag => Fixed FAIL forbidden_patterns forbidden pattern: Have you considered sharing the new syspref to HEA? (see bug 23849 and C4/UsageStats.pm) (line 39) => We ignore this for now [FAIL] installer/data/mysql/mandatory/sysprefs.sql FAIL semicolon semicolon found instead of comma at line 896 => Invalid (because of "no new line") Signed-off-by: krimsonkharne <philip.orr@posteo.de> Signed-off-by: Philip Orr <philip.orr@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187237|0 |1 is obsolete| | --- Comment #76 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 187250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187250&action=edit Bug 30515: Move Overdue transports to patron messaging preferences Add syspref for using patron specific message preferences for overdue messages instead of patron category level preferences. To test: 1) Set UsePatronPreferencesForOverdueNotices to "individual patron preference" 2) Enable some transport for a patron in the messaging preferences form 2) Check out an item and set a due date that will result in an overdue notice 4) Run the overdue_notices.pl script 5) Verify that messages has been sent for the selected transport(s) 6) Run gather_print_notices.pl and verify a print notice is generated 7) Set UsePatronPreferencesForOverdueNotices to "when no other transport set" 8) Run the overdue_notices.pl and gather_print_notices.pl and verify that no print notice is generated 9) Disable all transports for the patron 10) Run the overdue_notices.pl and gather_print_notices.pl and verify that print notice is generated 11) Set UsePatronPreferencesForOverdueNotices to "never" 12) Run the overdue_notices.pl and gather_print_notices.pl and verify that no print notice is generated 13) Enable some transport(s) for the patron 14) Run the overdue_notices.pl and gather_print_notices.pl and verify that no print notice is generated 15) Set UsePatronPreferencesForOverdueNotices to "patron category" 16) Run the overdue_notices.pl and gather_print_notices.pl and verify the patron category and library setting is used Sponsored-by: Gothenburg University Library Signed-off-by: Philip Orr <philip.orr@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187238|0 |1 is obsolete| | --- Comment #77 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 187251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187251&action=edit Bug 30515: Fix messaging options order and add database changes Signed-off-by: Philip Orr <philip.orr@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187239|0 |1 is obsolete| | --- Comment #78 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 187252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187252&action=edit Bug 30515: (follow-up) Fix messaging options order and add database changes Signed-off-by: Philip Orr <philip.orr@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187240|0 |1 is obsolete| | --- Comment #79 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 187253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187253&action=edit Bug 30515: Fix OPAC form Signed-off-by: Philip Orr <philip.orr@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187241|0 |1 is obsolete| | --- Comment #80 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 187254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187254&action=edit Bug 30515: fix GetMessagingPreferences call It's not exported Signed-off-by: Philip Orr <philip.orr@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187242|0 |1 is obsolete| | --- Comment #81 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 187255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187255&action=edit Bug 30515: Remove UsePatronPreferencesForOverdueNoticesPrint Signed-off-by: Philip Orr <philip.orr@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187243|0 |1 is obsolete| | --- Comment #82 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 187256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187256&action=edit Bug 30515: Use print if the patron's preference is empty If the patron has not selected a transport type we still want to print. ie. the patrons cannot totally opt out. Signed-off-by: Philip Orr <philip.orr@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187244|0 |1 is obsolete| | --- Comment #83 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 187257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187257&action=edit Bug 30515: QA fixes [FAIL] installer/data/mysql/atomicupdate/bug_30515-add_system_preferences.pl FAIL git_manipulation The file has been added and deleted or renamed in the same patchset => Keeping for ownership [FAIL] installer/data/mysql/atomicupdate/bug_30515-move_overdue_transports_to_patron_messaging_preferences.pl FAIL file_permissions File must have the exec flag => Fixed FAIL forbidden_patterns forbidden pattern: Have you considered sharing the new syspref to HEA? (see bug 23849 and C4/UsageStats.pm) (line 39) => We ignore this for now [FAIL] installer/data/mysql/mandatory/sysprefs.sql FAIL semicolon semicolon found instead of comma at line 896 => Invalid (because of "no new line") Signed-off-by: Philip Orr <philip.orr@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=10190 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marion.durand@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515 carthur@slolibrary.org <carthur@slolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carthur@slolibrary.org -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org