[Bug 23385] New: Hide default value fields by default on patron import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23385 Bug ID: 23385 Summary: Hide default value fields by default on patron import Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org When importing patrons there is a very long form to supply default values for patron fields. This is not always used and can be hidden unless needed to make the form display nicer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23385 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23385 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 91813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91813&action=edit Bug 23385: Hide 'Default values' fields by default To test: 1 - Go to Tools->Import patrons 2 - Choose a file 3 - Scroll a long way to submit 4 - Apply patch 5 - Choose a file 6 - Can submit easily 7 - Click to expand and enter default fields 8 - Confirm can still submit and that values entered are used -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23385 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23385 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91813|0 |1 is obsolete| | --- Comment #2 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 91838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91838&action=edit Bug 23385: Hide 'Default values' fields by default To test: 1 - Go to Tools->Import patrons 2 - Choose a file 3 - Scroll a long way to submit 4 - Apply patch 5 - Choose a file 6 - Can submit easily 7 - Click to expand and enter default fields 8 - Confirm can still submit and that values entered are used Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23385 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maryse.simard@inlibro.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23385 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23385 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 91850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91850&action=edit Bug 23385: (follow-up) Update link This follow-up adds a dummy href attribute to the link for showing and hiding the default values form so that it behaves more like a link. I removed "click to" from the link text and added Font Awesome icons common to "show/hide" links. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23385 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91838|0 |1 is obsolete| | --- Comment #4 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 91859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91859&action=edit Bug 23385: Hide 'Default values' fields by default To test: 1 - Go to Tools->Import patrons 2 - Choose a file 3 - Scroll a long way to submit 4 - Apply patch 5 - Choose a file 6 - Can submit easily 7 - Click to expand and enter default fields 8 - Confirm can still submit and that values entered are used Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: George Williams <george@nekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23385 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91850|0 |1 is obsolete| | --- Comment #5 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 91860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91860&action=edit Bug 23385: (follow-up) Update link This follow-up adds a dummy href attribute to the link for showing and hiding the default values form so that it behaves more like a link. I removed "click to" from the link text and added Font Awesome icons common to "show/hide" links. Signed-off-by: George Williams <george@nekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23385 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george@nekls.org Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23385 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23385 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91860|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 92094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92094&action=edit Bug 23385: (follow-up) Update link This follow-up adds a dummy href attribute to the link for showing and hiding the default values form so that it behaves more like a link. I removed "click to" from the link text and added Font Awesome icons common to "show/hide" links. Signed-off-by: George Williams <george@nekls.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23385 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23385 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23385 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00,19.05.04 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Small enhancement, I choose to backport. Pushed to 19.05.x for 19.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23385 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- enhancement, wont backport to 18.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org