[Bug 23438] New: Use Font Awesome icons in intranet search results browser
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23438 Bug ID: 23438 Summary: Use Font Awesome icons in intranet search results browser Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org In intranet after a search you see a results browser top left of biblio record details. Actually this uses text for links next and previous with a character for the arrows. I propose to use Font Awesome icons arrows. In fact the translated text is often too large for those buttons. For example "Previous" is "Précédant" in french and it causes the next and previous buttons to display on two lines. Using icons is more compact and easy to use. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23438 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard@myacpl.org |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23438 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23438 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 92042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92042&action=edit Bug 23438: Use Font Awesome icons in intranet search results browser In intranet after a search you see a results browser top left of biblio record details. Actually this uses text for links next and previous with a character for the arrows. I propose to use Font Awesome icons arrows. In fact the translated text is often too large for those buttons. For example "Previous" is "Préédant" in french and it causes the next and previous buttons to display on two lines. Using icons is more compact and easy to use. This patch also adds the list icon to back to results link and changes for a minimal text "Results". 1) Go to intranet 2) Perform a search with a few results 3) Click on first record 4) Check browser displays well 5) Click on next icon, check you go to next search result 6) Click on revious icon, check you go to previous search result 7) Click on "Results", you come back to search results 8) Clik on "Last" and click on last record 9) Check browser displays well -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23438 --- Comment #2 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 92043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92043&action=edit Bug 23438: Compiled CSS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23438 --- Comment #3 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 92044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92044&action=edit Screenshot -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23438 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23438 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92042|0 |1 is obsolete| | Attachment #92043|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 92048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92048&action=edit Bug 23438: Use Font Awesome icons in intranet search results browser In intranet after a search you see a results browser top left of biblio record details. Actually this uses text for links next and previous with a character for the arrows. I propose to use Font Awesome icons arrows. In fact the translated text is often too large for those buttons. For example "Previous" is "Préédant" in french and it causes the next and previous buttons to display on two lines. Using icons is more compact and easy to use. This patch also adds the list icon to back to results link and changes for a minimal text "Results". 1) Go to intranet 2) Perform a search with a few results 3) Click on first record 4) Check browser displays well 5) Click on next icon, check you go to next search result 6) Click on revious icon, check you go to previous search result 7) Click on "Results", you come back to search results 8) Clik on "Last" and click on last record 9) Check browser displays well Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23438 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23438 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92048|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 92092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92092&action=edit Bug 23438: Use Font Awesome icons in intranet search results browser In intranet after a search you see a results browser top left of biblio record details. Actually this uses text for links next and previous with a character for the arrows. I propose to use Font Awesome icons arrows. In fact the translated text is often too large for those buttons. For example "Previous" is "Préédant" in french and it causes the next and previous buttons to display on two lines. Using icons is more compact and easy to use. This patch also adds the list icon to back to results link and changes for a minimal text "Results". 1) Go to intranet 2) Perform a search with a few results 3) Click on first record 4) Check browser displays well 5) Click on next icon, check you go to next search result 6) Click on revious icon, check you go to previous search result 7) Click on "Results", you come back to search results 8) Clik on "Last" and click on last record 9) Check browser displays well Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23438 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23438 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23438 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00,19.05.04 released in| | Status|Pushed to master |Pushed to stable --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Small enhancement, I choose to backport. Pushed to 19.05.x for 19.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23438 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |lucas@bywatersolutions.com Resolution|--- |FIXED --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- enhancement wont backport to 18.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org