[Bug 12000] New: staff users can set hold suspension dates to occur in the past
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12000 Bug ID: 12000 Summary: staff users can set hold suspension dates to occur in the past Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: gmcharlt@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com In the hold request management page, the datepicker lets staff users set the hold resumption date in the past. This doesn't seem useful: - if automatic hold un-suspension is enabled, the hold will flip back to unsuspended the next time the cronjob runs - if the user means to suspend a hold indefinitely, the way to do it is to not set a specific resumption date This issue also affects the datepicker for the resumption date on the checkout page. It does NOT affect the datepicker on the patron details page, which lets the staff user only pick dates in the future. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12000 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12000 --- Comment #1 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 26613 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26613&action=edit Bug 12000: ensure that hold resumption dates can be set only to future dates This patch makes the datepickers for the hold resumption date (AKA the hold suspend until date) field only permit dates in the future to be selected in the staff interface checkout page and hold list pages. This makes these pages consistent with the OPAC and the patron details page in the staff interface. To test: [1] Ensure that AutoResumeSuspendedHolds and SuspendHoldsIntranet are enabled. [2] Go to the checkout page for a patron that has at least one hold request. [3] Verify that the datepicker for the hold suspend until date field only permits choosing a date in the future. [4] Go to the page listing hold requests for a title. [5] Verify that the datepicker for the hold suspend until date fields only permit choosing a date in the future. Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12000 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12000 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 26687 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26687&action=edit [SIGNED-OFF] Bug 12000: ensure that hold resumption dates can be set only to future dates This patch makes the datepickers for the hold resumption date (AKA the hold suspend until date) field only permit dates in the future to be selected in the staff interface checkout page and hold list pages. This makes these pages consistent with the OPAC and the patron details page in the staff interface. To test: [1] Ensure that AutoResumeSuspendedHolds and SuspendHoldsIntranet are enabled. [2] Go to the checkout page for a patron that has at least one hold request. [3] Verify that the datepicker for the hold suspend until date field only permits choosing a date in the future. [4] Go to the page listing hold requests for a title. [5] Verify that the datepicker for the hold suspend until date fields only permit choosing a date in the future. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12000 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12000 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26613|0 |1 is obsolete| | Attachment #26687|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 26700 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26700&action=edit [PASSED QA] Bug 12000: ensure that hold resumption dates can be set only to future dates This patch makes the datepickers for the hold resumption date (AKA the hold suspend until date) field only permit dates in the future to be selected in the staff interface checkout page and hold list pages. This makes these pages consistent with the OPAC and the patron details page in the staff interface. To test: [1] Ensure that AutoResumeSuspendedHolds and SuspendHoldsIntranet are enabled. [2] Go to the checkout page for a patron that has at least one hold request. [3] Verify that the datepicker for the hold suspend until date field only permits choosing a date in the future. [4] Go to the page listing hold requests for a title. [5] Verify that the datepicker for the hold suspend until date fields only permit choosing a date in the future. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, passes all tests and QA script. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12000 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12000 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #5 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.08 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org