[Bug 11946] New: add table sorters to label and patron card batches
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11946 Bug ID: 11946 Summary: add table sorters to label and patron card batches Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: nengard@gmail.com QA Contact: testopia@bugs.koha-community.org Created attachment 26373 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26373&action=edit card batch When viewing a big batch of cards it's often handy to be able to sort. On this page: cgi-bin/koha/patroncards/edit-batch.pl it would be nice to see the new table sorter/search. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11946 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11946 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11946 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 26532 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26532&action=edit Bug 11946 - add table sorters to label and patron card batches When viewing batches of titles in the label creator module the table is not sortable. This patch adds table sorting. The patch also makes some corrections of invalid markup and moves informational/error messages to the top of the page rather than in a sidebar. This change lets the table and sorting controls expand into a wider space. To test, go to Tools -> Labels -> Manage label batches. View an existing batch or create a new batch and populate it with items. Table sorting controls should work correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11946 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26532|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 26564 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26564&action=edit Bug 11946 - add table sorters to label and patron card batches When viewing batches of titles in the label creator module the table is not sortable. This patch adds table sorting. The patch also makes some corrections of invalid markup and moves informational/error messages to the top of the page rather than in a sidebar. This change lets the table and sorting controls expand into a wider space. To test, go to Tools -> Labels -> Manage label batches. View an existing batch or create a new batch and populate it with items. Table sorting controls should work correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11946 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11946 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26564|0 |1 is obsolete| | --- Comment #3 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 26565 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26565&action=edit [SIGNED-OFF] Bug 11946 - add table sorters to label and patron card batches When viewing batches of titles in the label creator module the table is not sortable. This patch adds table sorting. The patch also makes some corrections of invalid markup and moves informational/error messages to the top of the page rather than in a sidebar. This change lets the table and sorting controls expand into a wider space. To test, go to Tools -> Labels -> Manage label batches. View an existing batch or create a new batch and populate it with items. Table sorting controls should work correctly. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Solves 1/2 of this bug which is to add the sorters to labels, the original request was to add this to patron cards as well. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11946 --- Comment #4 from Nicole C. Engard <nengard@gmail.com> --- More accurately, I asked to get the sorter added to patron cards and when I reported the issue here I said patron cards and labels in the title. So if there can be a follow up to add this to the patron cards that would be awesome! Nicole -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11946 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11946 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26565|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 26701 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26701&action=edit [PASSED QA] Bug 11946 - add table sorters to label and patron card batches When viewing batches of titles in the label creator module the table is not sortable. This patch adds table sorting. The patch also makes some corrections of invalid markup and moves informational/error messages to the top of the page rather than in a sidebar. This change lets the table and sorting controls expand into a wider space. To test, go to Tools -> Labels -> Manage label batches. View an existing batch or create a new batch and populate it with items. Table sorting controls should work correctly. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Solves 1/2 of this bug which is to add the sorters to labels, the original request was to add this to patron cards as well. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, passes all tests and QA script. Template could be improved forther by showing the itemtype description instead of the code in the table. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11946 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com Summary|add table sorters to label |add table sorters to label |and patron card batches |batches -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11946 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Since the patch covered only half of the request, I've opened a new bug, bug 12018, for the patron card portion. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11946 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #7 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.08 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org