[Bug 37536] New: Cataloging add item js needs to update conditional that checks op
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37536 Bug ID: 37536 Summary: Cataloging add item js needs to update conditional that checks op Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: blawlor@clamsnet.org QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl In cataloging_additem.js there is a check for op != 'saveitem' that needs to be updated to op != 'cud-saveitem' In additem.pl and additem.tt all instances of 'saveitem' have been updated to 'cud-save-item' The javascript's functionality is explained in bug 22669. It's related to editing items when receiving an order. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37536 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Blocks| |36192 Assignee|koha-bugs@lists.koha-commun |blawlor@clamsnet.org |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192 [Bug 36192] [OMNIBUS] CSRF Protection for Koha -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37536 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37536 --- Comment #1 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 169890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169890&action=edit Bug 37536: Update conditional to check for 'cud-saveitem' In additem.pl and additem.tt all instances of 'saveitem' have been updated to 'cud-save-item' The javascript needs to be updated in the same way. Test plan: 1. git grep 'saveitem' 2. Notice all instances in additem.pl and additem.tt have been updated to 'cud-saveitem' 3. Notice cataloging_additem.js checks if op != 'saveitem' 4. Check the files and verify the change makes sense 5. Try the test plan from Bug 22669 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37536 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37536 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #2 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
From bug 22669 test plan:
- Make sure acqcreateitem is set to "when placing an order"
where is that acqcreateitem thing? ---
Test plan: 1. git grep 'saveitem' 2. Notice all instances in additem.pl and additem.tt have been updated to 'cud-saveitem' 3. Notice cataloging_additem.js checks if op != 'saveitem' 4. Check the files and verify the change makes sense
These 1st steps are actually additional and welcome QA notes to help the code review. The test plan is just about blindly following instructions to confirm that the patch does what is says it does. So the actual test plan would be the one from Bug 22669 remixed to witness a CSRF error before the patch and then witnessing it being gone after the patches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37536 --- Comment #3 from Brendan Lawlor <blawlor@clamsnet.org> --- Thanks Victor. acqcreateitem is a system preference and I believe the default is 'when placing an order' Yes the actual test is on Bug 22669. When I tested I didn't see the CSRF error, but the pop up opens and closes abruptly as described in that bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37536 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169890|0 |1 is obsolete| | --- Comment #4 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 170044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170044&action=edit Bug 37536: Update conditional to check for 'cud-saveitem' In additem.pl and additem.tt all instances of 'saveitem' have been updated to 'cud-save-item' The javascript needs to be updated in the same way. Test plan: 1. Same as test plan from Bug 22669. Same symptom. QA notes: 1. git grep 'saveitem' 2. Notice all instances in additem.pl and additem.tt have been updated to 'cud-saveitem' 3. Notice cataloging_additem.js checks if op != 'saveitem' 4. Check the files and verify the change makes sense Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37536 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
acqcreateitem is a system preference and I believe the default is 'when placing an order'
Thanks, somehow I didn't find it and when searching in the code I forgot to search case insensitively ^^" ---
Yes the actual test is on Bug 22669. When I tested I didn't see the CSRF error, but the pop up opens and closes abruptly as described in that bug.
Ok it's the same symptom. --- Patch works! :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37536 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170044|0 |1 is obsolete| | --- Comment #6 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 170220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170220&action=edit Bug 37536: Update conditional to check for 'cud-saveitem' In additem.pl and additem.tt all instances of 'saveitem' have been updated to 'cud-save-item' The javascript needs to be updated in the same way. Test plan: 1. Same as test plan from Bug 22669. Same symptom. QA notes: 1. git grep 'saveitem' 2. Notice all instances in additem.pl and additem.tt have been updated to 'cud-saveitem' 3. Notice cataloging_additem.js checks if op != 'saveitem' 4. Check the files and verify the change makes sense Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37536 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov Status|Signed Off |Passed QA --- Comment #7 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Thanks for the fix! QA tool passes, and it works and makes sense. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37536 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37536 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170220|0 |1 is obsolete| | --- Comment #8 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 170221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170221&action=edit Bug 37536: Update conditional to check for 'cud-saveitem' In additem.pl and additem.tt all instances of 'saveitem' have been updated to 'cud-save-item' The javascript needs to be updated in the same way. Test plan: - Make sure acqcreateitem is set to "when placing an order" - Create a basket with some orders - Close the basket - Go to your vendor and receive an order - On the receive page, try to edit your item => Without the patch, the pop up page will open and then close, not allowing the item to be edited. => With this patch applied you will see the item edit form. Save and confirm that the parent window is updated with the new value (actually it's refreshed) QA notes: 1. git grep 'saveitem' 2. Notice all instances in additem.pl and additem.tt have been updated to 'cud-saveitem' 3. Notice cataloging_additem.js checks if op != 'saveitem' 4. Check the files and verify the change makes sense Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37536 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #9 from Brendan Lawlor <blawlor@clamsnet.org> --- *** Bug 37589 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37536 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37536 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37536 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37536 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Keywords| |rel_24_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37536 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_05_candidate | Version(s)|24.11.00 |24.11.00,24.05.05 released in| | Status|Pushed to main |Pushed to stable --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37536 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not for 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37536 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #13 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Internal architecture, nothing to add/edit in the manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org