[Bug 37382] New: Report download is empty except for headers if .tab format is selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37382 Bug ID: 37382 Summary: Report download is empty except for headers if .tab format is selected Change sponsored?: --- Product: Koha Version: 24.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: eric@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Run a report and select download as tab separated text. The downloaded file will have the first row and then empty rows for the number of results that should have been returned. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37382 CJ Lynce <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cj.lynce@westlakelibrary.or | |g -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37382 --- Comment #1 from CJ Lynce <cj.lynce@westlakelibrary.org> --- I found that this issue also causes a ton of misc files to be created on the server filesystem in koha/reports/ . Each file is named something related to the exported data. Example -rw-r--r-- 1 kohadev-koha kohadev-koha 14 Jul 26 18:42 'Conspirator :' -rw-r--r-- 1 kohadev-koha kohadev-koha 14 Jul 26 18:42 'CSS :' -rw-r--r-- 1 kohadev-koha kohadev-koha 14 Jul 26 18:42 'Damned to fame :' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37382 --- Comment #2 from CJ Lynce <cj.lynce@westlakelibrary.org> --- Created attachment 169776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169776&action=edit Bug 37382: Report download is empty except for headers if .tab format is selected When exporting a report in tab delimited format, the downloaded file would have the header rows but no data results. Also, misc files are created on the server file system in koha/reports with data that should have been in the .tab file. This patch fixes both of these issues. To test: 1. Login to staff client 2. Go to Reports and create a report from SQL - sample report SELECT i.barcode, b.title, b.biblionumber, i.itemnumber FROM items i LEFT JOIN biblio b on i.biblionumber = b.biblionumber WHERE i.itemnumber < 50 3. Run the report 4. Click 'Download'->'Tab separated text' 5. Download file 6. Open file in a text editor or favorite spreadsheet app File will have headers rows, but no other item data 6a. If able, check the server filesystem in koha/reports There may be files there related to report data. Remove. 7. Apply Patch 8. Repeat steps 3-6, File will now have the table data, hooray! 8a. If able, check the server filesystem in koha/reports No new files should be created. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37382 CJ Lynce <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37382 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169776|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 169780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169780&action=edit Bug 37382: Report download is empty except for headers if .tab format is selected When exporting a report in tab delimited format, the downloaded file would have the header rows but no data results. Also, misc files are created on the server file system in koha/reports with data that should have been in the .tab file. This patch fixes both of these issues. To test: 1. Login to staff client 2. Go to Reports and create a report from SQL - sample report SELECT i.barcode, b.title, b.biblionumber, i.itemnumber FROM items i LEFT JOIN biblio b on i.biblionumber = b.biblionumber WHERE i.itemnumber < 50 3. Run the report 4. Click 'Download'->'Tab separated text' 5. Download file 6. Open file in a text editor or favorite spreadsheet app File will have headers rows, but no other item data 6a. If able, check the server filesystem in koha/reports There may be files there related to report data. Remove. 7. Apply Patch 8. Repeat steps 3-6, File will now have the table data, hooray! 8a. If able, check the server filesystem in koha/reports No new files should be created. Signed-off-by: Laura ONeil <laura@bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37382 Laura O'Neil <laura@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |laura@bywatersolutions.com Status|Needs Signoff |Signed Off --- Comment #4 from Laura O'Neil <laura@bywatersolutions.com> --- I was unable to confirm the second issue of misc files created in koha/reports, but the patch fixes the data issue. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37382 CJ Lynce <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |cj.lynce@westlakelibrary.or |ity.org |g -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37382 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37382 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Version|24.05 |Main CC| |lucas@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37382 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37382 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169780|0 |1 is obsolete| | --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 170267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170267&action=edit Bug 37382: Report download is empty except for headers if .tab format is selected When exporting a report in tab delimited format, the downloaded file would have the header rows but no data results. Also, misc files are created on the server file system in koha/reports with data that should have been in the .tab file. This patch fixes both of these issues. To test: 1. Login to staff client 2. Go to Reports and create a report from SQL - sample report SELECT i.barcode, b.title, b.biblionumber, i.itemnumber FROM items i LEFT JOIN biblio b on i.biblionumber = b.biblionumber WHERE i.itemnumber < 50 3. Run the report 4. Click 'Download'->'Tab separated text' 5. Download file 6. Open file in a text editor or favorite spreadsheet app File will have headers rows, but no other item data 6a. If able, check the server filesystem in koha/reports There may be files there related to report data. Remove. 7. Apply Patch 8. Repeat steps 3-6, File will now have the table data, hooray! 8a. If able, check the server filesystem in koha/reports No new files should be created. Signed-off-by: Laura ONeil <laura@bywatersolutions.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37382 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37382 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37382 CJ Lynce <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37382 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00 |24.11.00,24.05.04 released in| | Keywords|rel_24_05_candidate | Status|Pushed to main |Pushed to stable --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37382 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Depends on| |5920 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5920 [Bug 5920] Remove HTML from downloaded reports in CSV format -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37382 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 5920 not in 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37382 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37382 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED CC| |caroline.cyr-la-rose@inlibr | |o.com Resolution|--- |FIXED --- Comment #9 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Bug fix, nothing to add/edit in the manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org