[Bug 8309] New: Koha namespace organisation, first implementation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8309 Priority: P1 - high Change sponsored?: --- Bug ID: 8309 Assignee: paul.poulain@biblibre.com Summary: Koha namespace organisation, first implementation Severity: enhancement Classification: Unclassified OS: All Reporter: paul.poulain@biblibre.com Hardware: All Status: ASSIGNED Version: master Component: Architecture, internals, and plumbing Product: Koha During KohaCon12 hackfest, some of us had a discussion about Koha namespace organisation and content. The result was a wiki page: http://wiki.koha-community.org/wiki/Koha_Namespace_RFC I've investigated this organisation by writing some DBIx::Class & Moose packages. The results are great, a lot of code can be removed, and the code is safer. Note that the patches attached here are just a first draft, not requesting sign-off, just comments ! My feedback of this first try: * defining the schema has been easy, thanks to DBIx::Class documentation. Error messages are very clear and easy to understand for a newbie like me ! * investigating a little bit more, there are many tools/tricks that will make us save a lot of time/lines. Like caching (with DBIx::Class::Cursor::Cached), paging (see http://search.cpan.org/~arodland/DBIx-Class-0.08196/lib/DBIx/Class/Manual/Co..., not used in this 1st POC), doing JOIN or finding relations between datas, or returning array of hashrefs (DBIx::Class::ResultClass::HashRefInflator) * cleaning categories.pl resulted in a code that is *much* smaller and readable than the previous one (something like 100 lines removed) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8309 --- Comment #1 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 10473 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10473&action=edit DBIx::Class 1st step: the schema This DBIx::Class schema has been generated using perl -MDBIx::Class::Schema::Loader=make_schema_at,dump_to_dir:.Koha -e 'make_schema_at("temp::Schema", { debug => 1 }, [ "dbi:mysql:dbname=Koha","LOGIN", "PASSWORD" ])' After my 1st tests, I encountered the following problem DBIx::Class::Carp::__ANON__(): "might_have/has_one" must not be on columns with is_nullable set to true (temp::Schema::Result::Borrower/cardnumber). This might indicate an incorrect use of those relationship helpers instead of belongs_to. at /usr/share/perl5/DBIx/Class/Relationship/HasOne.pm line 96 by setting cardnumber to non-nullable I've switched the cardnumber to non-nullable in Borrower.pm -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8309 --- Comment #2 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 10474 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10474&action=edit Branches table management it's called Branch2.pm because I tried another organisation, then switched to this one, which is better I think -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8309 --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 10475 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10475&action=edit Borrowers table management first draft, the interesting part is the testrelation.pl script that shows how to search a patron and access other informations from here What is important is the "prefetch" option in read. With it you'll LEFT join the prefetched table, thus improving performances You can also notice the cache duration of 2 seconds in borrower search. The idea is that, if this sub is called more than once on a given page, there will be only one SQL query. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8309 --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 10476 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10476&action=edit Branchrelation package, 1st draft unused in my tests I think, commiting it just in case -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8309 --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 10477 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10477&action=edit Categories management This package is a POC to manage the Categories table. It contains : * Category.pm (DB, DataObject and BusinessLogic levels) * the Category.t test * categorie.pl DBIx::Classed * updating copyright * removing a lot of useless files * tabs replaced by 4 spaces, result in some minor changes * use [% IF condition %] in templates, to avoid some pl level hacks -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8309 --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 10478 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10478&action=edit DBIx::Class Branch.pm, first try This package, and the test implement CRUD for Branches table. Very basic, but proves we can do many things in a few lines ! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8309 --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> --- mmm... patches not in the historical order, sorry. I made patch 6 (Branch.pm first try) first, then Branches table management (Branch2.pm). To explain : I made some experiments on Branch.pm, then tried something else I called Branch2.pm Branch2.pm seems better, so if we decide to go this way, the original Branch.pm will be dropped and Branch2.pm renamed. As it's just a POC, that's not a big deal I think. In fact, the most important part is the testrelation.pl attached in "Borrowers table management" and Categories management, that include admin/categorie.pl rewritten -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8309 Elliott Davis <elliott@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |elliott@bywatersolutions.co | |m --- Comment #8 from Elliott Davis <elliott@bywatersolutions.com> --- *** Bug 8798 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org