[Bug 9243] New: Bad delete order in sub index_records in rebuild_zebra.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9243 Bug ID: 9243 Summary: Bad delete order in sub index_records in rebuild_zebra.pl Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt@gmail.com Reporter: christophe.croullebois@biblibre.com CC: m.de.rooy@rijksmuseum.nl If we have in the zebraqueue table for the same record, one line "update" and another "delete", the index_records sub in rebuild_zebra.pl treats the delete line first. The result is that the record still exists in zebra. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9243 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt@gmail.com |christophe.croullebois@bibl | |ibre.com --- Comment #1 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- Created attachment 13927 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13927&action=edit proposed patch to test: make changes for a biblio record and save delete the record check in zebraqueue table that you have 2 lines for this record run rebuild zebra.pl -z -b -l 50 Without the patch the record still exist for zebra thx -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9243 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch QA Contact| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9243 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- As far as I can see, this problem is already fixed in master. Your patch introduces the following problem: Can't use an undefined value as a HASH reference at ./rebuild_zebra.pl line 422. This has to do with the uninitialized $records_deleted. Please note however that the routine export_marc_records_from_list gets the deleted records hash and skips these deleted records when creating the file for the update step. This is done in the following rather obscure code: foreach my $record_number ( map { $_->{biblio_auth_number} } grep { !$found{ $_->{biblio_auth_number} }++ } @$entries ) { I tested update and delete with and without your patch. With your patch, the above error occurs. Without your patch, the problem does not occur and the records are deleted from zebra. I suggest to close this report. Do you agree with the above explanation in mind? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9243 --- Comment #3 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- Hello, oups, sorry done too fast. At the beginning it comes from a patch for 3.2 and it was just ask to me to reverse the two blocks. I rebase for master when I saw that the 2 blocks were in the same order also in master, I didn't look further... So you'r right M. de Rooy, yes please close. thx -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9243 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9243 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6492 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9243 --- Comment #4 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- This was solved by Bug 6492 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org