[Bug 43881] New: Vendors_spec.ts receive test depends on the first table row
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43881 Bug ID: 43881 Summary: Vendors_spec.ts receive test depends on the first table row Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: martin.renvoize@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org Target Milestone: --- Vendors_spec.ts "receive should open in the same tab" searches the vendors table for the vendor it created and then clicks "Receive shipments" in tr:first. That assumes the created vendor is the first row, which is only true when no other vendor is returned ahead of it. If another vendor is listed first (for example one left over from an earlier spec), the click goes to the wrong vendor, or the first row has no "Receive shipments" link and the test times out. This is the failure seen on the Debian 12 Jenkins runs. The test should find the row for its own vendor by name. Related: Bug 43880 (the vendors table search listing every active vendor), which made the leftover rows visible. Test plan: 1. Run t/cypress/integration/Acquisitions/Vendors_spec.ts => passes 2. Create another active vendor first (so it sorts before the test vendor) and run it again => still passes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43881 --- Comment #1 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 208646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208646&action=edit Bug 43881: Select the vendor row by name in Vendors_spec.ts The test clicked the first row of the filtered table, which depends on which other vendors exist. Look the row up by the vendor name instead. Test plan: 1. Run t/cypress/integration/Acquisitions/Vendors_spec.ts => SUCCESS 2. Create another active vendor so it sorts first and run it again => SUCCESS Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43881 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43881 --- Comment #2 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Split out of Bug 43880 so it can move independently. The vendors table search currently also returns every active vendor (Bug 43880), which is what exposed this test's reliance on tr:first. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43881 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |martin.renvoize@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43881 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43881 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208646|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43881 --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 208741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208741&action=edit Bug 43881: Select the vendor row by name in Vendors_spec.ts The test clicked the first row of the filtered table, which depends on which other vendors exist. Look the row up by the vendor name instead. Test plan: 1. Run t/cypress/integration/Acquisitions/Vendors_spec.ts => SUCCESS 2. Create another active vendor so it sorts first and run it again => SUCCESS Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43881 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Before the patch the test fails, with the one existing vendor and after adding additional ones. 2. After the patch, the tests pass with one or more existing vendors. 3. Running the tests: cypress run --spec t/cypress/integration/Acquisitions/Vendors_spec.ts -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org