[Bug 43866] New: Patron name and card number should not be clickable in remaining 'Checking out to' headings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43866 Bug ID: 43866 Summary: Patron name and card number should not be clickable in remaining 'Checking out to' headings Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com Depends on: 43220 Target Milestone: --- Follow-up to Bug 43220, which stopped the patron name and card number being a link in the "Checking out to" label above the barcode input on circ/circulation.pl. Two other "Checking out to" headings still render the patron name and card number as a link, by including patron-title.inc without the no_html flag: 1. koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt (around line 1060): an <h4> "Checking out to ..." shown inside the warning circmessage when the patron cannot check out (noissues is set, and OnSiteCheckoutsForce is not enabled). 2. koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation_batch_checkouts.tt (around line 85): the <legend> "Checking out to ..." on the batch checkout page. Pass no_html=1 to patron-title.inc in both places, as Bug 43220 did, so the headings are plain text and consistent with the main checkout form. Test plan: 1. Check out to a patron who is blocked from checking out (for example a restricted or debarred patron) so the warning message with the "Checking out to ..." heading is shown. Note the name and card number are a link. 2. Go to Circulation > Batch check out and select a patron. Note the "Checking out to ..." legend contains a link. 3. Apply the patch and repeat steps 1 and 2. 4. Confirm both headings show the name and card number as plain text, with no link. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43220 [Bug 43220] Patron name and card number should not be clickable in headings -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43866 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43866 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@openfifth.c |ity.org |o.uk -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43866 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@openfifth.c |ity.org |o.uk -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43866 --- Comment #1 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 208734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208734&action=edit Bug 43866: Patron name and card number should not be clickable in remaining 'Checking out to' headings Bug 43220 stopped the patron name and card number being a link in the "Checking out to" label above the barcode input on circ/circulation.pl. Two other "Checking out to" headings still include patron-title.inc without the no_html flag: - the <h4> in the circmessage warning shown when the patron cannot check out (circulation.tt) - the <legend> on the batch checkout page (circulation_batch_checkouts.tt) Pass no_html=1 in both places so the headings are plain text, consistent with the main checkout form. To test: 1. Check out to a patron who is blocked from checking out (for example a restricted or debarred patron) so the warning message with the "Checking out to ..." heading is shown. Note the name and card number are a link. 2. Go to Circulation > Batch check out and select a patron. Note the "Checking out to ..." legend contains a link. 3. Apply the patch and repeat steps 1 and 2. 4. Confirm both headings show the name and card number as plain text, with no link. 5. Confirm the Checking out to label on the normal checkout form is still plain text. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43866 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43866 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43866 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208734|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43866 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 208762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208762&action=edit Bug 43866: Patron name and card number should not be clickable in remaining 'Checking out to' headings Bug 43220 stopped the patron name and card number being a link in the "Checking out to" label above the barcode input on circ/circulation.pl. Two other "Checking out to" headings still include patron-title.inc without the no_html flag: - the <h4> in the circmessage warning shown when the patron cannot check out (circulation.tt) - the <legend> on the batch checkout page (circulation_batch_checkouts.tt) Pass no_html=1 in both places so the headings are plain text, consistent with the main checkout form. To test: 1. Check out to a patron who is blocked from checking out (for example a restricted or debarred patron) so the warning message with the "Checking out to ..." heading is shown. Note the name and card number are a link. 2. Go to Circulation > Batch check out and select a patron. Note the "Checking out to ..." legend contains a link. 3. Apply the patch and repeat steps 1 and 2. 4. Confirm both headings show the name and card number as plain text, with no link. 5. Confirm the Checking out to label on the normal checkout form is still plain text. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43866 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes the "Checking release notes| |out to [patron name (patron | |number)]" messages to | |remove the link for the | |patron name and card number | |for the: | |- checkout page when a | |patron can't check out (for | |example, when they have | |restrictions) | |- batch check out page. | | | |(The standard check out | |page was fixed in Bug 43220 | |- Patron name and card | |number should not be | |clickable in headings.) --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. To enable batch check out (appears as a "Batch check out" section on the patron page under the "Check out" section): - BatchCheckouts: set to Allow - BatchCheckoutsValidCategories: check "Select all" -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org