http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11867 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt@gmail.com |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11867 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25700 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25700&action=edit Bug 11867: MTT: Manage *_PHONE notices The *_PHONE notices (HOLD_PHONE, PREDUE_PHONE and OVERDUE_PHONE) should be "merged" into the main code (i.e. HOLD, PREDUE and OVERDUE). Test plan: 1/ Make sure you have HOLD_PHONE, PREDUE_PHONE and OVERDUE_PHONE notices 2/ Execute the update DB entry 3/ Verify the 3 notices have been merged into "phone" template of the HOLD, PREDUE and OVERDUE notices 4/ Verify there is no regression in the Talking Tech feature (how?) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11867 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|9016 | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11867 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti@jns.fi --- Comment #2 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- -- Merge issues: -- --------------------- git pull git bz apply [9016 10832 10833 10845 11208] So far so good! So then we get the merge error :( http://pastebin.com/PrxXt4t4 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11867 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10845 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11867 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can we get a sign off on this please? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11867 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Problems to test: Bug 9016 gives merge errors, also on updatedatbase.pl (this patch), don't we need if ( CheckVersion($DBversion) ) { instead of if ( C4::Context->preference("Version") < TransformToNum($DBversion) ) { ? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11867 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25761|0 |1 is obsolete| | --- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 27820 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27820&action=edit [SIGNED-OFF] Bug 11867: MTT: Manage *_PHONE notices The *_PHONE notices (HOLD_PHONE, PREDUE_PHONE and OVERDUE_PHONE) should be "merged" into the main code (i.e. HOLD, PREDUE and OVERDUE). Test plan: 1/ Make sure you have HOLD_PHONE, PREDUE_PHONE and OVERDUE_PHONE notices 2/ Execute the update DB entry 3/ Verify the 3 notices have been merged into "phone" template of the HOLD, PREDUE and OVERDUE notices 4/ Verify there is no regression in the Talking Tech feature (how?) Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No koha-qa errors Verified that notices are merged TalkingTech_itiva_outbound.pl runs without problem... but can't produce any output, may be not correctly configured (my setup), no warnings nor log messages -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11867 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #9 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- I'm seeing this code in the Itiva cronjob: my $letter = C4::Letters::GetPreparedLetter( module => $module, letter_code => $code, tables => { borrowers => $issues->{'borrowernumber'}, biblio => $issues->{'biblionumber'}, biblioitems => $issues->{'biblionumber'}, message_transport_type => 'phone', }, message_transport_type => 'phone', ); The duplicated mtt seems odd to me. Is that correct? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11867 --- Comment #11 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Please add the bug number too in the print message of updatedatabase -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11867 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27820|0 |1 is obsolete| | Attachment #27873|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 27875 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27875&action=edit Bug 11867: MTT: Manage *_PHONE notices The *_PHONE notices (HOLD_PHONE, PREDUE_PHONE and OVERDUE_PHONE) should be "merged" into the main code (i.e. HOLD, PREDUE and OVERDUE). Test plan: 1/ Make sure you have HOLD_PHONE, PREDUE_PHONE and OVERDUE_PHONE notices 2/ Execute the update DB entry 3/ Verify the 3 notices have been merged into "phone" template of the HOLD, PREDUE and OVERDUE notices 4/ Verify there is no regression in the Talking Tech feature (how?) Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No koha-qa errors Verified that notices are merged TalkingTech_itiva_outbound.pl runs without problem... but can't produce any output, may be not correctly configured (my setup), no warnings nor log messages -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11867 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27875|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 27876 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27876&action=edit Bug 11867: MTT: Manage *_PHONE notices The *_PHONE notices (HOLD_PHONE, PREDUE_PHONE and OVERDUE_PHONE) should be "merged" into the main code (i.e. HOLD, PREDUE and OVERDUE). Test plan: 1/ Make sure you have HOLD_PHONE, PREDUE_PHONE and OVERDUE_PHONE notices 2/ Execute the update DB entry 3/ Verify the 3 notices have been merged into "phone" template of the HOLD, PREDUE and OVERDUE notices 4/ Verify there is no regression in the Talking Tech feature (how?) Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No koha-qa errors Verified that notices are merged TalkingTech_itiva_outbound.pl runs without problem... but can't produce any output, may be not correctly configured (my setup), no warnings nor log messages -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11867 --- Comment #17 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- The sql construct name=(SELECT name FROM ( SELECT name FROM letter WHERE code= ... LIMIT 1) AS t) does probably not win beauty prices :) You could try something with joining letter in the update statement. But on the other hand why would you? You do not need to change the name for the Phone notices. That name should be fine. Note that the SELECT .. LIMIT 1 will not always provide the best choice; you are not even sure which one he picks. Is it an idea to remove name from the UPDATE? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11867 --- Comment #19 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to M. de Rooy from comment #17)

The sql construct name=(SELECT name FROM ( SELECT name FROM letter WHERE code= ... LIMIT 1) AS t) does probably not win beauty prices :)

Erk

Is it an idea to remove name from the UPDATE?

The name should be the same for all letters with the same code. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11867 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #21 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes.