[Bug 12747] New: Add "call number fields" column in Z3950 search result
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Bug ID: 12747 Summary: Add "call number fields" column in Z3950 search result Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: simith.doliveira@inlibro.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |simith.doliveira@inlibro.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add "call number fields" |Add extra column in Z3950 |column in Z3950 search |search result |result | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 --- Comment #1 from simith.doliveira@inlibro.com --- Created attachment 30713 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30713&action=edit Bug 12747 Add extra column in Z3950 search result This patch permits to add an extra column in Z3950 search result. The system preference AdditionalFieldsInZ3950ResultSearch maps which MARC field/subfields are displayed in the column. Testing: I Apply the patch II Run updatedatabase.pl 0) Enter a field/subfield in the AdditionalFieldsInZ3950ResultSearch; 1) Create a new basket or use an existing one; 2) In -Add order to basket-, click "From an external source"; 3) Select some search targets and enter a subject heading ex. house; 4) Click Search bouton; 5) Validate "Additional fields" column with the field/subfield value. sponsored by the CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |eric.begin@inLibro.com, | |francois.charbonnier@inlibr | |o.com, | |philippe.blouin@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- This seems to work well, but I'm curious why there is no corresponding change to cataloguing/z3950_search.pl? I don't think it works very well to have the additional data displayed in a table cell which doesn't allow text to wrap. If someone picked a subfield which contains a lot of data that could completely blow up the layout. Maybe an unordered list? [% IF additionalFields %] <td> <ul> [% FOREACH addnumberfield IN breeding_loo.addnumberfields %] [% IF ( breeding_loo.$addnumberfield ) %] <li><strong>[% addnumberfield %]:</strong>[% breeding_loo.$addnumberfield %]</li> [% END %] [% END %] </ul> </td> [% END %] Or a definition list? [% IF additionalFields %] <td> <dl> [% FOREACH addnumberfield IN breeding_loo.addnumberfields %] <dt>[% addnumberfield %]:</dt> <dd>[% breeding_loo.$addnumberfield %]</dd> [% END %] </dl> </td> [% END %] -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Status|Needs Signoff |Failed QA --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- This needs an answer. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 --- Comment #4 from simith.doliveira@inlibro.com --- Created attachment 36823 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36823&action=edit Fix table cell -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from simith.doliveira@inlibro.com --- Table cell fixed Owen #2 "why there is no corresponding change to cataloguing/z3950_search.pl? - Our sponsor (CCSR) did not ask for it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11874 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fcapovilla@live.ca --- Comment #6 from Blou <philippe.blouin@inlibro.com> --- *** Bug 11874 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30713|0 |1 is obsolete| | --- Comment #7 from Blou <philippe.blouin@inlibro.com> --- Created attachment 37836 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37836&action=edit Bug 12747 Add extra column in Z3950 search result This patch permits to add an extra column in Z3950 search result. The system preference AdditionalFieldsInZ3950ResultSearch maps which MARC field/subfields are displayed in the column. Testing: I Apply the patch II Run updatedatabase.pl ACQUISITIONS 0) Enter a field/subfield in the AdditionalFieldsInZ3950ResultSearch; 1) Create a new basket or use an existing one; 2) In -Add order to basket-, click "From an external source"; 3) Select some search targets and enter a subject heading ex. house; 4) Click Search bouton; 5) Validate "Additional fields" column with the field/subfield value. CATALOGUING 0) shares same syspref as above 1) Go to cataloguing, click New from z3950 2) fill to result in a successful search 3) validate column Addition Fields sponsored by the CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36823|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Component|Acquisitions |Cataloging Assignee|simith.doliveira@inlibro.co |philippe.blouin@inlibro.com |m | --- Comment #8 from Blou <philippe.blouin@inlibro.com> --- This is a redo of the two previous patches, along with the changes to make it identical in Cataloguing as in Acquisitions (see #11874). I switched the component to Cataloguing since it's the most used or the two, and that "Acquisitions" has a tendency to frighten out would-be testers :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 --- Comment #9 from Marc Véron <veron@veron.ch> --- Created attachment 37893 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37893&action=edit [Signed-off] Bug 12747 Add extra column in Z3950 search result This patch permits to add an extra column in Z3950 search result. The system preference AdditionalFieldsInZ3950ResultSearch maps which MARC field/subfields are displayed in the column. Testing: I Apply the patch II Run updatedatabase.pl ACQUISITIONS 0) Enter a field/subfield in the AdditionalFieldsInZ3950ResultSearch; 1) Create a new basket or use an existing one; 2) In -Add order to basket-, click "From an external source"; 3) Select some search targets and enter a subject heading ex. house; 4) Click Search bouton; 5) Validate "Additional fields" column with the field/subfield value. CATALOGUING 0) shares same syspref as above 1) Go to cataloguing, click New from z3950 2) fill to result in a successful search 3) validate column Addition Fields sponsored by the CCSR ( http://www.ccsr.qc.ca ) Tested in both Acquisition and Cataloguing. Works as expected (and is a great feature). Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Attachment #37836|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- I find the configuration for this to be a bit on the odd side. I'd much prefer to see it use the standard 123$a syntax rather than 123a. In addition, it does not support fields that have no subfields. Another minor issue, no other pref uses semicolons for a separator. It would be better to use a pipe (|) or a space ( which would be my preference ) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |charles.farmer@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 --- Comment #11 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 38221 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38221&action=edit Bug 12747 - Add extra column in Z3950 search result This patch uses the standard field syntax (ex: 023$ab), allows writing fields without mentionning subfields and uses whitespace as a field separator instead of semicolon. sponsored by the CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 --- Comment #12 from Marc Véron <veron@veron.ch> --- Created attachment 38233 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38233&action=edit [Signed-off] Bug 12747 - Add extra column in Z3950 search result This patch uses the standard field syntax (ex: 023$ab), allows writing fields without mentionning subfields and uses whitespace as a field separator instead of semicolon. sponsored by the CCSR ( http://www.ccsr.qc.ca ) Tested with standard field syntax and whitespace. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38221|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38233|0 |1 is obsolete| | --- Comment #13 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 38240 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38240&action=edit Bug 12747 - Add extra column in Z3950 search result This patch uses the standard field syntax (ex: 023$ab), allows writing fields without mentionning subfields and uses whitespace as a field separator instead of semicolon. sponsored by the CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 --- Comment #14 from Charles Farmer <charles.farmer@inlibro.com> --- (In reply to Charles Farmer from comment #13)
Created attachment 38240 [details] [review] Bug 12747 - Add extra column in Z3950 search result
This patch uses the standard field syntax (ex: 023$ab), allows writing fields without mentionning subfields and uses whitespace as a field separator instead of semicolon.
sponsored by the CCSR ( http://www.ccsr.qc.ca )
This patch is basically the same as the one submitted yesterday, except that the cataloguing preference now has proper description of its syntax in the administration panel. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 --- Comment #15 from Marc Véron <veron@veron.ch> --- Applying: Bug 12747 - Add extra column in Z3950 search result fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 12747 - Add extra column in Z3950 search result -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38240|0 |1 is obsolete| | --- Comment #16 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 38286 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38286&action=edit Bug 12747 - Add extra column in Z3950 search result This patch uses the standard field syntax (ex: 023$ab), allows writing fields without mentionning subfields and uses whitespace as a field separator instead of semicolon. sponsored by the CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 --- Comment #17 from Marc Véron <veron@veron.ch> --- Charles, I'm sorry, I was not fast enough, after the newest pushes both patches again do not apply. For the first patch you can remove your changes from installer/data/mysql/updatedatabase.pland follow the new rules in http://wiki.koha-community.org/wiki/Database_updates See part updatedatabase.pl Oh, have a look at C4/Breeding.pm in the second patch, you have remaining lines from merging like: <<<<<<< HEAD ======= (....)
> c4c12ed... Bug 12747 - Add extra column in Z3950 search result
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37893|0 |1 is obsolete| | Attachment #38286|0 |1 is obsolete| | --- Comment #18 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 38439 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38439&action=edit Bug 12747 - Add extra column in Z3950 search This patch permits to add an extra column in Z3950 search result. The system preference AdditionalFieldsInZ3950ResultSearch maps which MARC field/subfields are displayed in the column. Testing: I Apply the patch II Run updatedatabase.pl ACQUISITIONS 0) Enter a field/subfield in the AdditionalFieldsInZ3950ResultSearch; 1) Create a new basket or use an existing one; 2) In -Add order to basket-, click "From an external source"; 3) Select some search targets and enter a subject heading ex. house; 4) Click Search bouton; 5) Validate "Additional fields" column with the field/subfield value. CATALOGUING 0) shares same syspref as above 1) Go to cataloguing, click New from z3950 2) fill to result in a successful search 3) validate column Addition Fields sponsored by the CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 --- Comment #19 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 38440 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38440&action=edit Bug 12747 - Add extra column in Z3950 search result This patch uses the standard field syntax (ex: 023$ab), allows writing fields without mentionning subfields and uses whitespace as a field separator instead of semicolon. sponsored by the CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 --- Comment #20 from Charles Farmer <charles.farmer@inlibro.com> --- These two new patches should do the trick. The code in updatedatabase.pl was moved to an atomicupdate script and the second patch was cleaned of the dangling "<<<< HEAD" stuff. Everything applies cleanly on master for me. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 --- Comment #21 from Marc Véron <veron@veron.ch> --- Created attachment 38456 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38456&action=edit [Signed-off] Bug 12747 - Add extra column in Z3950 search This patch permits to add an extra column in Z3950 search result. The system preference AdditionalFieldsInZ3950ResultSearch maps which MARC field/subfields are displayed in the column. Testing: I Apply the patch II Run updatedatabase.pl ACQUISITIONS 0) Enter a field/subfield in the AdditionalFieldsInZ3950ResultSearch; 1) Create a new basket or use an existing one; 2) In -Add order to basket-, click "From an external source"; 3) Select some search targets and enter a subject heading ex. house; 4) Click Search bouton; 5) Validate "Additional fields" column with the field/subfield value. CATALOGUING 0) shares same syspref as above 1) Go to cataloguing, click New from z3950 2) fill to result in a successful search 3) validate column Addition Fields sponsored by the CCSR ( http://www.ccsr.qc.ca ) Tested both patches together, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38456|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 --- Comment #22 from Marc Véron <veron@veron.ch> --- Created attachment 38457 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38457&action=edit Bug 13606: DBRev 3.19.00.029 Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Tested both patches together, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38457|0 |1 is obsolete| | --- Comment #23 from Marc Véron <veron@veron.ch> --- Comment on attachment 38457 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38457 Bug 13606: DBRev 3.19.00.029 Sorry, mistaked again... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 --- Comment #24 from Marc Véron <veron@veron.ch> --- Created attachment 38458 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38458&action=edit [Signed-off] Bug 12747 - Add extra column in Z3950 search This patch permits to add an extra column in Z3950 search result. The system preference AdditionalFieldsInZ3950ResultSearch maps which MARC field/subfields are displayed in the column. Testing: I Apply the patch II Run updatedatabase.pl ACQUISITIONS 0) Enter a field/subfield in the AdditionalFieldsInZ3950ResultSearch; 1) Create a new basket or use an existing one; 2) In -Add order to basket-, click "From an external source"; 3) Select some search targets and enter a subject heading ex. house; 4) Click Search bouton; 5) Validate "Additional fields" column with the field/subfield value. CATALOGUING 0) shares same syspref as above 1) Go to cataloguing, click New from z3950 2) fill to result in a successful search 3) validate column Addition Fields sponsored by the CCSR ( http://www.ccsr.qc.ca ) Tested with both patches together, followed test plan, works as expected Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38440|0 |1 is obsolete| | --- Comment #25 from Marc Véron <veron@veron.ch> --- Created attachment 38460 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38460&action=edit Bug 12747 - Add extra column in Z3950 search result This patch uses the standard field syntax (ex: 023$ab), allows writing fields without mentionning subfields and uses whitespace as a field separator instead of semicolon. sponsored by the CCSR ( http://www.ccsr.qc.ca ) Tested with both patches, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38439|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #26 from Marc Véron <veron@veron.ch> --- Note: I forgot to add [Signed-off] to title of 2nd patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11266 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 --- Comment #27 from Jonathan Druart <jonathan.druart@biblibre.com> --- Comment on attachment 38458 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38458 [Signed-off] Bug 12747 - Add extra column in Z3950 search Review of attachment 38458: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12747&attachment=38458) ----------------------------------------------------------------- I am sorry to fail qa it again, but you have to provide tests for the change in the C4::Breeding module. I don't ask you to completely cover the subroutine, but at least highlight what the new pref does. ::: C4/Breeding.pm @@ +224,5 @@
+ @servers = (); + foreach my $id (@id) { + push @servers, {id => $id}; + }
This has been removed by commit fb0834e8f582e9e268ecef6de891ba5dc25c6fd9 Bug 6536: Include SRU searching in Breeding.pm Are you sure this change is intended? @@ +232,5 @@
+ if ($pref_addnumber){ + $template->param( + additionalFields => '1', + ); + }
I'd say you don't need to do that. I can just access to the AdditionalFieldsInZ3950ResultSearch value from the template using the Koha TT plugin. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Rémi Mayrand-Provencher <remi.mayrand-provencher@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 --- Comment #28 from Rémi Mayrand-Provencher <remi.mayrand-provencher@inLibro.com> --- Created attachment 41313 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41313&action=edit Bug12747 - Follow-up to QA Removed unnecessary code in Breeding.pm and provided a new test in Breeding.t -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 --- Comment #29 from Rémi Mayrand-Provencher <remi.mayrand-provencher@inLibro.com> --- Created attachment 41317 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41317&action=edit Bug 12747 - Add extra column in Z3950 search This patch permits to add an extra column in Z3950 search result. The system preference AdditionalFieldsInZ3950ResultSearch maps which MARC field/subfields are displayed in the column. Testing: I Apply the patch II Run updatedatabase.pl ACQUISITIONS 0) Enter a field/subfield in the AdditionalFieldsInZ3950ResultSearch 1) Create a new basket or use an existing one 2) In -Add order to basket-, click "From an external source" 3) Select some search targets and enter a subject heading ex. house 4) Click Search bouton 5) Validate "Additional fields" column with the field/subfield value. CATALOGUING 0) shares same syspref as above 1) Go to cataloguing, click New from z3950 2) fill to result in a successful search 3) validate column Addition Fields sponsored by the CCSR ( http://www.ccsr.qc.ca ) Tested with both patches together, followed test plan, works as expected Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Rémi Mayrand-Provencher <remi.mayrand-provencher@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38460|0 |1 is obsolete| | --- Comment #30 from Rémi Mayrand-Provencher <remi.mayrand-provencher@inLibro.com> --- Created attachment 41318 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41318&action=edit Bug 12747 - Add extra column in Z3950 search result This patch uses the standard field syntax (ex: 023$ab), allows writing fields without mentionning subfields and uses whitespace as a field separator instead of semicolon. sponsored by the CCSR ( http://www.ccsr.qc.ca ) Tested with both patches, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Rémi Mayrand-Provencher <remi.mayrand-provencher@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41313|0 |1 is obsolete| | --- Comment #31 from Rémi Mayrand-Provencher <remi.mayrand-provencher@inLibro.com> --- Created attachment 41319 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41319&action=edit Bug12747 - Follow-up to QA Removed unnecessary code in Breeding.pm and provided a new test in Breeding.t -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Rémi Mayrand-Provencher <remi.mayrand-provencher@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |remi.mayrand-provencher@inL | |ibro.com Attachment #38458|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Jerwyn <os.jerwynfernandez@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |os.jerwynfernandez@gmail.co | |m --- Comment #32 from Jerwyn <os.jerwynfernandez@gmail.com> --- If were not mistaken, nothing happen with the patch. Kind regards, -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #33 from Frédéric Demians <frederic@tamil.fr> --- - The patch doesn't apply anymore on master. There is a conflict on .pref template. - I'd personally prefer a unique patch rather than 3 consecutive patches. - The UT doesn't work with a Unimarc DB. It fails because the biblio record constructed in the test has a title in 245 tag. In Unimarc, title is in 200. I don't know it is considered problematic by QAers. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 --- Comment #34 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Frédéric Demians from comment #33)
- The UT doesn't work with a Unimarc DB. It fails because the biblio record constructed in the test has a title in 245 tag. In Unimarc, title is in 200. I don't know it is considered problematic by QAers.
No it's not. The requirement is that the tests must pass on a "fresh" MARC21 DB with all sample data. We tend to ask for the tests to create their own data (using t::lib::TestBuilder for instance) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org