[Bug 35169] New: Make long overdue borrower category options configurable in interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 Bug ID: 35169 Summary: Make long overdue borrower category options configurable in interface Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: lisette.scheer@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: robin@catalyst.net.nz Being able to set the borrower category options: 'category=s' => $borrower_category, 'skip-category=s' => $skip_borrower_category Via the staff interface would be really helpful for users being able to update their longoverdue settings without needing to edit the command line. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 Lisette Scheer <lisette.scheer@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35170 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 Matthias Le Gac <matthias.le-gac@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matthias.le-gac@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 Matthias Le Gac <matthias.le-gac@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com, | |philippe.blouin@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 Matthias Le Gac <matthias.le-gac@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 --- Comment #1 from Matthias Le Gac <matthias.le-gac@inlibro.com> --- Created attachment 162340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162340&action=edit Bug 35169: Make long overdue borrower category options configurable in interface Test Plan : 1 - Apply the patch 2 - Go to Koha administration > System preferences > Circulation > Checkout policy 3 - Set "DefaultLongOverdueLostValue" to "Lost" and "DefaultLongOverdueDays" to "2" 4 - Check out an item to a patron and set the date to more than two days. 5 - Remember the category of the patron Test of DefaultLongOverdueBorrowerCategories option : 6 - Go to Koha administration > System preferences > Circulation > Checkout policy 7 - Set "DefaultLongOverdueBorrowerCategories" to the category of the patron 8 - Go to the terminal in the koha environment and execute the script "./misc/cronjobs/longoverdue.pl" 9 - Normaly you see in list the check out item set just before and the list it's only borrowers with the category Test of DefaultLongOverdueSkipBorrowerCategories option : 10 - Go to Koha administration > System preferences > Circulation > Checkout policy 11 - Set "DefaultLongOverdueSkipBorrowerCategories" to the category of the patron 12 - Go to the terminal in the koha environment and execute the script "./misc/cronjobs/longoverdue.pl" 13 - Normaly you don't see in list the check out item set just before and the list it's only borrowers with others categories Test of warning : 14 - Go to Koha administration > System preferences > Circulation > Checkout policy 15 - Set "DefaultLongOverdueBorrowerCategories" to the category of the patron and Set "DefaultLongOverdueSkipBorrowerCategories" to the category of the patron 16 - Go to the terminal in the koha environment and execute the script "./misc/cronjobs/longoverdue.pl" 17 - Normaly you don't see in list the check out item set just before because the "DefaultLongOverdueSkipBorrowerCategories" take advantage of "DefaultLongOverdueBorrowerCategories" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 Matthias Le Gac <matthias.le-gac@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 Matthias Le Gac <matthias.le-gac@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162340|0 |1 is obsolete| | --- Comment #2 from Matthias Le Gac <matthias.le-gac@inlibro.com> --- Created attachment 162345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162345&action=edit Bug 35169: Make long overdue borrower category options configurable in interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 Matthias Le Gac <matthias.le-gac@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 --- Comment #3 from Matthias Le Gac <matthias.le-gac@inlibro.com> --- Created attachment 162346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162346&action=edit Bug 35169: add bug_35169.pl for DB -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Matthias, Can you update sysprefs.sql to include the new system preferences? You also need to use INSERT IGNORE INTO in your database update. Also, perltidy :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 Matthias Le Gac <matthias.le-gac@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 --- Comment #5 from Matthias Le Gac <matthias.le-gac@inlibro.com> --- Created attachment 162611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162611&action=edit Bug 35169: update sysprefs.sql Test Plan : 1 - Apply the patch 2 - Go to Koha administration > System preferences > Circulation > Checkout policy 3 - Set "DefaultLongOverdueLostValue" to "Lost" and "DefaultLongOverdueDays" to "2" 4 - Check out an item to a patron and set the date to more than two days. 5 - Remember the category of the patron Test of DefaultLongOverdueBorrowerCategories option : 6 - Go to Koha administration > System preferences > Circulation > Checkout policy 7 - Set "DefaultLongOverdueBorrowerCategories" to the category of the patron 8 - Go to the terminal in the koha environment and execute the script "./misc/cronjobs/longoverdue.pl" 9 - Normaly you see in list the check out item set just before and the list it's only borrowers with the category Test of DefaultLongOverdueSkipBorrowerCategories option : 10 - Go to Koha administration > System preferences > Circulation > Checkout policy 11 - Set "DefaultLongOverdueSkipBorrowerCategories" to the category of the patron 12 - Go to the terminal in the koha environment and execute the script "./misc/cronjobs/longoverdue.pl" 13 - Normaly you don't see in list the check out item set just before and the list it's only borrowers with others categories Test of warning : 14 - Go to Koha administration > System preferences > Circulation > Checkout policy 15 - Set "DefaultLongOverdueBorrowerCategories" to the category of the patron and Set "DefaultLongOverdueSkipBorrowerCategories" to the category of the patron 16 - Go to the terminal in the koha environment and execute the script "./misc/cronjobs/longoverdue.pl" 17 - Normaly you don't see in list the check out item set just before because the "DefaultLongOverdueSkipBorrowerCategories" take advantage of "DefaultLongOverdueBorrowerCategories" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 --- Comment #6 from Matthias Le Gac <matthias.le-gac@inlibro.com> --- Lucas, Tell me if the update of sysprefs.sql is good. It's the first time I am doing this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Matthias, I tested this and it seems to work as intended, you sysprefs.sql update looks good to me. However, your DBUpdate explanation and type should not be NULL. Sorry to be a pain! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 Matthias Le Gac <matthias.le-gac@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 --- Comment #8 from Matthias Le Gac <matthias.le-gac@inlibro.com> --- Created attachment 162667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162667&action=edit Bug 35169: update DBupdate file Test Plan : 1 - Apply the patch 2 - Go to Koha administration > System preferences > Circulation > Checkout policy 3 - Set "DefaultLongOverdueLostValue" to "Lost" and "DefaultLongOverdueDays" to "2" 4 - Check out an item to a patron and set the date to more than two days. 5 - Remember the category of the patron Test of DefaultLongOverdueBorrowerCategories option : 6 - Go to Koha administration > System preferences > Circulation > Checkout policy 7 - Set "DefaultLongOverdueBorrowerCategories" to the category of the patron 8 - Go to the terminal in the koha environment and execute the script "./misc/cronjobs/longoverdue.pl" 9 - Normaly you see in list the check out item set just before and the list it's only borrowers with the category Test of DefaultLongOverdueSkipBorrowerCategories option : 10 - Go to Koha administration > System preferences > Circulation > Checkout policy 11 - Set "DefaultLongOverdueSkipBorrowerCategories" to the category of the patron 12 - Go to the terminal in the koha environment and execute the script "./misc/cronjobs/longoverdue.pl" 13 - Normaly you don't see in list the check out item set just before and the list it's only borrowers with others categories Test of warning : 14 - Go to Koha administration > System preferences > Circulation > Checkout policy 15 - Set "DefaultLongOverdueBorrowerCategories" to the category of the patron and Set "DefaultLongOverdueSkipBorrowerCategories" to the category of the patron 16 - Go to the terminal in the koha environment and execute the script "./misc/cronjobs/longoverdue.pl" 17 - Normaly you don't see in list the check out item set just before because the "DefaultLongOverdueSkipBorrowerCategories" take advantage of "DefaultLongOverdueBorrowerCategories" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 --- Comment #9 from Matthias Le Gac <matthias.le-gac@inlibro.com> --- (In reply to Lucas Gass from comment #7)
Matthias,
I tested this and it seems to work as intended, you sysprefs.sql update looks good to me.
However, your DBUpdate explanation and type should not be NULL. Sorry to be a pain!
Thank you for your feedback. Normally it's good now. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- Matthias, Looking closer here. If you add values to the new system preferences they override what is added at the cron level? Then you probably need to add a better description about what is happening in the POD? Also, if you use the system preferences now you are unable to configure the cron differently and run it more than once. For example you might want to do something like this: longoverdue.pl --skip-category PT --lost 14=2 --confirm longoverdue.pl --skip-category PT2 --lost 21=2 --confirm That seems like it could be a problem? I won't fail this again. I'll let someone else have a look and give opinions. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 --- Comment #11 from Lisette Scheer <lisette.scheer@bywatersolutions.com> --- I agree with Lucas that it's a problem you can't set different options for different patron categories. Currently you can set not only to skip, but also to have different patron types go to lost at different times at the cron level (such as having staff go to lost at 365 when the default is 60.) The skip default is good, but this doesn't really address the other part where you can set different rules by category. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 --- Comment #12 from Matthias Le Gac <matthias.le-gac@inlibro.com> --- (In reply to Lucas Gass from comment #10)
Matthias,
Looking closer here. If you add values to the new system preferences they override what is added at the cron level? Then you probably need to add a better description about what is happening in the POD?
Also, if you use the system preferences now you are unable to configure the cron differently and run it more than once. For example you might want to do something like this:
longoverdue.pl --skip-category PT --lost 14=2 --confirm longoverdue.pl --skip-category PT2 --lost 21=2 --confirm
That seems like it could be a problem?
I won't fail this again. I'll let someone else have a look and give opinions.
I'll look into that to implement the correct behavior. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 Matthias Le Gac <matthias.le-gac@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 Matthias Le Gac <matthias.le-gac@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 --- Comment #13 from Matthias Le Gac <matthias.le-gac@inlibro.com> --- Created attachment 162688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162688&action=edit Bug 35169: Resolve the override situations Test Plan : 1 - Apply the patch 2 - Go to Koha administration > System preferences > Circulation > Checkout policy 3 - Set "DefaultLongOverdueLostValue" to "Lost" and "DefaultLongOverdueDays" to "2" 4 - Check out an item to a patron and set the date to more than two days. 5 - Remember the category of the patron Test of DefaultLongOverdueBorrowerCategories option : 6 - Go to Koha administration > System preferences > Circulation > Checkout policy 7 - Set "DefaultLongOverdueBorrowerCategories" to the category of the patron 8 - Go to the terminal in the koha environment and execute the script "./misc/cronjobs/longoverdue.pl" 9 - Normaly you see in list the check out item set just before and the list it's only borrowers with the category Test of DefaultLongOverdueSkipBorrowerCategories option : 10 - Go to Koha administration > System preferences > Circulation > Checkout policy 11 - Set "DefaultLongOverdueSkipBorrowerCategories" to the category of the patron 12 - Go to the terminal in the koha environment and execute the script "./misc/cronjobs/longoverdue.pl" 13 - Normaly you don't see in list the check out item set just before and the list it's only borrowers with others categories Test of warning : 14 - Go to Koha administration > System preferences > Circulation > Checkout policy 15 - Set "DefaultLongOverdueBorrowerCategories" to the category of the patron and Set "DefaultLongOverdueSkipBorrowerCategories" to the category of the patron 16 - Go to the terminal in the koha environment and execute the script "./misc/cronjobs/longoverdue.pl" 17 - Normaly you don't see in list the check out item set just before because the "DefaultLongOverdueSkipBorrowerCategories" take advantage of "DefaultLongOverdueBorrowerCategories" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 Lisette Scheer <lisette.scheer@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #14 from Lisette Scheer <lisette.scheer@bywatersolutions.com> --- Currently, you can set different lengths for different patrons, running the cron multiple times with different settings. Ideally a solution in the staff interface would also allow this. This + the option to add different settings at the patron category level with different settings would be ideal: longoverdue.pl --skip-category PT --lost 14=2 --confirm longoverdue.pl --skip-category PT2 --lost 21=2 --confirm -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 --- Comment #15 from Matthias Le Gac <matthias.le-gac@inlibro.com> --- (In reply to Lisette Scheer from comment #14)
Currently, you can set different lengths for different patrons, running the cron multiple times with different settings. Ideally a solution in the staff interface would also allow this. This + the option to add different settings at the patron category level with different settings would be ideal:
longoverdue.pl --skip-category PT --lost 14=2 --confirm longoverdue.pl --skip-category PT2 --lost 21=2 --confirm
Currently, you can't set different values for DefaultLongOverdueLostValue and DefaultLongOverdueLostValue from the interface. So it's not possible to have two longoverdue.pl running at the same time if they're set from the interface. So I think it would be an improvement on all longoverdue.pl system preferences, not just on categories. I'm not sure it's directly related to this bz. Tell me what you think? For presition longoverdue.pl doesn't allow DefaultLongOverdueBorrowerCategories and DefaultLongOverdueSkipBorrowerCategories to be used at the same time. If they are used at the same time, DefaultLongOverdueSkipBorrowerCategories will override DefaultLongOverdueBorrowerCategories. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 Matthias Le Gac <matthias.le-gac@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |matthias.le-gac@inlibro.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 --- Comment #16 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 163008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163008&action=edit Bug 35169: (follow-up) perltidy Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162345|0 |1 is obsolete| | Attachment #162346|0 |1 is obsolete| | Attachment #162611|0 |1 is obsolete| | Attachment #162667|0 |1 is obsolete| | Attachment #162688|0 |1 is obsolete| | Attachment #163008|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 166121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166121&action=edit Bug 35169: Make long overdue borrower category options configurable in interface Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 166122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166122&action=edit Bug 35169: add bug_35169.pl for DB Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 166123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166123&action=edit Bug 35169: update sysprefs.sql Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 166124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166124&action=edit Bug 35169: update DBupdate file Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 166125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166125&action=edit Bug 35169: Resolve the override situations Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 --- Comment #22 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 166126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166126&action=edit Bug 35169: (follow-up) perltidy Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 --- Comment #23 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 166127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166127&action=edit Bug 35169: (QA follow-up) Fix up syspref language and group them together The language used in the syspref preferences was a bit confusing. Also, it makes sense to keep these two together on the page as they are intrinsically linked. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Small things, but please provide a follow-up: 1) Terminology: DefaultLongOverdueSkipBorrowerCategories DefaultLongOverdueSkipBorrowerCategories I have checked, we have no other BorrowerCategories system preferences, but we have suggestionPatronCategoryExceptions. I think it's worthwhile to make these *PatronCategories. Also in sysprefs.sql and the database update: +('DefaultLongOverdueBorrowerCategories', '', NULL, "Set the borrower categories that will be listed when longoverdue cronjob is executed", 'choice'), -> patron categories 2) Typo Set the default patron categories to recieve overdues to Set the default patron categories to recieve overdues to -> receive 3) Sponsorship Just asking as the new version of the QA script keeps asking me about it! :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Make long overdue borrower |Make long overdue patron |category options |category options |configurable in interface |configurable in interface Keywords| |rel_24_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166256&action=edit Bug 35169: (QA follow-up) Fix spelling and preference name Update the preference name from 'Borrower' to 'Patron' and correct spelling of receive. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #27 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not backported to 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This adds two new system release notes| |preferences | |`DefaultLongOverduePatronCa | |tegories` and | |`DefaultLongOverdueSkipPatr | |onCategories` that allow | |for additional | |configuration of the | |`longoverdue.pl` CLI script | |directly from the staff | |interface. The settings of | |the system preferences will | |be used when the script is | |called without the | |corresponding options. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38053 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38053 [Bug 38053] Change section and description of DefaultLongOverduePatronCategories and DefaultLongOverdueSkipPatronCategories system preferences -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Caroline Cyr La Rose contact| | Status|Needs documenting |RESOLVED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/967 Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org