[Bug 27652] New: Offer selections for preferences which ask for patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27652 Bug ID: 27652 Summary: Offer selections for preferences which ask for patron categories Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com We have several system preferences where the user is supposed to enter a patron category, but it's a text input. These should offer selections of existing patron categories to prevent data errors. Ideally we'd have two ways to configure the preferences: As a single <select> ("choices" in the pref file) or multiple select ("multiple" in the pref file). PatronSelfRegistrationDefaultCategory - single GoogleOpenIDConnectDefaultCategory - single OPACHoldsIfAvailableAtPickup - multiple BatchCheckouts - multiple -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27652 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27652 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 116605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116605&action=edit Bug 27652: Display patron's categories for sysprefs expecting them -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27652 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Feel lazy today to write a test plan for that patch, but it seems to work correctly so far. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27652 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Thanks Jonathan! I'll test and add a test plan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27652 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27652 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116605|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 116687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116687&action=edit Bug 27652: Display patron's categories for sysprefs expecting them This patch adds a new type of system preference entry option: patron category. A preference with this type will show either a <select> with patron categories to choose from or a multiple-select menu for choosing one or more. This prevents possible errors from incorrect category codes being entered manually. To test, apply the patch and run the database update. - Go to Administration -> System preferences. - Test each of the updated preferences to confirm that the available options are correct and that your selections are correctly saved. - Single category selections, PatronSelfRegistrationDefaultCategory and GoogleOpenIDConnectDefaultCategory. With each of these you should see a dropdown where you can select of all the existing patron categories. - Multiple selections, OPACHoldsIfAvailableAtPickup and BatchCheckouts: These preferences should have an option for selecting one or more system preferences at once. - Test the pages affected by the updated system preferences: - With BatchCheckouts enabled, confirm that the batch checkout page is correctly limited by patron category. - Set the OPACHoldsIfAvailableAtPickup preference to "Don't allow" and select at least one patron category in the OPACHoldsIfAvailableAtPickupExceptions preference. - Log in to the OPAC as a patron whose category was not selected in the OPACHoldsIfAvailableAtPickupExceptions preference. - Try to place a hold on an item which is available at a library. - When confirming the hold, the libraries where the item is available should be disabled in the "Pick up location" dropdown. - Repeat the process as a patron whose category was selected in OPACHoldsIfAvailableAtPickupExceptions. There should be no disabled pickup locations. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27652 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 116688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116688&action=edit Bug 27652: (follow-up) Correct typo in database update This patch adds a missing "SET" in the database update. Before: UPDATE systempreferences value=REPLACE(value, '|', ',') Corrected: UPDATE systempreferences SET value=REPLACE(value, '|', ',') -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27652 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27652 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116687|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 117225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117225&action=edit Bug 27652: Display patron's categories for sysprefs expecting them This patch adds a new type of system preference entry option: patron category. A preference with this type will show either a <select> with patron categories to choose from or a multiple-select menu for choosing one or more. This prevents possible errors from incorrect category codes being entered manually. To test, apply the patch and run the database update. - Go to Administration -> System preferences. - Test each of the updated preferences to confirm that the available options are correct and that your selections are correctly saved. - Single category selections, PatronSelfRegistrationDefaultCategory and GoogleOpenIDConnectDefaultCategory. With each of these you should see a dropdown where you can select of all the existing patron categories. - Multiple selections, OPACHoldsIfAvailableAtPickup and BatchCheckouts: These preferences should have an option for selecting one or more system preferences at once. - Test the pages affected by the updated system preferences: - With BatchCheckouts enabled, confirm that the batch checkout page is correctly limited by patron category. - Set the OPACHoldsIfAvailableAtPickup preference to "Don't allow" and select at least one patron category in the OPACHoldsIfAvailableAtPickupExceptions preference. - Log in to the OPAC as a patron whose category was not selected in the OPACHoldsIfAvailableAtPickupExceptions preference. - Try to place a hold on an item which is available at a library. - When confirming the hold, the libraries where the item is available should be disabled in the "Pick up location" dropdown. - Repeat the process as a patron whose category was selected in OPACHoldsIfAvailableAtPickupExceptions. There should be no disabled pickup locations. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27652 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116688|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 117226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117226&action=edit Bug 27652: (follow-up) Correct typo in database update This patch adds a missing "SET" in the database update. Before: UPDATE systempreferences value=REPLACE(value, '|', ',') Corrected: UPDATE systempreferences SET value=REPLACE(value, '|', ',') Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27652 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This enhancement to system release notes| |preferences lets you select | |patron categories from a | |dropdown list, instead of | |manually entering patron | |category codes. This | |prevents possible errors | |from manually entering | |incorrect codes. | | | |This is | |enabled for these system | |preferences: | |- | |PatronSelfRegistrationDefau | |ltCategory (single option) | |- | |GoogleOpenIDConnectDefaultC | |ategory (single option) | |- | |OPACHoldsIfAvailableAtPicku | |p (multiple options) | |- | |BatchCheckouts (multiple | |options) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27652 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I love this improvement, but I think I found a problem: When you use select all it selects all checkboxes, but it saved to my database as 0. Tested with the BatchCheckouts preference. I did run the database update. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27652 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #8)
I love this improvement, but I think I found a problem:
When you use select all it selects all checkboxes, but it saved to my database as 0. Tested with the BatchCheckouts preference. I did run the database update.
Scratch that - I looked at the wrong preference... and forgot to turn the feature on *sigh* -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27652 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27652 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27652 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117225|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 117892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117892&action=edit Bug 27652: Display patron's categories for sysprefs expecting them This patch adds a new type of system preference entry option: patron category. A preference with this type will show either a <select> with patron categories to choose from or a multiple-select menu for choosing one or more. This prevents possible errors from incorrect category codes being entered manually. To test, apply the patch and run the database update. - Go to Administration -> System preferences. - Test each of the updated preferences to confirm that the available options are correct and that your selections are correctly saved. - Single category selections, PatronSelfRegistrationDefaultCategory and GoogleOpenIDConnectDefaultCategory. With each of these you should see a dropdown where you can select of all the existing patron categories. - Multiple selections, OPACHoldsIfAvailableAtPickup and BatchCheckouts: These preferences should have an option for selecting one or more system preferences at once. - Test the pages affected by the updated system preferences: - With BatchCheckouts enabled, confirm that the batch checkout page is correctly limited by patron category. - Set the OPACHoldsIfAvailableAtPickup preference to "Don't allow" and select at least one patron category in the OPACHoldsIfAvailableAtPickupExceptions preference. - Log in to the OPAC as a patron whose category was not selected in the OPACHoldsIfAvailableAtPickupExceptions preference. - Try to place a hold on an item which is available at a library. - When confirming the hold, the libraries where the item is available should be disabled in the "Pick up location" dropdown. - Repeat the process as a patron whose category was selected in OPACHoldsIfAvailableAtPickupExceptions. There should be no disabled pickup locations. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27652 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117226|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 117893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117893&action=edit Bug 27652: (follow-up) Correct typo in database update This patch adds a missing "SET" in the database update. Before: UPDATE systempreferences value=REPLACE(value, '|', ',') Corrected: UPDATE systempreferences SET value=REPLACE(value, '|', ',') Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27652 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27652 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27652 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27652 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27652 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Manual | Documentation| |Caroline Cyr La Rose contact| | CC| |caroline.cyr-la-rose@inlibr | |o.com Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/968 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org