[Bug 27269] New: Move C4::Biblio::GetMarcSubjects to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27269 Bug ID: 27269 Summary: Move C4::Biblio::GetMarcSubjects to Koha namespace Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27269 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |aleisha@catalyst.net.nz |ity.org | Change sponsored?|--- |Sponsored Blocks| |3150 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 [Bug 3150] Move emails for sending cart and list contents into notices tool -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27269 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27269 --- Comment #1 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 114505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114505&action=edit Bug 27269: Move GetMarcSubjects to Koha namespace This patch moves C4::Biblio::GetMarcSubjects to Koha::Biblio->get_marc_subjects. This is so get_marc_subjects can be used in templates and notices. To test: 1. Find a record that has a subject (6xx). 2. Add the record to the cart and a list. 3. View your cart and click 'more details'. Confirm subjects show as normal. 4. Click 'send' and confirm the email sent shows the subjects as normal. 5. Go to the list you added the record to and click 'send list'. Confirm the email sent shows the ubjectsas normal. 6. Set the OPACXSLTDetailsDisplay system preference to empty (for no xslt) 7. Log in to the OPAC. Find the record and add it to the cart and a list 8. View the cart and click 'more details'. Confirm subjects show as normal. 9. Click 'send' and confirm the email sent shows the subjects as normal. 10. Go to the list you added the record to and click 'send list'. Confirm the email sent shows the subjects as normal. 11. View the record detail page and confirm the subjects show as normal. 12. Confirm tests pass: - t/Biblio.t - t/db_dependent/Koha/Biblio.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27269 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|3150 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 [Bug 3150] Move emails for sending cart and list contents into notices tool -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27269 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29441 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27269 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala@iki.fi Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Doesn't apply anymore :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27269 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27269 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114505|0 |1 is obsolete| | --- Comment #3 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 146568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146568&action=edit Bug 27269: Move GetMarcSubjects to Koha namespace This patch moves C4::Biblio::GetMarcSubjects to Koha::Biblio->get_marc_subjects. This is so get_marc_subjects can be used in templates and notices. To test: 1. Find a record that has a subject (6xx). 2. Add the record to the cart and a list. 3. View your cart and click 'more details'. Confirm subjects show as normal. 4. Click 'send' and confirm the email sent shows the subjects as normal. 5. Go to the list you added the record to and click 'send list'. Confirm the email sent shows the ubjectsas normal. 6. Set the OPACXSLTDetailsDisplay system preference to empty (for no xslt) 7. Log in to the OPAC. Find the record and add it to the cart and a list 8. View the cart and click 'more details'. Confirm subjects show as normal. 9. Click 'send' and confirm the email sent shows the subjects as normal. 10. Go to the list you added the record to and click 'send list'. Confirm the email sent shows the subjects as normal. 11. View the record detail page and confirm the subjects show as normal. 12. Confirm tests pass: - t/Biblio.t - t/db_dependent/Koha/Biblio.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27269 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Sorry this needs to be rebased again -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27269 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27269 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146568|0 |1 is obsolete| | --- Comment #5 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 151772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151772&action=edit Bug 27269: Move GetMarcSubjects to Koha namespace This patch moves C4::Biblio::GetMarcSubjects to Koha::Biblio->get_marc_subjects. This is so get_marc_subjects can be used in templates and notices. To test: 1. Find a record that has a subject (6xx). 2. Add the record to the cart and a list. 3. View your cart and click 'more details'. Confirm subjects show as normal. 4. Click 'send' and confirm the email sent shows the subjects as normal. 5. Go to the list you added the record to and click 'send list'. Confirm the email sent shows the ubjectsas normal. 6. Set the OPACXSLTDetailsDisplay system preference to empty (for no xslt) 7. Log in to the OPAC. Find the record and add it to the cart and a list 8. View the cart and click 'more details'. Confirm subjects show as normal. 9. Click 'send' and confirm the email sent shows the subjects as normal. 10. Go to the list you added the record to and click 'send list'. Confirm the email sent shows the subjects as normal. 11. View the record detail page and confirm the subjects show as normal. 12. Confirm tests pass: - t/Biblio.t - t/db_dependent/Koha/Biblio.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27269 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27269 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151772|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 151793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151793&action=edit Bug 27269: Move GetMarcSubjects to Koha namespace This patch moves C4::Biblio::GetMarcSubjects to Koha::Biblio->get_marc_subjects. This is so get_marc_subjects can be used in templates and notices. To test: 1. Find a record that has a subject (6xx). 2. Add the record to the cart and a list. 3. View your cart and click 'more details'. Confirm subjects show as normal. 4. Click 'send' and confirm the email sent shows the subjects as normal. 5. Go to the list you added the record to and click 'send list'. Confirm the email sent shows the ubjectsas normal. 6. Set the OPACXSLTDetailsDisplay system preference to empty (for no xslt) 7. Log in to the OPAC. Find the record and add it to the cart and a list 8. View the cart and click 'more details'. Confirm subjects show as normal. 9. Click 'send' and confirm the email sent shows the subjects as normal. 10. Go to the list you added the record to and click 'send list'. Confirm the email sent shows the subjects as normal. 11. View the record detail page and confirm the subjects show as normal. 12. Confirm tests pass: - t/Biblio.t - t/db_dependent/Koha/Biblio.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27269 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> ---
4. Click 'send' and confirm the email sent shows the subjects as normal.
None of the emails sent according to the test plan include subject information, but that is true in master too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27269 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27269 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27269 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151793|0 |1 is obsolete| | --- Comment #8 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 159069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159069&action=edit Bug 27269: Move GetMarcSubjects to Koha namespace This patch moves C4::Biblio::GetMarcSubjects to Koha::Biblio->get_marc_subjects. This is so get_marc_subjects can be used in templates and notices. To test: 1. Find a record that has a subject (6xx). 2. Add the record to the cart and a list. 3. View your cart and click 'more details'. Confirm subjects show as normal. 4. Click 'send' and confirm the email sent shows the subjects as normal. 5. Go to the list you added the record to and click 'send list'. Confirm the email sent shows the ubjectsas normal. 6. Set the OPACXSLTDetailsDisplay system preference to empty (for no xslt) 7. Log in to the OPAC. Find the record and add it to the cart and a list 8. View the cart and click 'more details'. Confirm subjects show as normal. 9. Click 'send' and confirm the email sent shows the subjects as normal. 10. Go to the list you added the record to and click 'send list'. Confirm the email sent shows the subjects as normal. 11. View the record detail page and confirm the subjects show as normal. 12. Confirm tests pass: - t/Biblio.t - t/db_dependent/Koha/Biblio.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27269 Phan Tung Bui <phan-tung.bui@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |phan-tung.bui@inlibro.com --- Comment #9 from Phan Tung Bui <phan-tung.bui@inlibro.com> --- So here how i do the test - Apply the patch - Add a record which contains 2-3 subjects into the cart - Send it to a random selected Email - Go to the database and find the email in message_queue - Absence of subject in the email -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27269 --- Comment #10 from Phan Tung Bui <phan-tung.bui@inlibro.com> --- phan -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27269 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Hi all. Is this still going to be pursued? The codebase has moved into a pattern implemented by Koha::Biblio::Metadata::Extractor. This is where this needs to be moved. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27269 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|aleisha@catalyst.net.nz |koha-bugs@lists.koha-commun | |ity.org --- Comment #12 from Aleisha Amohia <aleisha@catalyst.net.nz> --- I'm not working on this right now. I'll remove myself as Assignee. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org