[Bug 15775] New: User should know when they are blocked from checkouts on OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 Bug ID: 15775 Summary: User should know when they are blocked from checkouts on OPAC Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: aleishaamohia@hotmail.com QA Contact: testopia@bugs.koha-community.org When a user has been blocked from checkouts in the staff client for having too many fines, they are not told about being blocked until they try to place a hold on an item in the OPAC. They should have a message about it on the summary page which they'll see as soon as they log in. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 --- Comment #1 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 47831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47831&action=edit Bug 15775 - User should know when they are blocked from checkouts on OPAC When a user has been blocked from checkouts in the staff client for having too many fines, they will now see a message about this in the OPAC To test: - Apply Bug 15374, then this patch - This patch will be easiest to test if you keep three tabs open - system preferences, a patron detail page, and OPAC summary page - Set some system preferences: - OPACFineNoRenewals = 2 - noissuescharge = 4 - OpacRenewalAllowed = Allow - Set up a patron with fines of $3 - Log in to the OPAC and verify the message from patch from Bug 15374, saying the user cannot renew books. Confirm link to accounts page works. - Set OpacRenewalAllowed = Don't allow - Refresh OPAC Summary and confirm the message disappears - Set OpacRenewalAllowed = Allow - Give the patron total fines of $5 (add $2) - Refresh OPAC Summary and verify message appears saying user is BLOCKED from checkouts. Confirm link to accounts page works - Set OpacRenewalAllowed = Don't allow - Refresh OPAC Summary and confirm message is still there Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|oleonard@myacpl.org |aleishaamohia@hotmail.com Depends on| |15374 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 [Bug 15374] Translatability: Fix issues on OPAC summary page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47831|0 |1 is obsolete| | --- Comment #2 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 47833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47833&action=edit Bug 15775 - User should know when they are blocked from checkouts on OPAC When a user has been blocked from checkouts in the staff client for having too many fines, they will now see a message about this in the OPAC To test: - Apply Bug 15374, then this patch - This patch will be easiest to test if you keep three tabs open - system preferences, a patron detail page, and OPAC summary page - Set some system preferences: - OPACFineNoRenewals = 2 - noissuescharge = 4 - OpacRenewalAllowed = Allow - Set up a patron with fines of $3 - Log in to the OPAC and verify the message from patch from Bug 15374, saying the user cannot renew books. Confirm link to accounts page works. - Set OpacRenewalAllowed = Don't allow - Refresh OPAC Summary and confirm the message disappears - Set OpacRenewalAllowed = Allow - Give the patron total fines of $5 (add $2) - Refresh OPAC Summary and verify message appears saying user is BLOCKED from checkouts. Confirm link to accounts page works - Set OpacRenewalAllowed = Don't allow - Refresh OPAC Summary and confirm message is still there Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |veron@veron.ch --- Comment #3 from Marc Véron <veron@veron.ch> --- Hi Aleisha, If I apply this patch on top of Bug 15374, I get merge conflicts. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47833|0 |1 is obsolete| | --- Comment #4 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 47937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47937&action=edit Bug 15775 - User should know when they are blocked from checkouts on OPAC When a user has been blocked from checkouts in the staff client for having too many fines, they will now see a message about this in the OPAC To test: - This patch will be easiest to test if you keep three tabs open - system preferences, a patron detail page, and OPAC summary page - Set some system preferences: - OPACFineNoRenewals = 2 - noissuescharge = 4 - OpacRenewalAllowed = Allow - Set up a patron with fines of $3 - Log in to the OPAC and verify the message from patch from Bug 15374, saying the user cannot renew books. Confirm link to accounts page works. - Set OpacRenewalAllowed = Don't allow - Refresh OPAC Summary and confirm the message disappears - Set OpacRenewalAllowed = Allow - Give the patron total fines of $5 (add $2) - Refresh OPAC Summary and verify message appears saying user is BLOCKED from checkouts. Confirm link to accounts page works - Set OpacRenewalAllowed = Don't allow - Refresh OPAC Summary and confirm message is still there Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 --- Comment #5 from Aleisha Amohia <aleishaamohia@hotmail.com> --- (In reply to Marc Véron from comment #3)
Hi Aleisha,
If I apply this patch on top of Bug 15374, I get merge conflicts.
Hi Marc, please try applying on it's own (not on top of Bug 15374). I used the patch from 15374 to write this patch but I realise now it probably doesn't need to be applied on top of the other one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 Bug 15775 depends on bug 15374, which changed state. Bug 15374 Summary: Translatability: Fix issues on OPAC summary page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15374 Depends on|15374 | --- Comment #6 from Marc Véron <veron@veron.ch> --- Hi Aleisha, I gave up Bug 15374 because it would have conflicts on top of this Bug. It certainly will make it easier to go on with such enhancements. Plese feel free to re-use code from 15374 on top of your patch, if applicable. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 [Bug 15374] Translatability: Fix issues on OPAC summary page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 --- Comment #7 from Aleisha Amohia <aleishaamohia@hotmail.com> --- (In reply to Marc Véron from comment #6)
Hi Aleisha,
I gave up Bug 15374 because it would have conflicts on top of this Bug. It certainly will make it easier to go on with such enhancements.
Plese feel free to re-use code from 15374 on top of your patch, if applicable.
Hi, thanks Marc! I think I actually wrote the patch for this on top of your patch from 15374 anyway so we kind of wrote this patch together :) I will recommit this patch with the commit message from 15374 and edit the bug report since we are now testing for all that translatability stuff too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 --- Comment #8 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 48044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48044&action=edit Bug 15775 - User should know when they are blocked from checkouts on OPAC + Translatability fixes for OPAC Summary page When a user has been blocked from checkouts in the staff client for having too many fines, they will now see a message about this in the OPAC To test: - This patch will be easiest to test if you keep three tabs open - system preferences, a patron detail page, and OPAC summary page - Set some system preferences: - OPACFineNoRenewals = 2 - noissuescharge = 4 - OpacRenewalAllowed = Allow - Set up a patron with fines of $3 - Log in to the OPAC and verify the message from patch from Bug 15374, saying the user cannot renew books. Confirm link to accounts page works. - Set OpacRenewalAllowed = Don't allow - Refresh OPAC Summary and confirm the message disappears - Set OpacRenewalAllowed = Allow - Give the patron total fines of $5 (add $2) - Refresh OPAC Summary and verify message appears saying user is BLOCKED from checkouts. Confirm link to accounts page works - Set OpacRenewalAllowed = Don't allow - Refresh OPAC Summary and confirm message is still there Translability tests: - Log in to OPAC - with blocked /debarred user (with and without comment and date) - with user who has to much fines - with user who has his card marked as lost - with user with an account that is about to expire - with user with expired account - with user with uncertain address information - with user who has got a circulation message (from checkout page) - with user who has a OPAC note - Verify that information is correct and displays nicely and that links in messages work - Carefully examine code - Search for regressions Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47937|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|User should know when they |User should know when they |are blocked from checkouts |are blocked from checkouts |on OPAC |on OPAC + Translatability | |fixes for OPAC Summary page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #9 from Marc Véron <veron@veron.ch> --- Wanted to test, but patch does not apply: Auto-merging opac/opac-user.pl CONFLICT (content): Merge conflict in opac/opac-user.pl Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt Failed to merge in the changes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48044|0 |1 is obsolete| | --- Comment #10 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 49434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49434&action=edit Bug 15775 - User should know when they are blocked from checkouts on OPAC + Translatability fixes for OPAC Summary page EDIT: Fixing merge conflicts When a user has been blocked from checkouts in the staff client for having too many fines, they will now see a message about this in the OPAC To test: - This patch will be easiest to test if you keep three tabs open - system preferences, a patron detail page, and OPAC summary page - Set some system preferences: - OPACFineNoRenewals = 2 - noissuescharge = 4 - OpacRenewalAllowed = Allow - Set up a patron with fines of $3 - Log in to the OPAC and verify the message from patch from Bug 15374, saying the user cannot renew books. Confirm link to accounts page works. - Set OpacRenewalAllowed = Don't allow - Refresh OPAC Summary and confirm the message disappears - Set OpacRenewalAllowed = Allow - Give the patron total fines of $5 (add $2) - Refresh OPAC Summary and verify message appears saying user is BLOCKED from checkouts. Confirm link to accounts page works - Set OpacRenewalAllowed = Don't allow - Refresh OPAC Summary and confirm message is still there Translability tests: - Log in to OPAC - with blocked /debarred user (with and without comment and date) - with user who has to much fines - with user who has his card marked as lost - with user with an account that is about to expire - with user with expired account - with user with uncertain address information - with user who has got a circulation message (from checkout page) - with user who has a OPAC note - Verify that information is correct and displays nicely and that links in messages work - Carefully examine code - Search for regressions Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 --- Comment #11 from Marc Véron <veron@veron.ch> --- Tests: ...are OK Translability tests: - Log in to OPAC (...) - with user who has got a circulation message (from checkout page) The circulation message I added on the checkout page displays a bullet only, but no text. (It displays properly without patch). Other translatability tests are OK. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 --- Comment #12 from Marc Véron <veron@veron.ch> --- Regression happens here: https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49434&action=diff#a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt_sec2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49434|0 |1 is obsolete| | --- Comment #13 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 49473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49473&action=edit Bug 15775 - User should know when they are blocked from checkouts on OPAC + Translatability fixes for OPAC Summary page EDIT: Fixing merge conflicts EDIT: Fix from Comment 11 / Comment 12 When a user has been blocked from checkouts in the staff client for having too many fines, they will now see a message about this in the OPAC To test: - This patch will be easiest to test if you keep three tabs open - system preferences, a patron detail page, and OPAC summary page - Set some system preferences: - OPACFineNoRenewals = 2 - noissuescharge = 4 - OpacRenewalAllowed = Allow - Set up a patron with fines of $3 - Log in to the OPAC and verify the message from patch from Bug 15374, saying the user cannot renew books. Confirm link to accounts page works. - Set OpacRenewalAllowed = Don't allow - Refresh OPAC Summary and confirm the message disappears - Set OpacRenewalAllowed = Allow - Give the patron total fines of $5 (add $2) - Refresh OPAC Summary and verify message appears saying user is BLOCKED from checkouts. Confirm link to accounts page works - Set OpacRenewalAllowed = Don't allow - Refresh OPAC Summary and confirm message is still there Translability tests: - Log in to OPAC - with blocked /debarred user (with and without comment and date) - with user who has to much fines - with user who has his card marked as lost - with user with an account that is about to expire - with user with expired account - with user with uncertain address information - with user who has got a circulation message (from checkout page) - with user who has a OPAC note - Verify that information is correct and displays nicely and that links in messages work - Carefully examine code - Search for regressions Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49473|0 |1 is obsolete| | --- Comment #14 from Marc Véron <veron@veron.ch> --- Created attachment 49516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49516&action=edit Bug 15775 - User should know when they are blocked from checkouts on OPAC + Translatability fixes for OPAC Summary page EDIT: Fixing merge conflicts EDIT: Fix from Comment 11 / Comment 12 When a user has been blocked from checkouts in the staff client for having too many fines, they will now see a message about this in the OPAC To test: - This patch will be easiest to test if you keep three tabs open - system preferences, a patron detail page, and OPAC summary page - Set some system preferences: - OPACFineNoRenewals = 2 - noissuescharge = 4 - OpacRenewalAllowed = Allow - Set up a patron with fines of $3 - Log in to the OPAC and verify the message from patch from Bug 15374, saying the user cannot renew books. Confirm link to accounts page works. - Set OpacRenewalAllowed = Don't allow - Refresh OPAC Summary and confirm the message disappears - Set OpacRenewalAllowed = Allow - Give the patron total fines of $5 (add $2) - Refresh OPAC Summary and verify message appears saying user is BLOCKED from checkouts. Confirm link to accounts page works - Set OpacRenewalAllowed = Don't allow - Refresh OPAC Summary and confirm message is still there Translability tests: - Log in to OPAC - with blocked /debarred user (with and without comment and date) - with user who has to much fines - with user who has his card marked as lost - with user with an account that is about to expire - with user with expired account - with user with uncertain address information - with user who has got a circulation message (from checkout page) - with user who has a OPAC note - Verify that information is correct and displays nicely and that links in messages work - Carefully examine code - Search for regressions Sponsored-by: Catalyst IT Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Who is the author of this patch? The author commit is Marc, is it right? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 49516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49516 Bug 15775 - User should know when they are blocked from checkouts on OPAC + Translatability fixes for OPAC Summary page Review of attachment 49516: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15775&attachment=49516) ----------------------------------------------------------------- I really like the use of the Price plugin for formatting - I'd love to see that used everywhere and improved to show the currency symbol in some cases. Found a small regression in testing (see code comments below): ::: opac/opac-user.pl @@ +126,5 @@
+my $checkoutsblockedamount = C4::Context->preference( 'noissuescharge' ); +$checkoutsblockedamount ||=0; +if ( C4::Context->preference( 'noissuescharge' ) && $borr->{amountoutstanding} > $checkoutsblockedamount ) { + $borr->{'flagged'} = 1; + $canrenew = 0;
I think this change is not correct. noissuecharge should have no effect on renewals, as we have OPACFineNoRenewals to do that. With noissuecharge 5.00, OPACFineNoRenewals 100 and a fine of 5.01 on my account I can now no longer renew items I can renew without the patch. If I set noissuecharge to 5.02 I can renew with the patch applied. @@ +128,5 @@
+if ( C4::Context->preference( 'noissuescharge' ) && $borr->{amountoutstanding} > $checkoutsblockedamount ) { + $borr->{'flagged'} = 1; + $canrenew = 0; + $template->param( + checkouts_blocked_amount => sprintf ( '%.02f', $checkoutsblockedamount ),
Why not format the amount in the template like in the other cases? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|aleishaamohia@hotmail.com |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |aleishaamohia@hotmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 --- Comment #17 from Marc Véron <veron@veron.ch> --- (In reply to Jonathan Druart from comment #15)
Who is the author of this patch? The author commit is Marc, is it right?
This Bug 15775 is related to Bug 15374 I abandoned 15374 in favour of 15775, and sigend off 15775 See https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374#c35 No problem for me if authorship is changed to Aleisha. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 --- Comment #18 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 63710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63710&action=edit Bug 15775: [FOLLOWUP] fixing merge conflicts and using Price plugin for formatting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Status|Needs Signoff |Patch doesn't apply --- Comment #19 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Hi, I tried applying the patch, but it doesn't seem to work. I get conflicts... Using index info to reconstruct a base tree... M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt M opac/opac-user.pl Falling back to patching base and 3-way merge... Auto-merging opac/opac-user.pl CONFLICT (content): Merge conflict in opac/opac-user.pl Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt Failed to merge in the changes. Patch failed at 0001 Bug 15775 - User should know when they are blocked from checkouts on OPAC + Translatability fixes for OPAC Summary page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|User should know when they |Show message on OPAC |are blocked from checkouts |summary if checkouts |on OPAC + Translatability |blocked due to fines |fixes for OPAC Summary page | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49516|0 |1 is obsolete| | Attachment #63710|0 |1 is obsolete| | --- Comment #20 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 98540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98540&action=edit Bug 15775: Show message on OPAC summary if checkouts blocked due to fines To test: 1) Set maxoutstanding syspref to 5 2) Create a manual invoice for a borrower for $6 3) Log in to the OPAC as this borrower 4) Go to opac-user.pl, your summary page 5) Confirm there is a warning box explaining that the borrower is blocked from checkouts and holds due to fines 6) Back on the staff side, pay some or all of the borrower's fines so they are no longer over the max outstanding amount 7) Refresh the summary page in the OPAC and confirm the warning is gone Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 --- Comment #21 from Aleisha Amohia <aleisha@catalyst.net.nz> --- This patch had gotten a little messy and looks like much of the content of the patch has now been dealt with in master, so I've written a new patch to deal simply with the bug title. Ready for testing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98540|0 |1 is obsolete| | --- Comment #22 from David Nind <david@davidnind.com> --- Created attachment 98545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98545&action=edit Bug 15775: Show message on OPAC summary if checkouts blocked due to fines To test: 1) Set maxoutstanding syspref to 5 2) Create a manual invoice for a borrower for $6 3) Log in to the OPAC as this borrower 4) Go to opac-user.pl, your summary page 5) Confirm there is a warning box explaining that the borrower is blocked from checkouts and holds due to fines 6) Back on the staff side, pay some or all of the borrower's fines so they are no longer over the max outstanding amount 7) Refresh the summary page in the OPAC and confirm the warning is gone Sponsored-by: Catalyst IT Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Show message on OPAC |Show message on OPAC |summary if checkouts |summary if holds are |blocked due to fines |blocked due to fines --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We got 3 different prefs for OPAC renewal, checkouts and holds. This patch uses maxoutstanding = holds. Changed the wording of the warning slightly to reflect this. I could imagine doing warns for the other 2 prefs might be nice as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98545|0 |1 is obsolete| | --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 99840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99840&action=edit Bug 15775: Show message on OPAC summary if holds are blocked due to fines To test: 1) Set maxoutstanding syspref to 5 2) Create a manual invoice for a borrower for $6 3) Log in to the OPAC as this borrower 4) Go to opac-user.pl, your summary page 5) Confirm there is a warning box explaining that the borrower is blocked from holds due to fines 6) Back on the staff side, pay some or all of the borrower's fines so they are no longer over the max outstanding amount 7) Refresh the summary page in the OPAC and confirm the warning is gone Sponsored-by: Catalyst IT Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 99841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99841&action=edit Bug 15775: Change wording slightly maxoutstanding only blocks holds, for checkouts we got noissuechage. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24771 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It looks like I missed changing status here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #28 from Joy Nelson <joy@bywatersolutions.com> --- backported to 19.11.x for 19.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #29 from Lucas Gass <lucas@bywatersolutions.com> --- not backporting enhancement to 19.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This adds a note to the release notes| |holds page in the OPAC | |patron account if the user | |is over the maxoutstanding | |fines limit and can no | |longer place holds. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This adds a note to the |This adds a note to the release notes|holds page in the OPAC |patron account in the OPAC |patron account if the user |if the user is over the |is over the maxoutstanding |maxoutstanding fines limit |fines limit and can no |and can no longer place |longer place holds. |holds. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Manual merge| |https://gitlab.com/koha-com request| |munity/koha-manual/-/merge_ | |requests/425 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org