[Bug 23507] New: Add ability to show change given on auto-popup fee reciept from FinePaymentAutoPopup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23507 Bug ID: 23507 Summary: Add ability to show change given on auto-popup fee reciept from FinePaymentAutoPopup Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Some libraries would like to show the amount of change given on print reciepts triggered by FinePaymentAutoPopup so the patron can verify he or she has recieved the correct amount of change. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23507 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23507 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23228 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23228 [Bug 23228] Add option to automatically display payment receipt for printing after making a payment -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23507 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23507 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 92477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92477&action=edit Bug 23507: Add ability to show change given on auto-popup fee reciept from FinePaymentAutoPopup Some libraries would like to show the amount of change given on print reciepts triggered by FinePaymentAutoPopup so the patron can verify he or she has recieved the correct amount of change. 1) Apply this patch 2) Edit ACCOUNT_CREDIT slip and add "[% IF change_given %]<h1>CHANGE: [% change_given %]</h1>[% END %]" at the top 3) Enable FinePaymentAutoPopup 4) Make a payment 5) Note the change given is shown on the popup receipt 6) Note the change given is *not* shown on subsequent prints of the same receipt using the "print" button for the payment -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23507 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92477|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 92483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92483&action=edit Bug 23507: Add ability to show change given on auto-popup fee reciept from FinePaymentAutoPopup Some libraries would like to show the amount of change given on print reciepts triggered by FinePaymentAutoPopup so the patron can verify he or she has recieved the correct amount of change. 1) Apply this patch 2) Edit ACCOUNT_CREDIT slip and add "[% IF change_given %]<h1>CHANGE: [% change_given %]</h1>[% END %]" at the top 3) Enable FinePaymentAutoPopup 4) Make a payment 5) Note the change given is shown on the popup receipt 6) Note the change given is *not* shown on subsequent prints of the same receipt using the "print" button for the payment Signed-off-by: Kyle Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23507 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23507 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92483|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 92484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92484&action=edit Bug 23507: Add ability to show change given on auto-popup fee reciept from FinePaymentAutoPopup Some libraries would like to show the amount of change given on print reciepts triggered by FinePaymentAutoPopup so the patron can verify he or she has recieved the correct amount of change. 1) Apply this patch 2) Edit ACCOUNT_CREDIT slip and add "[% IF change_given %]<h1>CHANGE: [% change_given %]</h1>[% END %]" at the top 3) Enable FinePaymentAutoPopup 4) Make a payment 5) Note the change given is shown on the popup receipt 6) Note the change given is *not* shown on subsequent prints of the same receipt using the "print" button for the payment Signed-off-by: Kyle Hall <kyle@bywatersolutions.com> Signed-off-by: Hasina Akhte <hasinaa@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23507 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23507 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92484|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 92673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92673&action=edit Bug 23507: Add ability to show change given on auto-popup fee reciept from FinePaymentAutoPopup Some libraries would like to show the amount of change given on print reciepts triggered by FinePaymentAutoPopup so the patron can verify he or she has recieved the correct amount of change. 1) Apply this patch 2) Edit ACCOUNT_CREDIT slip and add "[% IF change_given %]<h1>CHANGE: [% change_given %]</h1>[% END %]" at the top 3) Enable FinePaymentAutoPopup 4) Make a payment 5) Note the change given is shown on the popup receipt 6) Note the change given is *not* shown on subsequent prints of the same receipt using the "print" button for the payment Signed-off-by: Kyle Hall <kyle@bywatersolutions.com> Signed-off-by: Hasina Akhte <hasinaa@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23507 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de QA Contact|tomascohen@gmail.com |katrin.fischer@bsz-bw.de Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23507 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add ability to show change |Add ability to show change |given on auto-popup fee |given on auto-popup fee |reciept from |receipt from |FinePaymentAutoPopup |FinePaymentAutoPopup -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23507 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add ability to show change |Add ability to show and |given on auto-popup fee |print change given on fee |receipt from |receipt from |FinePaymentAutoPopup |FinePaymentAutoPopup -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23507 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer@bsz-bw.de |testopia@bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23507 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual, | |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23507 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23507 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 93830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93830&action=edit Bug 23507: Add ability to show change given on auto-popup fee receipt from FinePaymentAutoPopup Some libraries would like to show the amount of change given on print reciepts triggered by FinePaymentAutoPopup so the patron can verify he or she has recieved the correct amount of change. 1) Apply this patch 2) Edit ACCOUNT_CREDIT slip and add "[% IF change_given %]<h1>CHANGE: [% change_given %]</h1>[% END %]" at the top 3) Enable FinePaymentAutoPopup 4) Make a payment 5) Note the change given is shown on the popup receipt 6) Note the change given is *not* shown on subsequent prints of the same receipt using the "print" button for the payment Signed-off-by: Kyle Hall <kyle@bywatersolutions.com> Signed-off-by: Hasina Akhte <hasinaa@pascolibraries.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23507 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92673|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23507 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am wondering if we should not always print the change given on the receipt instead of just the first time. Having it added to the template and only printing sometimes could turn out confusing (or be the next bug report :) ) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23507 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #6)
I am wondering if we should not always print the change given on the receipt instead of just the first time. Having it added to the template and only printing sometimes could turn out confusing (or be the next bug report :) )
We don't store that information Katrin, so we can't print it after the initial transaction at the moment. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23507 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23507 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23507 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Martin Renvoize from comment #7)
(In reply to Katrin Fischer from comment #6)
I am wondering if we should not always print the change given on the receipt instead of just the first time. Having it added to the template and only printing sometimes could turn out confusing (or be the next bug report :) )
We don't store that information Katrin, so we can't print it after the initial transaction at the moment.
Can't argue that point! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23507 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- $redirect .= '&remote_user='; + $redirect .= "change_given=$change_given"; Looks like there is a "&" missing before change_given. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23507 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26915 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26915 [Bug 26915] Koha explodes when writing off a fee with FinePaymentAutoPopup -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23507 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23507 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Manual merge| |https://gitlab.com/koha-com request| |munity/koha-manual/-/merge_ | |requests/423 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org