https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17311 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |mirko@abunchofthings.net |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17311 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16758 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17311 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Mirko Tietgen from comment #1)

We should also take care of the correct order of restarting memcached and plack here in some way.

Added the see also to bug 18250. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17311 --- Comment #4 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 75590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75590&action=edit Bug 17311: koha-common service should be restarted on upgrade This patch stops koha-common before upgrades and restarts memcached, koha-common and apache after upgrades Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17311 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18250 --- Comment #5 from Mirko Tietgen <mirko@abunchofthings.net> --- Might depend on 18250, as it touches the same file and I made this patch on top of it. Setting it to be on the safe side. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18250 [Bug 18250] koha-common should start after memcached -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17311 --- Comment #6 from Mirko Tietgen <mirko@abunchofthings.net> --- *** Bug 17158 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17311 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Hmmm, would this not also disable the 'Opac Maintenance page' for the duration of the upgrade, which would be undesirable for lengthy DB updates for example? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17311 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Martin Renvoize from comment #7)

Hmmm, would this not also disable the 'Opac Maintenance page' for the duration of the upgrade, which would be undesirable for lengthy DB updates for example?

Maybe if we removed the 'servide koha-common stop' from the preinst file this would keep the spirit, while avoiding the problem you noticed, Martin? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17311 --- Comment #10 from Mirko Tietgen <mirko@abunchofthings.net> --- Actually… without this patch, koha-common is stopped in prerm, and started in postinst (right before the db upgrade). It's not obvious in our code, it happens during build of the package (dh_installinit resolving the #DEBHELPER# lines). "koha-common stop" stops plack, so instances using plack are unavailable during unpacking of the new package and deletion of the old files, but should be back before the db upgrade and translation updates. prerm happens before preinst. We don't need that part in the patch. I'll think about the placement of the other bit. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17311 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #12 from Aleisha Amohia <aleisha@catalyst.net.nz> --- I think parts of this are still relevant. The order that services are restarted after an install/upgrade is really important, especially now that Koha uses the background jobs and workers. If services are restarted in the wrong order then the worker errors out, writing to the worker-output.log, filling up the disk and bringing down the server. The services are restarted really nicely and in the correct order in koha testing docker with restart_all, it would be great to have that run when koha-common is installed/upgraded. -- You are receiving this mail because: You are watching all bug changes.