[Bug 31611] New: More visibly highlight records that cannot be batch deleted/modified
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611 Bug ID: 31611 Summary: More visibly highlight records that cannot be batch deleted/modified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: alexbuckley@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org Currently, on the 'Batch item deletion', 'Batch item modification', and 'Batch record deletion' tools if a record cannot be modified/deleted it is displayed in the table of records with a disabled (greyed-out) checkbox. To replicate: 1. Check out an item 2. Go to Tools > Batch item deletion 3. Enter the barcode of the checked-out item and submit 4. Observe the item is displayed in a table with a disabled checkbox 5. Select 'Delete selected items' 6. Notice the checked-out item is not deleted When libraries are modifying/deleting large numbers of records it's easy for them to miss the disabled checkboxes when scrolling through the table. The consequence of this is then wondering why some records have not been modified/deleted. It would be useful to more clearly highlight records that cannot be modified/deleted for these tools. Proposed solution: - Replace the disabled checkbox with a red cross (like those displayed beside items on hold pages when you're not allowed to place item-level holds). - Highlight the entire row for the record that cannot be modified/deleted with a yellow background. - In the 'Batch item deletion' and 'Batch item modification' remove the 'Clear on loan' link - introduced in bug 10599 - as removing the disabled checkboxes would make this redundant. --- I could not see disabled checkboxes in use in the 'Batch patron deletion and anonymisation', 'Batch patron modification', 'Batch extend due dates', or 'Batch record modification. However, I may have missed it so please do let me know if it is present there so I can apply my proposed solution to those pages to for consistency :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |alexbuckley@catalyst.net.nz |ity.org | Status|NEW |ASSIGNED Change sponsored?|--- |Seeking sponsor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611 --- Comment #1 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 140878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140878&action=edit Bug 31611: Clearly highlight items that cannot be modified/deleted in the Batch item tools Test plan: 1. Apply patches 2. Check out an item with a different home branch than the library you're logged in as 3. Go to: Tools > 'Batch item deletion' 4. Into the barcode list area paste the checked-out item's barcode and the barcode of a non-checked out item (with the same home library as the branch you're logged in as) and submit the form 5. Observe in the table that loads the row containing the checked out item is highlighted yellow, and it has a red cross in the first column. 6. Hover over the red cross to see the reason why you cannot delete the item appears 7. Observe the non checked out item has a checkbox and is not highlighted yellow 8. Click 'Select all' and 'Clear all' links and notice the display of the checked out item remains unchanged 9. Change 'IndependentBranches' syspref = 'yes' 10. Log into the staff client as a patron with only the '(catalogue)' and '(tools)' permissions selected 11. Go to: Tools > 'Batch item modification' 12. Enter the checked-out item's barcode and a non-checked out item's barcode and submit the form 13. Observe the table row for the checked out item is again highlighted yellow, with a red cross. 14. Hover over the red cross and observe the text 'Cannot edit' is shown 15. Observe the non-checked out item is not highlighted yellow and does have a checkbox Sponsored-by: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611 --- Comment #2 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 140879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140879&action=edit Bug 31611: Clearly highlight biblios that cannot be deleted in the Batch record deletion tool Test plan: 1. Apply patch 2. Check out an item 3. Go to: Tools > 'Batch record deletion' 4. Into the 'Enter a list of record numbers' area paste in the biblionumber belonging to the checked-out item and that of a biblio without checked out items 5. Submit the form 6. Observe the row of the biblio with checked-out items is highlighted yellow, with a red cross in the first column 7. Hover over the red cross to see the reason why the biblio cannot be deleted 8. Observe the row of the biblio without checked-out items is not highlighted yellow, and does have a checkbox in the first column 9. Click 'Delete selected records' 10. Confirm the biblio without checked-out items is successfully deleted Sponsored-by: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Change sponsored?|Seeking sponsor |Sponsored --- Comment #3 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Ready for testing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611 --- Comment #4 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 140880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140880&action=edit Batch record deletion tool with the second patch applied clearly highlighting which record cannot be deleted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=10599 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |More clearly emphasise released in| |records that cannot be | |modified/deleted in the | |'Batch record deletion', | |'Batch item modification', | |and 'Batch item deletion' | |tools. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |barbara.johnson@bedfordtx.g | |ov --- Comment #5 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- This is a really nice usability enhancement. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Why did you remove "Clear on loan"? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | Status|Signed Off |Failed QA --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 2 small things: 1) QA test tools failure: FAIL koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc FAIL forbidden patterns forbidden pattern: tab char (line 283) 2) The removed bit Jonathan noted, maybe a rebase issue? - <a id="selectallbutton" href="#"><i class="fa fa-check"></i> Select all</a> | <a id="clearallbutton" href="#"><i class="fa fa-remove"></i> Clear all</a> | <a id="clearonloanbutton" href="#">Clear on loan</a> + <a id="selectallbutton" href="#"><i class="fa fa-check"></i> Select all</a> | <a id="clearallbutton" href="#"><i class="fa fa-remove"></i> Clear all</a> - $("#clearonloanbutton").click(function () { - $("#itemst input[name='itemnumber'][data-is-onloan='1']").each(function () { - $(this).prop('checked', false); - }); - return false; - }); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm. testing this, I don't see the 'select on loan' filter without the patch either... So maybe this was just removing dead code? I think bringing back the option to remove all records from the list that have items checked out could still be useful to bring back. So maybe we should keep the code and file a new bug? Alex, could you have a look? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611 --- Comment #9 from Alex Buckley <alexbuckley@catalyst.net.nz> --- (In reply to Katrin Fischer from comment #8)
Hm. testing this, I don't see the 'select on loan' filter without the patch either... So maybe this was just removing dead code?
I think bringing back the option to remove all records from the list that have items checked out could still be useful to bring back. So maybe we should keep the code and file a new bug?
Alex, could you have a look?
Hi Katrin, I am back from leave now, and will take a look at this. Thanks, Alex -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140878|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140879|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611 --- Comment #10 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 144888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144888&action=edit Bug 31611: Clearly highlight items that cannot be modified/deleted in the Batch item tools Test plan: 1. Apply patches 2. Check out an item with a different home branch than the library you're logged in as 3. Go to: 'Cataloguing' > 'Batch item deletion' 4. Into the barcode list area paste the checked-out item's barcode and the barcode of a non-checked out item (with the same home library as the branch you're logged in as) and submit the form 5. Observe in the table that loads the row containing the checked out item is highlighted yellow, and it has a red cross in the first column. 6. Hover over the red cross to see the reason why you cannot delete the item appears 7. Observe the non checked out item has a checkbox and is not highlighted yellow 8. Click 'Select all' and 'Clear all' links and notice the display of the checked out item remains unchanged 9. Change 'IndependentBranches' syspref = 'yes' 10. Log into the staff client as a patron with only the '(catalogue)', '(editcatalogue)', and '(tools)' permissions selected 11. Go to: 'Cataloguing' > 'Batch item modification' 12. Enter the checked-out item's barcode and a non-checked out item's barcode and submit the form 13. Observe the table row for the checked out item is again highlighted yellow, with a red cross. 14. Hover over the red cross and observe the text 'Cannot edit' is shown 15. Observe the non-checked out item is not highlighted yellow and does have a checkbox Sponsored-by: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611 --- Comment #11 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 144889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144889&action=edit Bug 31611: Clearly highlight biblios that cannot be deleted in the Batch record deletion tool Test plan: 1. Apply patch 2. Check out an item 3. Go to: Tools > 'Batch record deletion' 4. Into the 'Enter a list of record numbers' area paste in the biblionumber belonging to the checked-out item and that of a biblio without checked out items 5. Submit the form 6. Observe the row of the biblio with checked-out items is highlighted yellow, with a red cross in the first column 7. Hover over the red cross to see the reason why the biblio cannot be deleted 8. Observe the row of the biblio without checked-out items is not highlighted yellow, and does have a checkbox in the first column 9. Click 'Delete selected records' 10. Confirm the biblio without checked-out items is successfully deleted Sponsored-by: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144889|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611 --- Comment #12 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 144890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144890&action=edit Bug 31611: Clearly highlight biblios that cannot be deleted in the Batch record deletion tool Test plan: 1. Apply patch 2. Check out an item 3. Go to: 'Cataloguing' > 'Batch record deletion' 4. Into the 'Enter a list of record numbers' area paste in the biblionumber belonging to the checked-out item and that of a biblio without checked out items 5. Submit the form 6. Observe the row of the biblio with checked-out items is highlighted yellow, with a red cross in the first column 7. Hover over the red cross to see the reason why the biblio cannot be deleted 8. Observe the row of the biblio without checked-out items is not highlighted yellow, and does have a checkbox in the first column 9. Click 'Delete selected records' 10. Confirm the biblio without checked-out items is successfully deleted Sponsored-by: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #13 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi Jonathan and Katrin, Thank you for your responses. Jonathan: I originally removed the 'Clear on loan' link from the batch item modification and deletion pages for the reason outlined in the description: This patchset makes items on loan display a red cross, rather than a disabled checkbox. So giving users the ability to clear on loan items when they could not be selected in most cases seemed redundant. However, when the 'IndependentBranches' syspref is set to 'No' then on-loan items can be displayed with a selectable checkbox in the Batch item modification page so I have now re-added the 'Clear on loan' link to both batch item tool pages. --- Katrin: I've done some testing: The 'Clear on loan' link only appears on the batch item modification and deletion pages on master/main (and I have re-added it in my patches) - loaded from the html_helpers.inc. It does not appear on the batch record deletion page - as that uses links from batch_delete_records.tt ( https://github.com/Koha-Community/Koha/blob/master/koha-tmpl/intranet-tmpl/p... ). I do notice, however, the 'Clear on loan' link doesn't appear to work on the batch item modification page on master/main - so I'll make a new bug report for that. --- I've removed the tab char that QA test tools reported in comment #7, and have updated the test plans on both patches now batch item/record tools exist in the 'Cataloguing' module. Ready for testing again! Many thanks, Alex -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32550 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611 --- Comment #14 from Alex Buckley <alexbuckley@catalyst.net.nz> --- (In reply to Alex Buckley from comment #13)
Hi Jonathan and Katrin,
Thank you for your responses.
Jonathan: I originally removed the 'Clear on loan' link from the batch item modification and deletion pages for the reason outlined in the description:
This patchset makes items on loan display a red cross, rather than a disabled checkbox. So giving users the ability to clear on loan items when they could not be selected in most cases seemed redundant.
However, when the 'IndependentBranches' syspref is set to 'No' then on-loan items can be displayed with a selectable checkbox in the Batch item modification page so I have now re-added the 'Clear on loan' link to both batch item tool pages.
---
Katrin: I've done some testing: The 'Clear on loan' link only appears on the batch item modification and deletion pages on master/main (and I have re-added it in my patches) - loaded from the html_helpers.inc.
It does not appear on the batch record deletion page - as that uses links from batch_delete_records.tt ( https://github.com/Koha-Community/Koha/blob/master/koha-tmpl/intranet-tmpl/ prog/en/modules/tools/batch_delete_records.tt#L142 ).
I do notice, however, the 'Clear on loan' link doesn't appear to work on the batch item modification page on master/main - so I'll make a new bug report for that.
---
I've removed the tab char that QA test tools reported in comment #7, and have updated the test plans on both patches now batch item/record tools exist in the 'Cataloguing' module.
Ready for testing again!
Many thanks, Alex
I've created a new bug report for the 'Clear on loan' link not working on the 'Batch item modification' page: bug 32550 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144888|0 |1 is obsolete| | --- Comment #15 from David Nind <david@davidnind.com> --- Created attachment 144897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144897&action=edit Bug 31611: Clearly highlight items that cannot be modified/deleted in the Batch item tools Test plan: 1. Apply patches 2. Check out an item with a different home branch than the library you're logged in as 3. Go to: 'Cataloguing' > 'Batch item deletion' 4. Into the barcode list area paste the checked-out item's barcode and the barcode of a non-checked out item (with the same home library as the branch you're logged in as) and submit the form 5. Observe in the table that loads the row containing the checked out item is highlighted yellow, and it has a red cross in the first column. 6. Hover over the red cross to see the reason why you cannot delete the item appears 7. Observe the non checked out item has a checkbox and is not highlighted yellow 8. Click 'Select all' and 'Clear all' links and notice the display of the checked out item remains unchanged 9. Change 'IndependentBranches' syspref = 'yes' 10. Log into the staff client as a patron with only the '(catalogue)', '(editcatalogue)', and '(tools)' permissions selected 11. Go to: 'Cataloguing' > 'Batch item modification' 12. Enter the checked-out item's barcode and a non-checked out item's barcode and submit the form 13. Observe the table row for the checked out item is again highlighted yellow, with a red cross. 14. Hover over the red cross and observe the text 'Cannot edit' is shown 15. Observe the non-checked out item is not highlighted yellow and does have a checkbox Sponsored-by: Toi Ohomai Institute of Technology, New Zealand Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144890|0 |1 is obsolete| | --- Comment #16 from David Nind <david@davidnind.com> --- Created attachment 144898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144898&action=edit Bug 31611: Clearly highlight biblios that cannot be deleted in the Batch record deletion tool Test plan: 1. Apply patch 2. Check out an item 3. Go to: 'Cataloguing' > 'Batch record deletion' 4. Into the 'Enter a list of record numbers' area paste in the biblionumber belonging to the checked-out item and that of a biblio without checked out items 5. Submit the form 6. Observe the row of the biblio with checked-out items is highlighted yellow, with a red cross in the first column 7. Hover over the red cross to see the reason why the biblio cannot be deleted 8. Observe the row of the biblio without checked-out items is not highlighted yellow, and does have a checkbox in the first column 9. Click 'Delete selected records' 10. Confirm the biblio without checked-out items is successfully deleted Sponsored-by: Toi Ohomai Institute of Technology, New Zealand Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement more release notes| |clearly emphasises records | |that cannot be modified or | |deleted in the 'Batch | |record deletion', 'Batch | |item modification', and | |'Batch item deletion' | |tools. Rows are now | |highlighted in yellow, with | |a red 'X' in the first | |column (hovering over the | |red 'X' shows the reason it | |cannot be modified or | |deleted). Version(s)|More clearly emphasise | released in|records that cannot be | |modified/deleted in the | |'Batch record deletion', | |'Batch item modification', | |and 'Batch item deletion' | |tools. | CC| |david@davidnind.com --- Comment #17 from David Nind <david@davidnind.com> --- Moved release notes from the version(s) released in field to the text to go in the release notes field, and edited slightly... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32550 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32550 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32550 [Bug 32550] 'Clear on loan' link on Batch item modification doesn't untick on loan items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- + // Highlight in yellow item rows that cannot be deleted + $(".error").parents('tr').find('td').css('background-color', '#ffff99'); Would normally expect this via css file, but similar actions are found already in the batch delete too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144897|0 |1 is obsolete| | --- Comment #19 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 147286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147286&action=edit Bug 31611: Clearly highlight items that cannot be modified/deleted in the Batch item tools Test plan: 1. Apply patches 2. Check out an item with a different home branch than the library you're logged in as 3. Go to: 'Cataloguing' > 'Batch item deletion' 4. Into the barcode list area paste the checked-out item's barcode and the barcode of a non-checked out item (with the same home library as the branch you're logged in as) and submit the form 5. Observe in the table that loads the row containing the checked out item is highlighted yellow, and it has a red cross in the first column. 6. Hover over the red cross to see the reason why you cannot delete the item appears 7. Observe the non checked out item has a checkbox and is not highlighted yellow 8. Click 'Select all' and 'Clear all' links and notice the display of the checked out item remains unchanged 9. Change 'IndependentBranches' syspref = 'yes' 10. Log into the staff client as a patron with only the '(catalogue)', '(editcatalogue)', and '(tools)' permissions selected 11. Go to: 'Cataloguing' > 'Batch item modification' 12. Enter the checked-out item's barcode and a non-checked out item's barcode and submit the form 13. Observe the table row for the checked out item is again highlighted yellow, with a red cross. 14. Hover over the red cross and observe the text 'Cannot edit' is shown 15. Observe the non-checked out item is not highlighted yellow and does have a checkbox Sponsored-by: Toi Ohomai Institute of Technology, New Zealand Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144898|0 |1 is obsolete| | --- Comment #20 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 147287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147287&action=edit Bug 31611: Clearly highlight biblios that cannot be deleted in the Batch record deletion tool Test plan: 1. Apply patch 2. Check out an item 3. Go to: 'Cataloguing' > 'Batch record deletion' 4. Into the 'Enter a list of record numbers' area paste in the biblionumber belonging to the checked-out item and that of a biblio without checked out items 5. Submit the form 6. Observe the row of the biblio with checked-out items is highlighted yellow, with a red cross in the first column 7. Hover over the red cross to see the reason why the biblio cannot be deleted 8. Observe the row of the biblio without checked-out items is not highlighted yellow, and does have a checkbox in the first column 9. Click 'Delete selected records' 10. Confirm the biblio without checked-out items is successfully deleted Sponsored-by: Toi Ohomai Institute of Technology, New Zealand Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer@bsz-bw.de |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611 --- Comment #21 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop@ptfs-europe | |.com Status|Pushed to master |Needs documenting --- Comment #22 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Enhancement - not backporting to 22.11.x Nice work everyone! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #23 from Aleisha Amohia <aleisha@catalyst.net.nz> --- *** Bug 34089 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org