[Bug 8377] New: Show HTML5 video/ audio in OPAC for media files in 856
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 Priority: P5 - low Change sponsored?: --- Bug ID: 8377 Assignee: 5p4m@gmx.de Summary: Show HTML5 video/ audio in OPAC for media files in 856 Severity: enhancement Classification: Unclassified OS: All Reporter: 5p4m@gmx.de Hardware: All Status: ASSIGNED Version: master Component: OPAC Product: Koha With HTML5 it is possible to integrate audio and video content into websites easily. This enhancement uses information from MARC field 856 to generate the appropriate HTML5 code to embed the file(s) in a tab in the opac-detail view, including a fullscreen option. This enhancement introduces two sysprefs: one to enable the feature, one to specify file extensions to be recognizes as media files. This patch supports the HTML5 <audio> and <video> element. Additionally it gives basic support for the <track> element. This element is not supported very well by recent browsers. It is possible to use javascript polyfills to support it, this may be an option to be introduced in a seperate enhancement. The basic functions of this enhancement are MARC agnostic because MARC21 and UNIMARC both use field 856 for electronic resources. There are minor differences regarding subfields. A test plan and sample MARC files will be added soon. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 --- Comment #1 from Mirko Tietgen <5p4m@gmx.de> --- HTML5 media RFC <a href="http://wiki.koha-community.org/wiki/HTML5_Media_RFC">http://wiki.koha-community.org/wiki/HTML5_Media_RFC</a> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 --- Comment #2 from Mirko Tietgen <5p4m@gmx.de> --- Created attachment 10684 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10684&action=edit Bug 8377 [ENH] Show HTML5 video/ audio in OPAC for media files in 856 This enhancement uses information from MARC field 856 to generate the appropriate HTML5 code to embed a media player for the file(s) in a tab in the opac-detail view. This patch supports the HTML5 <audio> and <video> element. Additionally it gives basic support for the <track> element. This element is not supported very well by recent browsers. Please consider the patch working when you get working video or audio. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 --- Comment #3 from Mirko Tietgen <5p4m@gmx.de> --- Created attachment 10685 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10685&action=edit Bug 8377 test data (MARC21) Test data MARC21 Bug 8377 Test 01: Video, using subfields a, d, f Bug 8377 Test 02: Video, using subfield u Bug 8377 Test 03: Video, using subfields a, d, f, login, pass in l, k Bug 8377 Test 04: Audio, using subfield u Test plan - Import attached test data. [I chose media typ 'bk' because it's probably present on most systems. It's not appropriate for the data but that doesn't matter.] - Rebuild zebra -b -z - Go to sysprefs->enhanced content->html5 media and set HTML5MediaEnabled to 'Show', save preferences. - Search the OPAC for 'bug 8377' - Get 4 results - Open one result after the other. Observe working video (1-3) or audio (4) player on opac-detail page Note that the video files don't have sound, that is not an error. Also note that the audio file is a trombone so turn down the volume before you try it :) If you feel adventurous, go to sysprefs->enhanced content->html5 media and delete the entry for 'ogv' from HTML5MediaExtensions. Try the four biblios again and observe that only the audio example (4) shows a media player. You may have to empty your cache and restart Plack if you use that. Some files contain subtitles to be displayed in a <track> element. These are not generally supported by browsers at the moment. You can see them in the source code of the opac-detail pages. Chrome/ Chromium can play them, but only if they are set as 'default'. There is no option to do that in this patch, so it won't work. Firefox can't play them yet. Opera can't play them yet. Internet Explorer 10 may be able to play them, but I don't have one. I included basic track support anyway and plan to continue working on that later. There is more on that matter in the Wiki. Please consider this patch working if you get working video or audio. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 Mirko Tietgen <5p4m@gmx.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #4 from Mirko Tietgen <5p4m@gmx.de> --- This patch can be tested in a sandbox. http://wiki.koha-community.org/wiki/Sandboxes -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 --- Comment #5 from Mirko Tietgen <5p4m@gmx.de> --- Created attachment 10688 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10688&action=edit Bug 8377 [ENH] Show HTML5 video/ audio in OPAC for media files in 856 This enhancement uses information from MARC field 856 to generate the appropriate HTML5 code to embed am media player for the file(s) in a tab in the opac-detail view. This patch supports the HTML5 <audio> and <video> element. Additionally it gives basic support for the <track> element. This element is not supported very well by recent browsers. Please consider the patch working when you get working video or audio. Fixed a typo in this second patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 Mirko Tietgen <5p4m@gmx.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10684|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 Mirko Tietgen <5p4m@gmx.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10688|0 |1 is obsolete| | --- Comment #6 from Mirko Tietgen <5p4m@gmx.de> --- Created attachment 10776 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10776&action=edit Bug 8377 [ENH] Show HTML5 video/ audio in OPAC for media files in 856 This enhancement uses information from MARC field 856 to generate the appropriate HTML5 code to embed am media player for the file(s) in a tab in the opac-detail view. This patch supports the HTML5 <audio> and <video> element. Additionally it gives basic support for the <track> element. This element is not supported very well by recent browsers. Please consider the patch working when you get working video or audio. Fixed a typo in this second patch. rebased to master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 --- Comment #7 from Mirko Tietgen <5p4m@gmx.de> --- Test plan - Import attached test data. [I chose media typ 'bk' because it's probably present on most systems. It's not appropriate for the data but that doesn't matter.] - Rebuild zebra -b -z - Go to sysprefs->enhanced content->html5 media and set HTML5MediaEnabled to 'Show', save preferences. - Search the OPAC for 'bug 8377' - Get 4 results - Open one result after the other. Observe working video (1-3) or audio (4) player on opac-detail page -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- This looks like it's working well with the examples provided. The examples worked well in Firefox and Chrome. I also tested a record with an mp4 video attached in order to test Safari on Windows and Internet Explorer (9)--both working. A couple of problems: The "HTML5 Media" tab is selected by default if HTML5 media is attached, which I don't think is correct. What is the reasoning behind changing the default tab in this case? Also, I think labeling the tab "HTML5 Media" is not user-friendly at all. The "HTML5" aspect of it is useless information as far as a patron is concerned. Perhaps "Related media?" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 --- Comment #9 from Mirko Tietgen <5p4m@gmx.de> --- Created attachment 11056 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11056&action=edit Remove previous version of sysprefs for this enhancement If you tested a patch for this bug before, you can use this file to delete the previous version of the sysprefs for this bug. They have changed in the new version - sorry. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 Mirko Tietgen <5p4m@gmx.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Show HTML5 video/ audio in |Show HTML5 video/ audio for |OPAC for media files in 856 |media files in OPAC and | |staff client -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 Mirko Tietgen <5p4m@gmx.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10776|0 |1 is obsolete| | --- Comment #10 from Mirko Tietgen <5p4m@gmx.de> --- Created attachment 11057 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11057&action=edit Bug 8377 [ENH] Show HTML5 video/ audio for media files in OPAC and staff client This enhancement uses information from MARC field 856 to generate the appropriate HTML5 code to embed am media player for the file(s) in a tab in the OPAC and staff client detail view. This patch supports the HTML5 <audio> and <video> element. Additionally it gives basic support for the <track> element. This element is not supported very well by recent browsers. Please consider the patch working when you get working video or audio. Changes since last version: - failed QA: removed default view for media tab, changed tab name to "Play audio" resp. "Play video". - put most of the code in separate module and access it from OPAC and staff client now, so the feature works in both - added mp3 to default media types - had to change sysprefs: HTML5MediaEnabled can be 'none', 'opac', 'staff' or 'both'; HTML5MediaExtensions has additional 'mp3' as default If you tested this before, you need to delete the old syspref entries from your database. There is an attachment to do this, use exactly like upgradedatabase.pl. Test plan - Import attached test data. [I chose media typ 'bk' because it's probably present on most systems. It's not appropriate for the data but that doesn't matter.] - Rebuild zebra -b -z - Go to Administration->System preferences->enhanced content->HTML5 Media and set HTML5MediaEnabled to an appropriate setting, save preferences. - Search the OPAC or staff client for 'bug 8377' - Get 4 results - Open detail pages for results. Observe working video (1-3) or audio (4) player on detail page. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 Mirko Tietgen <5p4m@gmx.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11057|0 |1 is obsolete| | --- Comment #11 from Mirko Tietgen <5p4m@gmx.de> --- Created attachment 11058 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11058&action=edit Bug 8377 [ENH] Show HTML5 video/ audio for media files in OPAC and staff client This enhancement uses information from MARC field 856 to generate the appropriate HTML5 code to embed am media player for the file(s) in a tab in the OPAC and staff client detail view. This patch supports the HTML5 <audio> and <video> element. Additionally it gives basic support for the <track> element. This element is not supported very well by recent browsers. Please consider the patch working when you get working video or audio. Changes since last version: - failed QA: removed default view for media tab, changed tab name to "Play audio" resp. "Play video". - put most of the code in separate module and access it from OPAC and staff client now, so the feature works in both - added mp3 to default media types - had to change sysprefs: HTML5MediaEnabled can be 'none', 'opac', 'staff' or 'both'; HTML5MediaExtensions has additional 'mp3' as default If you tested this before, you need to delete the old syspref entries from your database. There is an attachment to do this, use exactly like upgradedatabase.pl. Test plan - Import attached test data. [I chose media typ 'bk' because it's probably present on most systems. It's not appropriate for the data but that doesn't matter.] - Rebuild zebra -b -z - Go to Administration->System preferences->enhanced content->HTML5 Media and set HTML5MediaEnabled to an appropriate setting, save preferences. - Search the OPAC or staff client for 'bug 8377' - Get 4 results - Open detail pages for results. Observe working video (1-3) or audio (4) player on detail page. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 Mirko Tietgen <5p4m@gmx.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11058|0 |1 is obsolete| | --- Comment #12 from Mirko Tietgen <5p4m@gmx.de> --- Created attachment 11059 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11059&action=edit Bug 8377 [ENH] Show HTML5 video/ audio for media files in OPAC and staff client This enhancement uses information from MARC field 856 to generate the appropriate HTML5 code to embed am media player for the file(s) in a tab in the OPAC and staff client detail view. This patch supports the HTML5 <audio> and <video> element. Additionally it gives basic support for the <track> element. This element is not supported very well by recent browsers. Please consider the patch working when you get working video or audio. Changes since last version: - failed QA: removed default view for media tab, changed tab name to "Play audio" resp. "Play video". - put most of the code in separate module and access it from OPAC and staff client now, so the feature works in both - added mp3 to default media types - had to change sysprefs: HTML5MediaEnabled can be 'none', 'opac', 'staff' or 'both'; HTML5MediaExtensions has additional 'mp3' as default If you tested this before, you need to delete the old syspref entries from your database. There is an attachment to do this, use exactly like upgradedatabase.pl. Test plan - Import attached test data. [I chose media typ 'bk' because it's probably present on most systems. It's not appropriate for the data but that doesn't matter.] - Rebuild zebra -b -z - Go to Administration->System preferences->enhanced content->HTML5 Media and set HTML5MediaEnabled to an appropriate setting, save preferences. - Search the OPAC or staff client for 'bug 8377' - Get 4 results - Open detail pages for results. Observe working video (1-3) or audio (4) player on detail page. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 Mirko Tietgen <5p4m@gmx.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 Mirko Tietgen <5p4m@gmx.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11059|0 |1 is obsolete| | --- Comment #13 from Mirko Tietgen <5p4m@gmx.de> --- Created attachment 11067 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11067&action=edit Bug 8377 [ENH] Show HTML5 video/ audio for media files in OPAC and staff client This enhancement uses information from MARC field 856 to generate the appropriate HTML5 code to embed am media player for the file(s) in a tab in the OPAC and staff client detail view. This patch supports the HTML5 <audio> and <video> element. Additionally it gives basic support for the <track> element. This element is not supported very well by recent browsers. Please consider the patch working when you get working video or audio. Changes since last version: - failed QA: removed default view for media tab, changed tab name to "Play audio" resp. "Play video". - put most of the code in separate module and access it from OPAC and staff client now, so the feature works in both - had to change sysprefs: HTML5MediaEnabled can be 'none', 'opac', 'staff' or 'both' * Removed default entry for mp3 again to not imply it is widely supported or going to be by free software browsers. If you tested this before, you need to delete the old syspref entries from your database. There is an attachment to do this, use exactly like upgradedatabase.pl. Test plan - Import attached test data. [I chose media typ 'bk' because it's probably present on most systems. It's not appropriate for the data but that doesn't matter.] - Rebuild zebra -b -z - Go to Administration->System preferences->enhanced content->HTML5 Media and set HTML5MediaEnabled to an appropriate setting, save preferences. - Search the OPAC or staff client for 'bug 8377' - Get 4 results - Open detail pages for results. Observe working video (1-3) or audio (4) player on detail page. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 --- Comment #14 from Mirko Tietgen <5p4m@gmx.de> --- Created attachment 11068 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11068&action=edit Bug 8377 [ENH] Show HTML5 video/ audio for media files in OPAC and staff client Follow-up patch, changing the tab text. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11067|0 |1 is obsolete| | Attachment #11068|0 |1 is obsolete| | --- Comment #15 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 11153 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11153&action=edit Bug 8377 [ENH] Show HTML5 video/ audio for media files in OPAC and staff client This enhancement uses information from MARC field 856 to generate the appropriate HTML5 code to embed am media player for the file(s) in a tab in the OPAC and staff client detail view. This patch supports the HTML5 <audio> and <video> element. Additionally it gives basic support for the <track> element. This element is not supported very well by recent browsers. Please consider the patch working when you get working video or audio. Changes since last version: - failed QA: removed default view for media tab, changed tab name to "Play audio" resp. "Play video". - put most of the code in separate module and access it from OPAC and staff client now, so the feature works in both - had to change sysprefs: HTML5MediaEnabled can be 'none', 'opac', 'staff' or 'both' * Removed default entry for mp3 again to not imply it is widely supported or going to be by free software browsers. If you tested this before, you need to delete the old syspref entries from your database. There is an attachment to do this, use exactly like upgradedatabase.pl. Test plan - Import attached test data. [I chose media typ 'bk' because it's probably present on most systems. It's not appropriate for the data but that doesn't matter.] - Rebuild zebra -b -z - Go to Administration->System preferences->enhanced content->HTML5 Media and set HTML5MediaEnabled to an appropriate setting, save preferences. - Search the OPAC or staff client for 'bug 8377' - Get 4 results - Open detail pages for results. Observe working video (1-3) or audio (4) player on detail page. Squashed both patches together Rebased to master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 --- Comment #16 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 11545 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11545&action=edit Bug 8377 [ENH] Show HTML5 video/ audio for media files in OPAC and staff client This enhancement uses information from MARC field 856 to generate the appropriate HTML5 code to embed am media player for the file(s) in a tab in the OPAC and staff client detail view. This patch supports the HTML5 <audio> and <video> element. Additionally it gives basic support for the <track> element. This element is not supported very well by recent browsers. Please consider the patch working when you get working video or audio. Changes since last version: - failed QA: removed default view for media tab, changed tab name to "Play audio" resp. "Play video". - put most of the code in separate module and access it from OPAC and staff client now, so the feature works in both - had to change sysprefs: HTML5MediaEnabled can be 'none', 'opac', 'staff' or 'both' * Removed default entry for mp3 again to not imply it is widely supported or going to be by free software browsers. If you tested this before, you need to delete the old syspref entries from your database. There is an attachment to do this, use exactly like upgradedatabase.pl. Test plan - Import attached test data. [I chose media typ 'bk' because it's probably present on most systems. It's not appropriate for the data but that doesn't matter.] - Rebuild zebra -b -z - Go to Administration->System preferences->enhanced content->HTML5 Media and set HTML5MediaEnabled to an appropriate setting, save preferences. - Search the OPAC or staff client for 'bug 8377' - Get 4 results - Open detail pages for results. Observe working video (1-3) or audio (4) player on detail page. Squashed both patches together -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11153|0 |1 is obsolete| | Attachment #11545|0 |1 is obsolete| | --- Comment #17 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 11546 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11546&action=edit Bug 8377 [ENH] Show HTML5 video/ audio for media files in OPAC and staff client This enhancement uses information from MARC field 856 to generate the appropriate HTML5 code to embed am media player for the file(s) in a tab in the OPAC and staff client detail view. This patch supports the HTML5 <audio> and <video> element. Additionally it gives basic support for the <track> element. This element is not supported very well by recent browsers. Please consider the patch working when you get working video or audio. Changes since last version: - failed QA: removed default view for media tab, changed tab name to "Play audio" resp. "Play video". - put most of the code in separate module and access it from OPAC and staff client now, so the feature works in both - had to change sysprefs: HTML5MediaEnabled can be 'none', 'opac', 'staff' or 'both' * Removed default entry for mp3 again to not imply it is widely supported or going to be by free software browsers. If you tested this before, you need to delete the old syspref entries from your database. There is an attachment to do this, use exactly like upgradedatabase.pl. Test plan - Import attached test data. [I chose media typ 'bk' because it's probably present on most systems. It's not appropriate for the data but that doesn't matter.] - Rebuild zebra -b -z - Go to Administration->System preferences->enhanced content->HTML5 Media and set HTML5MediaEnabled to an appropriate setting, save preferences. - Search the OPAC or staff client for 'bug 8377' - Get 4 results - Open detail pages for results. Observe working video (1-3) or audio (4) player on detail page. Squashed both patches together rebased again -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11546|0 |1 is obsolete| | --- Comment #18 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 11548 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11548&action=edit Bug 8377 [ENH] Show HTML5 video/ audio for media files in OPAC and staff client This enhancement uses information from MARC field 856 to generate the appropriate HTML5 code to embed am media player for the file(s) in a tab in the OPAC and staff client detail view. This patch supports the HTML5 <audio> and <video> element. Additionally it gives basic support for the <track> element. This element is not supported very well by recent browsers. Please consider the patch working when you get working video or audio. Changes since last version: - failed QA: removed default view for media tab, changed tab name to "Play audio" resp. "Play video". - put most of the code in separate module and access it from OPAC and staff client now, so the feature works in both - had to change sysprefs: HTML5MediaEnabled can be 'none', 'opac', 'staff' or 'both' * Removed default entry for mp3 again to not imply it is widely supported or going to be by free software browsers. If you tested this before, you need to delete the old syspref entries from your database. There is an attachment to do this, use exactly like upgradedatabase.pl. Test plan - Import attached test data. [I chose media typ 'bk' because it's probably present on most systems. It's not appropriate for the data but that doesn't matter.] - Rebuild zebra -b -z - Go to Administration->System preferences->enhanced content->HTML5 Media and set HTML5MediaEnabled to an appropriate setting, save preferences. - Search the OPAC or staff client for 'bug 8377' - Get 4 results - Open detail pages for results. Observe working video (1-3) or audio (4) player on detail page. Squashed both patches together Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Followed test plan, works well. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |paul.poulain@biblibre.com --- Comment #19 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: This patch has one problem that must be solved before being pushed : the Koha:: namespace must contain OO code only, the Koha/HTML5Media.pm is not OO I also think that this file (an OO version) should be in a subdirectory, but I've nothing to propose for now. I've checked that the HTML5Media.pm passes perlcritic 2 options to earn passed QA : * rewritte HTML5Media.pm for an OO version * move it to C4/ failing QA for now. note I haven't tested it, and it also not apply cleanly anymore: CONFLICT (content): Merge conflict in opac/opac-detail.pl Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/enhanced_content.pref Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql Auto-merging catalogue/detail.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 --- Comment #20 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 12372 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12372&action=edit Bug 8377 [ENH] Followup: Move perl module to C4 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11548|0 |1 is obsolete| | Attachment #12372|0 |1 is obsolete| | --- Comment #21 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 12373 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12373&action=edit Bug 8377 [ENH] Show HTML5 video/ audio for media files in OPAC and staff client This enhancement uses information from MARC field 856 to generate the appropriate HTML5 code to embed am media player for the file(s) in a tab in the OPAC and staff client detail view. This patch supports the HTML5 <audio> and <video> element. Additionally it gives basic support for the <track> element. This element is not supported very well by recent browsers. Please consider the patch working when you get working video or audio. Changes since last version: - failed QA: removed default view for media tab, changed tab name to "Play audio" resp. "Play video". - put most of the code in separate module and access it from OPAC and staff client now, so the feature works in both - had to change sysprefs: HTML5MediaEnabled can be 'none', 'opac', 'staff' or 'both' * Removed default entry for mp3 again to not imply it is widely supported or going to be by free software browsers. If you tested this before, you need to delete the old syspref entries from your database. There is an attachment to do this, use exactly like upgradedatabase.pl. Test plan - Import attached test data. [I chose media typ 'bk' because it's probably present on most systems. It's not appropriate for the data but that doesn't matter.] - Rebuild zebra -b -z - Go to Administration->System preferences->enhanced content->HTML5 Media and set HTML5MediaEnabled to an appropriate setting, save preferences. - Search the OPAC or staff client for 'bug 8377' - Get 4 results - Open detail pages for results. Observe working video (1-3) or audio (4) player on detail page. Squashed both patches together Bug 8377 [ENH] Followup: Move perl module to C4 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12373|0 |1 is obsolete| | --- Comment #22 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 12378 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12378&action=edit Bug 8377 [ENH] Show HTML5 video/ audio for media files in OPAC and staff client This enhancement uses information from MARC field 856 to generate the appropriate HTML5 code to embed am media player for the file(s) in a tab in the OPAC and staff client detail view. This patch supports the HTML5 <audio> and <video> element. Additionally it gives basic support for the <track> element. This element is not supported very well by recent browsers. Please consider the patch working when you get working video or audio. Changes since last version: - failed QA: removed default view for media tab, changed tab name to "Play audio" resp. "Play video". - put most of the code in separate module and access it from OPAC and staff client now, so the feature works in both - had to change sysprefs: HTML5MediaEnabled can be 'none', 'opac', 'staff' or 'both' * Removed default entry for mp3 again to not imply it is widely supported or going to be by free software browsers. If you tested this before, you need to delete the old syspref entries from your database. There is an attachment to do this, use exactly like upgradedatabase.pl. Test plan - Import attached test data. [I chose media typ 'bk' because it's probably present on most systems. It's not appropriate for the data but that doesn't matter.] - Rebuild zebra -b -z - Go to Administration->System preferences->enhanced content->HTML5 Media and set HTML5MediaEnabled to an appropriate setting, save preferences. - Search the OPAC or staff client for 'bug 8377' - Get 4 results - Open detail pages for results. Observe working video (1-3) or audio (4) player on detail page. Squashed both patches together Bug 8377 [ENH] Followup: Move perl module to C4 Bug 8377 [ENH] Followup: fix call for moved module -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #23 from Mirko Tietgen <mirko@abunchofthings.net> --- Hi Paul, thanks a lot for reviewing the patch. I have - rebased to master - moved HTML5Media.pm to C4 - changed references to C4::HTML5Media.pm in catalogue/detail.pl and opac/opac-detail.pl - set up a sandbox to verify everything is OK http://catalogue.test7.biblibre.com/cgi-bin/koha/opac-search.pl?q=8377 http://pro.test7.biblibre.com/cgi-bin/koha/catalogue/search.pl?q=8377 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12378|0 |1 is obsolete| | --- Comment #24 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 12447 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12447&action=edit Bug 8377 [ENH] Show HTML5 video/ audio for media files in OPAC and staff client This enhancement uses information from MARC field 856 to generate the appropriate HTML5 code to embed am media player for the file(s) in a tab in the OPAC and staff client detail view. This patch supports the HTML5 <audio> and <video> element. Additionally it gives basic support for the <track> element. This element is not supported very well by recent browsers. Please consider the patch working when you get working video or audio. Changes since last version: - failed QA: removed default view for media tab, changed tab name to "Play audio" resp. "Play video". - put most of the code in separate module and access it from OPAC and staff client now, so the feature works in both - had to change sysprefs: HTML5MediaEnabled can be 'none', 'opac', 'staff' or 'both' * Removed default entry for mp3 again to not imply it is widely supported or going to be by free software browsers. If you tested this before, you need to delete the old syspref entries from your database. There is an attachment to do this, use exactly like upgradedatabase.pl. Test plan - Import attached test data. [I chose media typ 'bk' because it's probably present on most systems. It's not appropriate for the data but that doesn't matter.] - Rebuild zebra -b -z - Go to Administration->System preferences->enhanced content->HTML5 Media and set HTML5MediaEnabled to an appropriate setting, save preferences. - Search the OPAC or staff client for 'bug 8377' - Get 4 results - Open detail pages for results. Observe working video (1-3) or audio (4) player on detail page. Squashed both patches together Bug 8377 [ENH] Followup: Move perl module to C4 Bug 8377 [ENH] Followup: fix call for moved module Rebased to Master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12447|0 |1 is obsolete| | --- Comment #25 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 12603 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12603&action=edit Bug 8377 [ENH] Show HTML5 video/ audio for media files in OPAC and staff client This enhancement uses information from MARC field 856 to generate the appropriate HTML5 code to embed am media player for the file(s) in a tab in the OPAC and staff client detail view. This patch supports the HTML5 <audio> and <video> element. Additionally it gives basic support for the <track> element. This element is not supported very well by recent browsers. Please consider the patch working when you get working video or audio. Rebased to Master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |rel_3_12 --- Comment #26 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Changing target version so this bug report will show up in the list of 3.12-targeted features and doesn't get lost in the shuffle during feature freeze. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 --- Comment #27 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 13343 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13343&action=edit Bug 8377: Followup move style in a css file and do not pass template to a pm 1/ It's better to set style of the video marked in a css file. 2/ Replace some for my $i in (0..#$array) with for my $element in (@array) 3/ the routine in a pm returns a hash not the $template variable -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |jonathan.druart@biblibre.co | |m --- Comment #28 from Jonathan Druart <jonathan.druart@biblibre.com> --- Hi Mirko, Please take a look to my patch and test it. I change some code, I hope you are ok with it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 --- Comment #29 from Mirko Tietgen <mirko@abunchofthings.net> --- Hi Jonathan, with your followup I get Can't locate object method "field" via package "C4::Templates" at /home/mirko/koha/C4/HTML5Media.pm line 47. in both OPAC and staff client. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13343|0 |1 is obsolete| | --- Comment #30 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 13623 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13623&action=edit Bug 8377: Followup move style in a css file and do not pass template to a pm 1/ It's better to set style of the video marked in a css file. 2/ Replace some for my $i in (0..#$array) with for my $element in (@array) 3/ the routine in a pm returns a hash not the $template variable -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 --- Comment #31 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #29)
Hi Jonathan,
with your followup I get
Can't locate object method "field" via package "C4::Templates" at /home/mirko/koha/C4/HTML5Media.pm line 47.
in both OPAC and staff client.
Sorry Mirko, could you please test with this new patch please ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 --- Comment #32 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 13635 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13635&action=edit Bug 8377 [ENH] Show HTML5 video/ audio for media files in OPAC and staff client This enhancement uses information from MARC field 856 to generate the appropriate HTML5 code to embed am media player for the file(s) in a tab in the OPAC and staff client detail view. This patch supports the HTML5 <audio> and <video> element. Additionally it gives basic support for the <track> element. This element is not supported very well by recent browsers. Please consider the patch working when you get working video or audio. Rebased to Master 22.11.2012 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12603|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13623|0 |1 is obsolete| | --- Comment #33 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 13636 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13636&action=edit Bug 8377: Followup move style in a css file and do not pass template to a pm 1/ It's better to set style of the video marked in a css file. 2/ Replace some for my $i in (0..#$array) with for my $element in (@array) 3/ the routine in a pm returns a hash not the $template variable Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #34 from Mirko Tietgen <mirko@abunchofthings.net> --- Rebased my patch, signed off the followup. Thanks Jonathan. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|jonathan.druart@biblibre.co |m.de.rooy@rijksmuseum.nl |m | --- Comment #35 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Jonathan: This patch was now first on the list for QA. It seems to me however that you forgot to sign off on the first patch of Mirko. Could you do that now? Thanks. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #36 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #35)
Jonathan: This patch was now first on the list for QA. It seems to me however that you forgot to sign off on the first patch of Mirko. Could you do that now? Thanks.
I never signed off this patch :) Back to "Needs Signoff" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 --- Comment #37 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Chris: Looking at the history, I see that you did a signoff on this patch sometime ago. Could you please resign the current version? Marcel -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13635|0 |1 is obsolete| | --- Comment #38 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 14279 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14279&action=edit Bug 8377 [ENH] Show HTML5 video/ audio for media files in OPAC and staff client This enhancement uses information from MARC field 856 to generate the appropriate HTML5 code to embed am media player for the file(s) in a tab in the OPAC and staff client detail view. This patch supports the HTML5 <audio> and <video> element. Additionally it gives basic support for the <track> element. This element is not supported very well by recent browsers. Please consider the patch working when you get working video or audio. Rebased to Master 22.11.2012 Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13636|0 |1 is obsolete| | --- Comment #39 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 14280 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14280&action=edit Bug 8377: Followup move style in a css file and do not pass template to a pm 1/ It's better to set style of the video marked in a css file. 2/ Replace some for my $i in (0..#$array) with for my $element in (@array) 3/ the routine in a pm returns a hash not the $template variable Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|m.de.rooy@rijksmuseum.nl |jonathan.druart@biblibre.co | |m --- Comment #40 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comments: The code is clean, nothing to add. I proposed a followup for a little part of the code that required minor modifications. Thanks for the test plan and the test data, it was very useful! Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14279|0 |1 is obsolete| | --- Comment #41 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14284 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14284&action=edit Bug 8377 [ENH] Show HTML5 video/ audio for media files in OPAC and staff client This enhancement uses information from MARC field 856 to generate the appropriate HTML5 code to embed am media player for the file(s) in a tab in the OPAC and staff client detail view. This patch supports the HTML5 <audio> and <video> element. Additionally it gives basic support for the <track> element. This element is not supported very well by recent browsers. Please consider the patch working when you get working video or audio. Rebased to Master 22.11.2012 Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14280|0 |1 is obsolete| | --- Comment #42 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14285 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14285&action=edit Bug 8377: Followup move style in a css file and do not pass template to a pm 1/ It's better to set style of the video marked in a css file. 2/ Replace some for my $i in (0..#$array) with for my $element in (@array) 3/ the routine in a pm returns a hash not the $template variable Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #43 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org