[Bug 27321] New: Make excluded database columns in system preferences more clearly disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27321 Bug ID: 27321 Summary: Make excluded database columns in system preferences more clearly disabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Bug 17364 added the ability to exclude database columns in system preferences. When something is disabled the checkbox is disabled but it is still hard to tell its disabled because the corresponding label remains the same color as all the others. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27321 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17364 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 [Bug 17364] branchcode in BorrowerUnwantedField causes software error when saving patron record. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27321 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27321 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 114761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114761&action=edit Bug 27321: make disabled labels #cccccc To test: 1. Apply patch and its dependency (bug 17364) 2. Go the system pref BorroweUnwantedFields 3. branchcode should cleary stand out as disabled (#cccccc) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27321 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27321 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114761|0 |1 is obsolete| | --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 114763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114763&action=edit Bug 27321: make disabled labels #cccccc To test: 1. Apply patch and its dependency (bug 17364) 2. Go the system pref BorroweUnwantedFields 3. branchcode should cleary stand out as disabled (#cccccc) Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27321 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #3 from Fridolin Somers <fridolin.somers@biblibre.com> --- Oh style inside HTML :/ In my opinion it whould be better into CSS file. With selector : .dbcolumn_selection:disabled -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27321 --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Fridolin Somers from comment #3)
Oh style inside HTML :/
In my opinion it whould be better into CSS file. With selector : .dbcolumn_selection:disabled
.dbcolumn_selection:disabled will style the disabled input but not it's parent, the label. In my opinion we want to be able to make the label have a gray color (#cccccc) Since CSS cannot target an element's parent I chose to style inline. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27321 --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Lucas Gass from comment #4)
(In reply to Fridolin Somers from comment #3)
Oh style inside HTML :/
In my opinion it whould be better into CSS file. With selector : .dbcolumn_selection:disabled
.dbcolumn_selection:disabled will style the disabled input but not it's parent, the label. In my opinion we want to be able to make the label have a gray color (#cccccc)
Since CSS cannot target an element's parent I chose to style inline.
Oooo indeed my mistake :O Thanks a lot for the explanation. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27321 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27321 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 115045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115045&action=edit Bug 27321: (follow-up) Use class instead of style attribute. This patch relplaces the inline style and uses a class name instead. SCSS is modified, so rebuild the staff client CSS before testing (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27321 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can we please get a quick sign-off here so I can move on with the dependent bug? :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27321 --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Owen Leonard from comment #6)
Created attachment 115045 [details] [review] Bug 27321: (follow-up) Use class instead of style attribute.
This patch relplaces the inline style and uses a class name instead. SCSS is modified, so rebuild the staff client CSS before testing (https://wiki.koha-community.org/wiki/ Working_with_SCSS_in_the_OPAC_and_staff_client).
Owen, this is a much smarter way to do it than with the inline style I was using. However there is one problem. If I apply this and look at borrowerUnwantedField the disabled class is applied to 'branchcode' but it is also applied to every subsequent db column. I think in the else block we need tell it which class to have. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27321 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114763|0 |1 is obsolete| | Attachment #115045|0 |1 is obsolete| | --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 115103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115103&action=edit Bug 27321: Make disabled DB columns clearly disabled visually To test: 1. Apply patch and its dependency (bug 17364) 2. Rebuild the CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) 3. Go the system pref BorroweUnwantedFields 4. branchcode should cleary stand out as disabled (#cccccc) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27321 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27321 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27261 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27261 [Bug 27261] PatronSelfRegistrationBorrowerUnwantedField should exclude branchcode -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27321 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27321 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115103|0 |1 is obsolete| | --- Comment #10 from David Nind <david@davidnind.com> --- Created attachment 116088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116088&action=edit Bug 27321: Make disabled DB columns clearly disabled visually To test: 1. Apply patch and its dependency (bug 17364) 2. Rebuild the CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) 3. Go the system pref BorroweUnwantedFields 4. branchcode should cleary stand out as disabled (#cccccc) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27321 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |david@davidnind.com --- Comment #11 from David Nind <david@davidnind.com> --- I had trouble getting this patch to apply with the dependencies, but managed to git there in the end: - git bz apply 17364 - git bz apply 27321 (git bz apply 27321 - Bug 27321 Depends on bug 27261 Follow? [(y)es, (n)o] y) If I just went git bz apply 27321 and said yes to dependent bugs (only 27261) then it wouldn't apply. In the test plan I'm assuming BorroweUnwantedFields should be PatronSelfRegistrationBorrowerUnwantedField -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27321 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27321 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|17364 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 [Bug 17364] branchcode in BorrowerUnwantedField causes software error when saving patron record -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27321 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27321 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116088|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 116118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116118&action=edit Bug 27321: Make disabled DB columns clearly disabled visually To test: 1. Apply patch and its dependency (bug 17364) 2. Rebuild the CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) 3. Go the system pref BorroweUnwantedFields 4. branchcode should cleary stand out as disabled (#cccccc) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27321 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Updating this to a bug fix as I think we should not push the dependent bugs without this final style fix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27321 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27321 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27321 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00 |21.05.00,20.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27321 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement styles release notes| |non-selectable database | |columns in system | |preferences in a light grey | |(#cccccc), making them | |easier to identify. | |Currently the checkbox and | |label are the same color as | |selectable columns. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27321 Bug 27321 depends on bug 27261, which changed state. Bug 27261 Summary: PatronSelfRegistrationBorrowerUnwantedField should exclude branchcode https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27261 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27321 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |andrew@bywatersolutions.com --- Comment #16 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Missing dependency, not backporting to 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27321 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Keywords| |Manual -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org